Re: [v2,2/5] i2c: meson: add configurable divider factors

2018-01-24 Thread Wolfram Sang
> but, I didn't get this build warnings while test locally, so is there > any specific compiler option that I need to pass to? I used "W=1 C=1" when compiling. My gcc version is: (Debian 6.3.0-18) 6.3.0 20170516 signature.asc Description: PGP signature

Re: [v2,2/5] i2c: meson: add configurable divider factors

2018-01-24 Thread Wolfram Sang
> but, I didn't get this build warnings while test locally, so is there > any specific compiler option that I need to pass to? I used "W=1 C=1" when compiling. My gcc version is: (Debian 6.3.0-18) 6.3.0 20170516 signature.asc Description: PGP signature

Re: [v2,2/5] i2c: meson: add configurable divider factors

2018-01-23 Thread Yixun Lan
Hi Wolfram: On 01/24/18 14:28, Wolfram Sang wrote: > On Mon, Nov 20, 2017 at 10:54:12PM +0800, Yixun Lan wrote: >> From: Jian Hu >> >> This patch try to add support for I2C controller in Meson-AXG SoC, >> Due to the IP changes between I2C controller, we need to introduce

Re: [v2,2/5] i2c: meson: add configurable divider factors

2018-01-23 Thread Yixun Lan
Hi Wolfram: On 01/24/18 14:28, Wolfram Sang wrote: > On Mon, Nov 20, 2017 at 10:54:12PM +0800, Yixun Lan wrote: >> From: Jian Hu >> >> This patch try to add support for I2C controller in Meson-AXG SoC, >> Due to the IP changes between I2C controller, we need to introduce >> a compatible data

Re: [v2,2/5] i2c: meson: add configurable divider factors

2018-01-23 Thread Wolfram Sang
On Mon, Nov 20, 2017 at 10:54:12PM +0800, Yixun Lan wrote: > From: Jian Hu > > This patch try to add support for I2C controller in Meson-AXG SoC, > Due to the IP changes between I2C controller, we need to introduce > a compatible data to make the divider factor configurable.

Re: [v2,2/5] i2c: meson: add configurable divider factors

2018-01-23 Thread Wolfram Sang
On Mon, Nov 20, 2017 at 10:54:12PM +0800, Yixun Lan wrote: > From: Jian Hu > > This patch try to add support for I2C controller in Meson-AXG SoC, > Due to the IP changes between I2C controller, we need to introduce > a compatible data to make the divider factor configurable. > > Reviewed-by: