Re: [v3,2/6] power: add power sequence library

2016-08-01 Thread Peter Chen
On Fri, Jul 29, 2016 at 01:06:48PM -0700, Matthias Kaehlcke wrote: > >... > > > >+static int pwrseq_generic_get(struct device_node *np, struct pwrseq *pwrseq) > >+{ > >+struct pwrseq_generic *pwrseq_gen = to_generic_pwrseq(pwrseq); > >+enum of_gpio_flags flags; > >+int reset_gpio, ret =

Re: [v3,2/6] power: add power sequence library

2016-07-31 Thread Peter Chen
On Fri, Jul 29, 2016 at 01:06:48PM -0700, Matthias Kaehlcke wrote: > Hi Peter, > > Thanks for your work on this, a few comments inline > > > On 07/20/2016 02:40 AM, Peter Chen wrote: > > >... > > > >+static int pwrseq_generic_on(struct device_node *np, struct pwrseq *pwrseq) > >+{ > > > >... >

Re: [v3,2/6] power: add power sequence library

2016-07-29 Thread Matthias Kaehlcke
Hi Peter, Thanks for your work on this, a few comments inline On 07/20/2016 02:40 AM, Peter Chen wrote: ... +static int pwrseq_generic_on(struct device_node *np, struct pwrseq *pwrseq) +{ ... + if (gpiod_reset) { + u32 duration_us = 50; + + of_property_rea