Re: [v3] clk: hisilicon: refine hi3620_mmc_clk_init() and fix memory leak issues

2020-11-19 Thread Dongjiu Geng
On 2020/11/19 22:40, Markus Elfring wrote: >> How about we adjust such a function call in another series patches? > > You can try to offer desirable changes also in a corresponding patch series > as usual. sure, ok > > Regards, > Markus > . >

Re: [PATCH v3] clk: hisilicon: refine hi3620_mmc_clk_init() and fix memory leak issues

2020-11-19 Thread Dongjiu Geng
On 2020/11/19 17:07, Markus Elfring wrote: >> Refine hi3620_mmc_clk_init() to use of_clk_add_hw_provider() >> instead of of_clk_add_provider(), … > > … >> +++ b/drivers/clk/hisilicon/clk-hi3620.c > … >> @@ -439,17 +440,22 @@ static struct clk *hisi_register_clk_mmc(struct >> hisi_mmc_clock

Re: [PATCH V3] clk: hisilicon: refine hi3620_mmc_clk_init() and fix memory leak issues

2020-11-18 Thread Dongjiu Geng
ping, sorry for this noise. On 2020/11/13 3:22, Dongjiu Geng wrote: > Refine hi3620_mmc_clk_init() to use of_clk_add_hw_provider() > instead of of_clk_add_provider(), the called function hisi_register_clk_mmc() > returns 'clk_hw *' to adapt to this change. Also free memory mapping and > free

Re: [PATCH V3] clk: hisilicon: refine hi3620_mmc_clk_init() and fix memory leak issues

2020-11-12 Thread Dongjiu Geng
add Markus On 2020/11/13 3:22, Dongjiu Geng wrote: > Refine hi3620_mmc_clk_init() to use of_clk_add_hw_provider() > instead of of_clk_add_provider(), the called function hisi_register_clk_mmc() > returns 'clk_hw *' to adapt to this change. Also free memory mapping and > free hw_data if clock

[PATCH V3] clk: hisilicon: refine hi3620_mmc_clk_init() and fix memory leak issues

2020-11-12 Thread Dongjiu Geng
Refine hi3620_mmc_clk_init() to use of_clk_add_hw_provider() instead of of_clk_add_provider(), the called function hisi_register_clk_mmc() returns 'clk_hw *' to adapt to this change. Also free memory mapping and free hw_data if clock initialization is failed. Fix the memory leak issues in