Re: [v3 PATCH 2/4] mm: move mem_cgroup_uncharge out of __page_cache_release()

2019-06-25 Thread Yang Shi
On 6/25/19 2:35 AM, Kirill A. Shutemov wrote: On Mon, Jun 24, 2019 at 09:54:05AM -0700, Yang Shi wrote: On 6/13/19 10:13 AM, Yang Shi wrote: On 6/13/19 4:39 AM, Kirill A. Shutemov wrote: On Thu, Jun 13, 2019 at 05:56:47AM +0800, Yang Shi wrote: The later patch would make THP deferred

Re: [v3 PATCH 2/4] mm: move mem_cgroup_uncharge out of __page_cache_release()

2019-06-25 Thread Kirill A. Shutemov
On Mon, Jun 24, 2019 at 09:54:05AM -0700, Yang Shi wrote: > > > On 6/13/19 10:13 AM, Yang Shi wrote: > > > > > > On 6/13/19 4:39 AM, Kirill A. Shutemov wrote: > > > On Thu, Jun 13, 2019 at 05:56:47AM +0800, Yang Shi wrote: > > > > The later patch would make THP deferred split shrinker memcg

Re: [v3 PATCH 2/4] mm: move mem_cgroup_uncharge out of __page_cache_release()

2019-06-24 Thread Yang Shi
On 6/13/19 10:13 AM, Yang Shi wrote: On 6/13/19 4:39 AM, Kirill A. Shutemov wrote: On Thu, Jun 13, 2019 at 05:56:47AM +0800, Yang Shi wrote: The later patch would make THP deferred split shrinker memcg aware, but it needs page->mem_cgroup information in THP destructor, which is called

[v3 PATCH 2/4] mm: move mem_cgroup_uncharge out of __page_cache_release()

2019-06-13 Thread Yang Shi
The later patch would make THP deferred split shrinker memcg aware, but it needs page->mem_cgroup information in THP destructor, which is called after mem_cgroup_uncharge() now. So, move mem_cgroup_uncharge() from __page_cache_release() to compound page destructor, which is called by both THP and

Re: [v3 PATCH 2/4] mm: move mem_cgroup_uncharge out of __page_cache_release()

2019-06-13 Thread Yang Shi
On 6/13/19 4:39 AM, Kirill A. Shutemov wrote: On Thu, Jun 13, 2019 at 05:56:47AM +0800, Yang Shi wrote: The later patch would make THP deferred split shrinker memcg aware, but it needs page->mem_cgroup information in THP destructor, which is called after mem_cgroup_uncharge() now. So, move

Re: [v3 PATCH 2/4] mm: move mem_cgroup_uncharge out of __page_cache_release()

2019-06-13 Thread Kirill A. Shutemov
On Thu, Jun 13, 2019 at 05:56:47AM +0800, Yang Shi wrote: > The later patch would make THP deferred split shrinker memcg aware, but > it needs page->mem_cgroup information in THP destructor, which is called > after mem_cgroup_uncharge() now. > > So, move mem_cgroup_uncharge() from