Re: [v4][PATCH 2/6] mm: swap: make 'struct page' and swp_entry_t variants of swapcache_free().

2013-06-03 Thread Dave Hansen
On 06/02/2013 11:13 PM, Minchan Kim wrote: > I lost from this description. > > Old behavior > > delete_from_swap_cache > swap_address_space > __delete_from_swap_cache > swap_address_space > > > New behavior > > delete_from_swap_cache >

Re: [v4][PATCH 2/6] mm: swap: make 'struct page' and swp_entry_t variants of swapcache_free().

2013-06-03 Thread Minchan Kim
Hello Dave, On Fri, May 31, 2013 at 11:38:58AM -0700, Dave Hansen wrote: > > From: Dave Hansen > > swapcache_free() takes two arguments: > > void swapcache_free(swp_entry_t entry, struct page *page) > > Most of its callers (5/7) are from error handling paths haven't even > instantiated

Re: [v4][PATCH 2/6] mm: swap: make 'struct page' and swp_entry_t variants of swapcache_free().

2013-06-03 Thread Minchan Kim
Hello Dave, On Fri, May 31, 2013 at 11:38:58AM -0700, Dave Hansen wrote: From: Dave Hansen dave.han...@linux.intel.com swapcache_free() takes two arguments: void swapcache_free(swp_entry_t entry, struct page *page) Most of its callers (5/7) are from error handling paths haven't

Re: [v4][PATCH 2/6] mm: swap: make 'struct page' and swp_entry_t variants of swapcache_free().

2013-06-03 Thread Dave Hansen
On 06/02/2013 11:13 PM, Minchan Kim wrote: I lost from this description. Old behavior delete_from_swap_cache swap_address_space __delete_from_swap_cache swap_address_space New behavior delete_from_swap_cache __delete_from_swap_cache

[v4][PATCH 2/6] mm: swap: make 'struct page' and swp_entry_t variants of swapcache_free().

2013-05-31 Thread Dave Hansen
From: Dave Hansen swapcache_free() takes two arguments: void swapcache_free(swp_entry_t entry, struct page *page) Most of its callers (5/7) are from error handling paths haven't even instantiated a page, so they pass page=NULL. Both of the callers that call in with a 'struct page'

[v4][PATCH 2/6] mm: swap: make 'struct page' and swp_entry_t variants of swapcache_free().

2013-05-31 Thread Dave Hansen
From: Dave Hansen dave.han...@linux.intel.com swapcache_free() takes two arguments: void swapcache_free(swp_entry_t entry, struct page *page) Most of its callers (5/7) are from error handling paths haven't even instantiated a page, so they pass page=NULL. Both of the callers that call