Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove bad usage of ERESTARTSYS

2007-10-11 Thread Randy Dunlap
On Wed, 10 Oct 2007 00:18:28 -0400 Michael Krufky wrote: > Mauro Carvalho Chehab wrote: > > Hi Jiri, > > > > Em Seg, 2007-10-08 às 13:41 +0100, Jiri Slaby escreveu: > > > >> cinergyT2, remove bad usage of ERESTARTSYS > >> > >> test of cinergyt2->disconnect_pending doesn't ensure pending signal

Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove bad usage of ERESTARTSYS

2007-10-11 Thread Michael Krufky
Mauro Carvalho Chehab wrote: > Hi Jiri, > > Em Seg, 2007-10-08 às 13:41 +0100, Jiri Slaby escreveu: > >> cinergyT2, remove bad usage of ERESTARTSYS >> >> test of cinergyt2->disconnect_pending doesn't ensure pending signal and so >> ERESTARTSYS would reach userspace, which is not permitted. Chang

Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove bad usage of ERESTARTSYS

2007-10-10 Thread Marcel Siegert
Manu Abraham schrieb: Marcel Siegert wrote: Manu Abraham schrieb: Mauro Carvalho Chehab wrote: Em Qua, 2007-10-10 Ã s 11:59 -0400, Alan Cox escreveu: On Wed, Oct 10, 2007 at 12:35:41PM -0300, Mauro Carvalho Chehab wrote: Em Qua, 2007-10-10 Ã s 00:18 -0400, Michael Krufky escreveu: Is this i

Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove bad usage of ERESTARTSYS

2007-10-10 Thread Manu Abraham
Marcel Siegert wrote: > Manu Abraham schrieb: >> Mauro Carvalho Chehab wrote: >>> Em Qua, 2007-10-10 Ã s 11:59 -0400, Alan Cox escreveu: On Wed, Oct 10, 2007 at 12:35:41PM -0300, Mauro Carvalho Chehab wrote: > Em Qua, 2007-10-10 Ã s 00:18 -0400, Michael Krufky escreveu: >> Is this ille

Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove bad usage of ERESTARTSYS

2007-10-10 Thread Marcel Siegert
Manu Abraham schrieb: Mauro Carvalho Chehab wrote: Em Qua, 2007-10-10 Ã s 11:59 -0400, Alan Cox escreveu: On Wed, Oct 10, 2007 at 12:35:41PM -0300, Mauro Carvalho Chehab wrote: Em Qua, 2007-10-10 Ã s 00:18 -0400, Michael Krufky escreveu: Is this illegal as per kernel codingstyle? Yes, it is.

Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove bad usage of ERESTARTSYS

2007-10-10 Thread Manu Abraham
Mauro Carvalho Chehab wrote: > Em Qua, 2007-10-10 Ã s 11:59 -0400, Alan Cox escreveu: >> On Wed, Oct 10, 2007 at 12:35:41PM -0300, Mauro Carvalho Chehab wrote: >>> Em Qua, 2007-10-10 Ã s 00:18 -0400, Michael Krufky escreveu: Is this illegal as per kernel codingstyle? >>> Yes, it is. CodingStyl

Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove bad usage of ERESTARTSYS

2007-10-10 Thread Mauro Carvalho Chehab
Em Qua, 2007-10-10 às 11:59 -0400, Alan Cox escreveu: > On Wed, Oct 10, 2007 at 12:35:41PM -0300, Mauro Carvalho Chehab wrote: > > Em Qua, 2007-10-10 às 00:18 -0400, Michael Krufky escreveu: > > > > > > Is this illegal as per kernel codingstyle? > > > > Yes, it is. CodingStyle states: > > > No

Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove bad usage of ERESTARTSYS

2007-10-10 Thread Alan Cox
On Wed, Oct 10, 2007 at 12:35:41PM -0300, Mauro Carvalho Chehab wrote: > Em Qua, 2007-10-10 às 00:18 -0400, Michael Krufky escreveu: > > > > Is this illegal as per kernel codingstyle? > > Yes, it is. CodingStyle states: No.. "Illegal" means prohibited by law. Its merely wrong 8) > The proper

Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove bad usage of ERESTARTSYS

2007-10-10 Thread Mauro Carvalho Chehab
Em Qua, 2007-10-10 às 00:18 -0400, Michael Krufky escreveu: > > Is this illegal as per kernel codingstyle? Yes, it is. CodingStyle states: "Don't put multiple statements on a single line unless you have something to hide" and "Don't put multiple assignments on a single line either. Kern