Re: [v5,2/3] spi: mediatek: Add spi bus for Mediatek MT8173

Hi, > > +#include > > +#include > > +#include > > +#include > > Since you are using readl/writel, please import linux/io.h as well (it > is implicitly imported by spi/spi.h, but better be safe...) > OK, I'll fix it. > > +#include > > +#include > > +#include > > + > > +#define

Re: [v5,2/3] spi: mediatek: Add spi bus for Mediatek MT8173

Hi, +#include linux/clk.h +#include linux/device.h +#include linux/err.h +#include linux/interrupt.h Since you are using readl/writel, please import linux/io.h as well (it is implicitly imported by spi/spi.h, but better be safe...) OK, I'll fix it. +#include linux/ioport.h

Re: [v5,2/3] spi: mediatek: Add spi bus for Mediatek MT8173

Hi Leilk, On Fri, Aug 7, 2015 at 3:19 PM, wrote: > This patch adds basic spi bus for MT8173. > > Signed-off-by: Leilk Liu > > --- > Change in this patch: > 1. change "pad-select" to "mediatek,pad-select". > 2. modify clk relevant implement. > --- > drivers/spi/Kconfig |

Re: [v5,2/3] spi: mediatek: Add spi bus for Mediatek MT8173

Hi Leilk, On Fri, Aug 7, 2015 at 3:19 PM, leilk@mediatek.com wrote: This patch adds basic spi bus for MT8173. Signed-off-by: Leilk Liu leilk@mediatek.com --- Change in this patch: 1. change pad-select to mediatek,pad-select. 2. modify clk relevant implement. ---