[v5 2/2] gpio: aspeed: Add SGPIO driver

2019-07-29 Thread Hongwei Zhang
Add SGPIO driver support for Aspeed AST2500 SoC. Signed-off-by: Hongwei Zhang --- drivers/gpio/sgpio-aspeed.c | 521 1 file changed, 521 insertions(+) create mode 100644 drivers/gpio/sgpio-aspeed.c diff --git a/drivers/gpio/sgpio-aspeed.c

Re: [v5 2/2] gpio: aspeed: Add SGPIO driver

2019-07-28 Thread Linus Walleij
On Mon, Jul 22, 2019 at 10:37 PM Hongwei Zhang wrote: > As you suspected it correctly, AST2500 utilizes all the 32 bits of the > registers > (data value, interrupt, etc...), such that using 8-bit bands > [7:0]/[15:8]/23:16]/[31:24] of GPIO_200H for SGPIO_A/B/C/D . > so registering 10 gpiochip

[v5 2/2] gpio: aspeed: Add SGPIO driver

2019-07-22 Thread Hongwei Zhang
9 3:37 AM > To: Hongwei Zhang > Cc: Andrew Jeffery; open list:GPIO SUBSYSTEM; Joel Stanley; > linux-asp...@lists.ozlabs.org; Bartosz > Golaszewski; linux-kernel@vger.kernel.org; Linux ARM > Subject: Re: [v5 2/2] gpio: aspeed: Add SGPIO driver > > Hi Hongwei, > > th

Re: [v5 2/2] gpio: aspeed: Add SGPIO driver

2019-07-20 Thread Linus Walleij
Hi Hongwei, thanks for your patch! some comments and nitpicking below: On Fri, Jul 19, 2019 at 9:25 PM Hongwei Zhang wrote: > Add SGPIO driver support for Aspeed AST2500 SoC. > > Signed-off-by: Hongwei Zhang > +// SPDX-License-Identifier: GPL-2.0+ I think the SPDX people prefer

[v5 2/2] gpio: aspeed: Add SGPIO driver

2019-07-19 Thread Hongwei Zhang
Add SGPIO driver support for Aspeed AST2500 SoC. Signed-off-by: Hongwei Zhang --- drivers/gpio/sgpio-aspeed.c | 522 1 file changed, 522 insertions(+) create mode 100644 drivers/gpio/sgpio-aspeed.c diff --git a/drivers/gpio/sgpio-aspeed.c