Re: [v6,1/2] pid: Replace pid bitmap implementation with IDR API

2017-10-23 Thread Oleg Nesterov
On 10/22, Gargi Sharma wrote: > > On Fri, Oct 20, 2017 at 6:21 PM, Andrei Vagin wrote: > > On Fri, Oct 20, 2017 at 05:06:47PM +0100, Gargi Sharma wrote: > >> On Thu, Oct 19, 2017 at 5:18 PM, Oleg Nesterov wrote: > >> > > >> > unsigned int last; > >> > int err; > >> > > >> >

Re: [v6,1/2] pid: Replace pid bitmap implementation with IDR API

2017-10-22 Thread Gargi Sharma
On Fri, Oct 20, 2017 at 6:21 PM, Andrei Vagin wrote: > On Fri, Oct 20, 2017 at 05:06:47PM +0100, Gargi Sharma wrote: >> On Thu, Oct 19, 2017 at 5:18 PM, Oleg Nesterov wrote: >> > On 10/19, Andrei Vagin wrote: >> >> >> >> Hi Gargi, >> >> >> >> This patch breaks CRIU, because it changes a meaning o

Re: [v6,1/2] pid: Replace pid bitmap implementation with IDR API

2017-10-20 Thread Andrei Vagin
On Fri, Oct 20, 2017 at 05:06:47PM +0100, Gargi Sharma wrote: > On Thu, Oct 19, 2017 at 5:18 PM, Oleg Nesterov wrote: > > On 10/19, Andrei Vagin wrote: > >> > >> Hi Gargi, > >> > >> This patch breaks CRIU, because it changes a meaning of ns_last_pid. > > > > ... > > > >> > @@ -311,7 +297,7 @@ stat

Re: [v6,1/2] pid: Replace pid bitmap implementation with IDR API

2017-10-20 Thread Gargi Sharma
On Thu, Oct 19, 2017 at 5:18 PM, Oleg Nesterov wrote: > On 10/19, Andrei Vagin wrote: >> >> Hi Gargi, >> >> This patch breaks CRIU, because it changes a meaning of ns_last_pid. > > ... > >> > @@ -311,7 +297,7 @@ static int pid_ns_ctl_handler(struct ctl_table *table, >> > int write, >> > * it

Re: [v6,1/2] pid: Replace pid bitmap implementation with IDR API

2017-10-19 Thread Oleg Nesterov
On 10/19, Andrei Vagin wrote: > > Hi Gargi, > > This patch breaks CRIU, because it changes a meaning of ns_last_pid. ... > > @@ -311,7 +297,7 @@ static int pid_ns_ctl_handler(struct ctl_table *table, > > int write, > > * it should synchronize its usage with external means. > > */ > >

Re: [v6,1/2] pid: Replace pid bitmap implementation with IDR API

2017-10-19 Thread Gargi Sharma
On Thu, Oct 19, 2017 at 8:30 AM, Andrei Vagin wrote: > Hi Gargi, > > This patch breaks CRIU, because it changes a meaning of ns_last_pid. > > == Run zdtm/static/env00 in h > == > DEP env00.d > CCenv00.o > LINK env00 > Start tes

Re: [v6,1/2] pid: Replace pid bitmap implementation with IDR API

2017-10-19 Thread Andrei Vagin
Hi Gargi, This patch breaks CRIU, because it changes a meaning of ns_last_pid. == Run zdtm/static/env00 in h == DEP env00.d CCenv00.o LINK env00 Start test ./env00 --pidfile=env00.pid --outfile=env00.out --envname=ENV_00_TEST R