RE: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-13 Thread Reizer, Eyal
> > > > > > > > > > Sure, just want to make sure we are not trying to add work around just > for > > > A couple of faulty devices. > > > > > > > > I have verified using a couple of com6 modules with an am335x-evm > and > > > > they had mac addresses read ok. > > > > > > > > Sounds like there are

RE: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-13 Thread Reizer, Eyal
> > > > > > > > > > Sure, just want to make sure we are not trying to add work around just > for > > > A couple of faulty devices. > > > > > > > > I have verified using a couple of com6 modules with an am335x-evm > and > > > > they had mac addresses read ok. > > > > > > > > Sounds like there are

Re: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Tony Lindgren
* Reizer, Eyal [170810 07:24]: > > > > > > > Sure, just want to make sure we are not trying to add work around just for > > A couple of faulty devices. > > > > > > I have verified using a couple of com6 modules with an am335x-evm and > > > they had mac addresses read ok. > > > > >

Re: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Tony Lindgren
* Reizer, Eyal [170810 07:24]: > > > > > > > Sure, just want to make sure we are not trying to add work around just for > > A couple of faulty devices. > > > > > > I have verified using a couple of com6 modules with an am335x-evm and > > > they had mac addresses read ok. > > > > > > Sounds like

RE: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Reizer, Eyal
> > > > Sure, just want to make sure we are not trying to add work around just for > A couple of faulty devices. > > > > I have verified using a couple of com6 modules with an am335x-evm and > > they had mac addresses read ok. > > > > Sounds like there are multiple variants of the wl12xx > >

RE: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Reizer, Eyal
> > > > Sure, just want to make sure we are not trying to add work around just for > A couple of faulty devices. > > > > I have verified using a couple of com6 modules with an am335x-evm and > > they had mac addresses read ok. > > > > Sounds like there are multiple variants of the wl12xx > >

RE: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Reizer, Eyal
> > >> The fact that is old does not change a thing, we still need to > >> support it no matter what the data sheet and your system design > >> says. A fix that breaks other things is not really a fix :) > >> > > > > Sure, just want to make sure we are not trying to add work around just for > > A

RE: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Reizer, Eyal
> > >> The fact that is old does not change a thing, we still need to > >> support it no matter what the data sheet and your system design > >> says. A fix that breaks other things is not really a fix :) > >> > > > > Sure, just want to make sure we are not trying to add work around just for > > A

RE: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Reizer, Eyal
> > On Thu, Aug 10, 2017 at 4:35 PM, Reizer, Eyal wrote: > >> > > >> > Sorry for top posting (mobile...) > >> > I have verified with system design and the data sheet that every wilink > 6/7 > >> chip has a mac address in fuse so probably the board you have (pretty old, > >> right?)

RE: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Reizer, Eyal
> > On Thu, Aug 10, 2017 at 4:35 PM, Reizer, Eyal wrote: > >> > > >> > Sorry for top posting (mobile...) > >> > I have verified with system design and the data sheet that every wilink > 6/7 > >> chip has a mac address in fuse so probably the board you have (pretty old, > >> right?) has this mac

Re: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Julian Calaby
Hi Eyal, On Thu, Aug 10, 2017 at 4:35 PM, Reizer, Eyal wrote: >> > >> > Sorry for top posting (mobile...) >> > I have verified with system design and the data sheet that every wilink 6/7 >> chip has a mac address in fuse so probably the board you have (pretty old, >> right?) has

Re: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Julian Calaby
Hi Eyal, On Thu, Aug 10, 2017 at 4:35 PM, Reizer, Eyal wrote: >> > >> > Sorry for top posting (mobile...) >> > I have verified with system design and the data sheet that every wilink 6/7 >> chip has a mac address in fuse so probably the board you have (pretty old, >> right?) has this mac address

Re: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Kalle Valo
"Reizer, Eyal" writes: >> The fact that is old does not change a thing, we still need to >> support it no matter what the data sheet and your system design >> says. A fix that breaks other things is not really a fix :) >> > > Sure, just want to make sure we are not trying to add

Re: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Kalle Valo
"Reizer, Eyal" writes: >> The fact that is old does not change a thing, we still need to >> support it no matter what the data sheet and your system design >> says. A fix that breaks other things is not really a fix :) >> > > Sure, just want to make sure we are not trying to add work around

RE: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Reizer, Eyal
> > > > Sorry for top posting (mobile...) > > I have verified with system design and the data sheet that every wilink 6/7 > chip has a mac address in fuse so probably the board you have (pretty old, > right?) has this mac address in fuse. Maybe it was from very early batches? > Anyway I see no

RE: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Reizer, Eyal
> > > > Sorry for top posting (mobile...) > > I have verified with system design and the data sheet that every wilink 6/7 > chip has a mac address in fuse so probably the board you have (pretty old, > right?) has this mac address in fuse. Maybe it was from very early batches? > Anyway I see no

Re: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-09 Thread Tony Lindgren
* Reizer, Eyal [170809 10:40]: > Hi Tony, > > Sorry for top posting (mobile...) > I have verified with system design and the data sheet that every wilink 6/7 > chip has a mac address in fuse so probably the board you have (pretty old, > right?) has this mac address in fuse. Maybe

Re: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-09 Thread Tony Lindgren
* Reizer, Eyal [170809 10:40]: > Hi Tony, > > Sorry for top posting (mobile...) > I have verified with system design and the data sheet that every wilink 6/7 > chip has a mac address in fuse so probably the board you have (pretty old, > right?) has this mac address in fuse. Maybe it was from

Re: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-09 Thread Tony Lindgren
* Tony Lindgren [170809 10:26]: > * Reizer, Eyal [170809 00:55]: > > --- a/drivers/net/wireless/ti/wlcore/main.c > > +++ b/drivers/net/wireless/ti/wlcore/main.c > > @@ -6040,6 +6040,21 @@ static int wl1271_register_hw(struct wl1271 *wl) > > nic_addr =

Re: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-09 Thread Tony Lindgren
* Tony Lindgren [170809 10:26]: > * Reizer, Eyal [170809 00:55]: > > --- a/drivers/net/wireless/ti/wlcore/main.c > > +++ b/drivers/net/wireless/ti/wlcore/main.c > > @@ -6040,6 +6040,21 @@ static int wl1271_register_hw(struct wl1271 *wl) > > nic_addr = wl->fuse_nic_addr + 1; > > }

Re: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-09 Thread Tony Lindgren
* Reizer, Eyal [170809 00:55]: > --- a/drivers/net/wireless/ti/wlcore/main.c > +++ b/drivers/net/wireless/ti/wlcore/main.c > @@ -6040,6 +6040,21 @@ static int wl1271_register_hw(struct wl1271 *wl) > nic_addr = wl->fuse_nic_addr + 1; > } > > + if (oui_addr

Re: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-09 Thread Tony Lindgren
* Reizer, Eyal [170809 00:55]: > --- a/drivers/net/wireless/ti/wlcore/main.c > +++ b/drivers/net/wireless/ti/wlcore/main.c > @@ -6040,6 +6040,21 @@ static int wl1271_register_hw(struct wl1271 *wl) > nic_addr = wl->fuse_nic_addr + 1; > } > > + if (oui_addr == 0xdeadbe &&

[v6] wlcore: add missing nvs file name info for wilink8

2017-08-09 Thread Reizer, Eyal
The following commits: commit c815fdebef44 ("wlcore: spi: Populate config firmware data") commit d776fc86b82f ("wlcore: sdio: Populate config firmware data") Populated the nvs entry for wilink6 and wilink7 only while it is still needed for wilink8 as well for specifying an alternate mac address.

[v6] wlcore: add missing nvs file name info for wilink8

2017-08-09 Thread Reizer, Eyal
The following commits: commit c815fdebef44 ("wlcore: spi: Populate config firmware data") commit d776fc86b82f ("wlcore: sdio: Populate config firmware data") Populated the nvs entry for wilink6 and wilink7 only while it is still needed for wilink8 as well for specifying an alternate mac address.