Re: [v6 PATCH 07/21] x86/insn-eval: Add utility function to get segment descriptor

2017-05-15 Thread Borislav Petkov
On Thu, May 11, 2017 at 07:13:57PM -0700, Ricardo Neri wrote: > Sure I can. Would this trigger a v8 of my series? I was hoping v7 series > could be merged and then start doing incremental work on top of it. Does > it make sense? I guess that's tip guys' call. -- Regards/Gruss, Boris. SUSE

Re: [v6 PATCH 07/21] x86/insn-eval: Add utility function to get segment descriptor

2017-05-15 Thread Borislav Petkov
On Thu, May 11, 2017 at 07:13:57PM -0700, Ricardo Neri wrote: > Sure I can. Would this trigger a v8 of my series? I was hoping v7 series > could be merged and then start doing incremental work on top of it. Does > it make sense? I guess that's tip guys' call. -- Regards/Gruss, Boris. SUSE

Re: [v6 PATCH 07/21] x86/insn-eval: Add utility function to get segment descriptor

2017-05-11 Thread Ricardo Neri
On Thu, 2017-05-04 at 13:02 +0200, Borislav Petkov wrote: > On Wed, Apr 26, 2017 at 02:51:56PM -0700, Ricardo Neri wrote: > > > > +seg >= > > > > current->active_mm->context.ldt->size)) { > > > > > > ldt->size is the size of the descriptor table but you've shifted seg

Re: [v6 PATCH 07/21] x86/insn-eval: Add utility function to get segment descriptor

2017-05-11 Thread Ricardo Neri
On Thu, 2017-05-04 at 13:02 +0200, Borislav Petkov wrote: > On Wed, Apr 26, 2017 at 02:51:56PM -0700, Ricardo Neri wrote: > > > > +seg >= > > > > current->active_mm->context.ldt->size)) { > > > > > > ldt->size is the size of the descriptor table but you've shifted seg

Re: [v6 PATCH 07/21] x86/insn-eval: Add utility function to get segment descriptor

2017-05-04 Thread Borislav Petkov
On Wed, Apr 26, 2017 at 02:51:56PM -0700, Ricardo Neri wrote: > > > + seg >= current->active_mm->context.ldt->size)) { > > > > ldt->size is the size of the descriptor table but you've shifted seg by > > 3. That selector index is shifted by 3 (to the left) to form an offset >

Re: [v6 PATCH 07/21] x86/insn-eval: Add utility function to get segment descriptor

2017-05-04 Thread Borislav Petkov
On Wed, Apr 26, 2017 at 02:51:56PM -0700, Ricardo Neri wrote: > > > + seg >= current->active_mm->context.ldt->size)) { > > > > ldt->size is the size of the descriptor table but you've shifted seg by > > 3. That selector index is shifted by 3 (to the left) to form an offset >

Re: [v6 PATCH 07/21] x86/insn-eval: Add utility function to get segment descriptor

2017-04-26 Thread Ricardo Neri
On Wed, 2017-04-19 at 12:26 +0200, Borislav Petkov wrote: > On Tue, Mar 07, 2017 at 04:32:40PM -0800, Ricardo Neri wrote: > > The segment descriptor contains information that is relevant to how linear > > address need to be computed. It contains the default size of addresses as > > well as the

Re: [v6 PATCH 07/21] x86/insn-eval: Add utility function to get segment descriptor

2017-04-26 Thread Ricardo Neri
On Wed, 2017-04-19 at 12:26 +0200, Borislav Petkov wrote: > On Tue, Mar 07, 2017 at 04:32:40PM -0800, Ricardo Neri wrote: > > The segment descriptor contains information that is relevant to how linear > > address need to be computed. It contains the default size of addresses as > > well as the

Re: [v6 PATCH 07/21] x86/insn-eval: Add utility function to get segment descriptor

2017-04-19 Thread Borislav Petkov
On Tue, Mar 07, 2017 at 04:32:40PM -0800, Ricardo Neri wrote: > The segment descriptor contains information that is relevant to how linear > address need to be computed. It contains the default size of addresses as > well as the base address of the segment. Thus, given a segment selector, > we

Re: [v6 PATCH 07/21] x86/insn-eval: Add utility function to get segment descriptor

2017-04-19 Thread Borislav Petkov
On Tue, Mar 07, 2017 at 04:32:40PM -0800, Ricardo Neri wrote: > The segment descriptor contains information that is relevant to how linear > address need to be computed. It contains the default size of addresses as > well as the base address of the segment. Thus, given a segment selector, > we

[v6 PATCH 07/21] x86/insn-eval: Add utility function to get segment descriptor

2017-03-07 Thread Ricardo Neri
The segment descriptor contains information that is relevant to how linear address need to be computed. It contains the default size of addresses as well as the base address of the segment. Thus, given a segment selector, we ought look at segment descriptor to correctly calculate the linear

[v6 PATCH 07/21] x86/insn-eval: Add utility function to get segment descriptor

2017-03-07 Thread Ricardo Neri
The segment descriptor contains information that is relevant to how linear address need to be computed. It contains the default size of addresses as well as the base address of the segment. Thus, given a segment selector, we ought look at segment descriptor to correctly calculate the linear