Re: [v6 PATCH 2/2] mm: vmscan: correct some vmscan counters for THP swapout

2019-05-27 Thread Yang Shi
On 5/27/19 3:55 PM, Huang, Ying wrote: Yang Shi writes: On 5/27/19 3:06 PM, Huang, Ying wrote: Yang Shi writes: Since commit bd4c82c22c36 ("mm, THP, swap: delay splitting THP after swapped out"), THP can be swapped out in a whole. But, nr_reclaimed and some other vm counters still get

Re: [v6 PATCH 2/2] mm: vmscan: correct some vmscan counters for THP swapout

2019-05-27 Thread Huang, Ying
Yang Shi writes: > On 5/27/19 3:06 PM, Huang, Ying wrote: >> Yang Shi writes: >> >>> Since commit bd4c82c22c36 ("mm, THP, swap: delay splitting THP after >>> swapped out"), THP can be swapped out in a whole. But, nr_reclaimed >>> and some other vm counters still get inc'ed by one even though a

Re: [v6 PATCH 2/2] mm: vmscan: correct some vmscan counters for THP swapout

2019-05-27 Thread Yang Shi
On 5/27/19 3:06 PM, Huang, Ying wrote: Yang Shi writes: Since commit bd4c82c22c36 ("mm, THP, swap: delay splitting THP after swapped out"), THP can be swapped out in a whole. But, nr_reclaimed and some other vm counters still get inc'ed by one even though a whole THP (512 pages) gets swapp

Re: [v6 PATCH 2/2] mm: vmscan: correct some vmscan counters for THP swapout

2019-05-27 Thread Huang, Ying
Yang Shi writes: > Since commit bd4c82c22c36 ("mm, THP, swap: delay splitting THP after > swapped out"), THP can be swapped out in a whole. But, nr_reclaimed > and some other vm counters still get inc'ed by one even though a whole > THP (512 pages) gets swapped out. > > This doesn't make too muc

[v6 PATCH 2/2] mm: vmscan: correct some vmscan counters for THP swapout

2019-05-26 Thread Yang Shi
Since commit bd4c82c22c36 ("mm, THP, swap: delay splitting THP after swapped out"), THP can be swapped out in a whole. But, nr_reclaimed and some other vm counters still get inc'ed by one even though a whole THP (512 pages) gets swapped out. This doesn't make too much sense to memory reclaim. Fo