Re: [v7 PATCH 06/12] mm: vmscan: add shrinker_info_protected() helper

2021-02-10 Thread Vlastimil Babka
On 2/9/21 6:46 PM, Yang Shi wrote: > The shrinker_info is dereferenced in a couple of places via > rcu_dereference_protected > with different calling conventions, for example, using mem_cgroup_nodeinfo > helper > or dereferencing memcg->nodeinfo[nid]->shrinker_info. And the later patch > will

Re: [v7 PATCH 06/12] mm: vmscan: add shrinker_info_protected() helper

2021-02-10 Thread Kirill Tkhai
On 09.02.2021 20:46, Yang Shi wrote: > The shrinker_info is dereferenced in a couple of places via > rcu_dereference_protected > with different calling conventions, for example, using mem_cgroup_nodeinfo > helper > or dereferencing memcg->nodeinfo[nid]->shrinker_info. And the later patch > will

Re: [v7 PATCH 06/12] mm: vmscan: add shrinker_info_protected() helper

2021-02-09 Thread Roman Gushchin
On Tue, Feb 09, 2021 at 05:07:07PM -0800, Yang Shi wrote: > On Tue, Feb 9, 2021 at 4:22 PM Roman Gushchin wrote: > > > > On Tue, Feb 09, 2021 at 09:46:40AM -0800, Yang Shi wrote: > > > The shrinker_info is dereferenced in a couple of places via > > > rcu_dereference_protected > > > with

Re: [v7 PATCH 06/12] mm: vmscan: add shrinker_info_protected() helper

2021-02-09 Thread Yang Shi
On Tue, Feb 9, 2021 at 4:22 PM Roman Gushchin wrote: > > On Tue, Feb 09, 2021 at 09:46:40AM -0800, Yang Shi wrote: > > The shrinker_info is dereferenced in a couple of places via > > rcu_dereference_protected > > with different calling conventions, for example, using mem_cgroup_nodeinfo > >

Re: [v7 PATCH 06/12] mm: vmscan: add shrinker_info_protected() helper

2021-02-09 Thread Roman Gushchin
On Tue, Feb 09, 2021 at 09:46:40AM -0800, Yang Shi wrote: > The shrinker_info is dereferenced in a couple of places via > rcu_dereference_protected > with different calling conventions, for example, using mem_cgroup_nodeinfo > helper > or dereferencing memcg->nodeinfo[nid]->shrinker_info. And

[v7 PATCH 06/12] mm: vmscan: add shrinker_info_protected() helper

2021-02-09 Thread Yang Shi
The shrinker_info is dereferenced in a couple of places via rcu_dereference_protected with different calling conventions, for example, using mem_cgroup_nodeinfo helper or dereferencing memcg->nodeinfo[nid]->shrinker_info. And the later patch will add more dereference places. So extract the