Re: [v7 PATCH 07/12] mm: vmscan: use a new flag to indicate shrinker is registered

2021-02-10 Thread Yang Shi
On Tue, Feb 9, 2021 at 4:39 PM Roman Gushchin wrote: > > On Tue, Feb 09, 2021 at 09:46:41AM -0800, Yang Shi wrote: > > Currently registered shrinker is indicated by non-NULL > > shrinker->nr_deferred. > > This approach is fine with nr_deferred at the shrinker level, but the > > following > >

Re: [v7 PATCH 07/12] mm: vmscan: use a new flag to indicate shrinker is registered

2021-02-10 Thread Vlastimil Babka
On 2/9/21 6:46 PM, Yang Shi wrote: > Currently registered shrinker is indicated by non-NULL shrinker->nr_deferred. > This approach is fine with nr_deferred at the shrinker level, but the > following > patches will move MEMCG_AWARE shrinkers' nr_deferred to memcg level, so their >

Re: [v7 PATCH 07/12] mm: vmscan: use a new flag to indicate shrinker is registered

2021-02-09 Thread Yang Shi
On Tue, Feb 9, 2021 at 5:34 PM Roman Gushchin wrote: > > On Tue, Feb 09, 2021 at 05:12:51PM -0800, Yang Shi wrote: > > On Tue, Feb 9, 2021 at 4:39 PM Roman Gushchin wrote: > > > > > > On Tue, Feb 09, 2021 at 09:46:41AM -0800, Yang Shi wrote: > > > > Currently registered shrinker is indicated by

Re: [v7 PATCH 07/12] mm: vmscan: use a new flag to indicate shrinker is registered

2021-02-09 Thread Roman Gushchin
On Tue, Feb 09, 2021 at 05:12:51PM -0800, Yang Shi wrote: > On Tue, Feb 9, 2021 at 4:39 PM Roman Gushchin wrote: > > > > On Tue, Feb 09, 2021 at 09:46:41AM -0800, Yang Shi wrote: > > > Currently registered shrinker is indicated by non-NULL > > > shrinker->nr_deferred. > > > This approach is fine

Re: [v7 PATCH 07/12] mm: vmscan: use a new flag to indicate shrinker is registered

2021-02-09 Thread Yang Shi
On Tue, Feb 9, 2021 at 4:39 PM Roman Gushchin wrote: > > On Tue, Feb 09, 2021 at 09:46:41AM -0800, Yang Shi wrote: > > Currently registered shrinker is indicated by non-NULL > > shrinker->nr_deferred. > > This approach is fine with nr_deferred at the shrinker level, but the > > following > >

Re: [v7 PATCH 07/12] mm: vmscan: use a new flag to indicate shrinker is registered

2021-02-09 Thread Roman Gushchin
On Tue, Feb 09, 2021 at 09:46:41AM -0800, Yang Shi wrote: > Currently registered shrinker is indicated by non-NULL shrinker->nr_deferred. > This approach is fine with nr_deferred at the shrinker level, but the > following > patches will move MEMCG_AWARE shrinkers' nr_deferred to memcg level, so

[v7 PATCH 07/12] mm: vmscan: use a new flag to indicate shrinker is registered

2021-02-09 Thread Yang Shi
Currently registered shrinker is indicated by non-NULL shrinker->nr_deferred. This approach is fine with nr_deferred at the shrinker level, but the following patches will move MEMCG_AWARE shrinkers' nr_deferred to memcg level, so their shrinker->nr_deferred would always be NULL. This would