Re: [v7 PATCH 1/2] mm: vmscan: remove double slab pressure by inc'ing sc->nr_scanned

2019-06-11 Thread Yang Shi
On 6/11/19 10:12 AM, Yang Shi wrote: On 6/10/19 2:36 PM, Oscar Salvador wrote: On Tue, 2019-05-28 at 14:44 +0800, Yang Shi wrote: The commit 9092c71bb724 ("mm: use sc->priority for slab shrink targets") has broken up the relationship between sc->nr_scanned and slab pressure. The sc->nr_sca

Re: [v7 PATCH 1/2] mm: vmscan: remove double slab pressure by inc'ing sc->nr_scanned

2019-06-11 Thread Yang Shi
On 6/10/19 2:36 PM, Oscar Salvador wrote: On Tue, 2019-05-28 at 14:44 +0800, Yang Shi wrote: The commit 9092c71bb724 ("mm: use sc->priority for slab shrink targets") has broken up the relationship between sc->nr_scanned and slab pressure. The sc->nr_scanned can't double slab pressure anymore.

Re: [v7 PATCH 1/2] mm: vmscan: remove double slab pressure by inc'ing sc->nr_scanned

2019-06-10 Thread Oscar Salvador
On Tue, 2019-05-28 at 14:44 +0800, Yang Shi wrote: > The commit 9092c71bb724 ("mm: use sc->priority for slab shrink > targets") > has broken up the relationship between sc->nr_scanned and slab > pressure. > The sc->nr_scanned can't double slab pressure anymore. So, it sounds > no > sense to still

[v7 PATCH 1/2] mm: vmscan: remove double slab pressure by inc'ing sc->nr_scanned

2019-05-27 Thread Yang Shi
The commit 9092c71bb724 ("mm: use sc->priority for slab shrink targets") has broken up the relationship between sc->nr_scanned and slab pressure. The sc->nr_scanned can't double slab pressure anymore. So, it sounds no sense to still keep sc->nr_scanned inc'ed. Actually, it would prevent from addi