Re: [v8,3/7] PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192

2021-03-29 Thread Pali Rohár
On Thursday 18 March 2021 13:48:07 Jianjun Wang wrote: > On Thu, 2021-03-18 at 01:02 +0100, Pali Rohár wrote: > > On Saturday 13 March 2021 15:43:14 Jianjun Wang wrote: > > > On Thu, 2021-03-11 at 13:38 +0100, Pali Rohár wrote: > > > > On Wednesday 24 February 2021 14:11:28 Jianjun Wang wrote: > >

Re: [v8,3/7] PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192

2021-03-23 Thread Pali Rohár
On Tuesday 23 March 2021 09:31:34 Jianjun Wang wrote: > One more question, is there any chance that we can put this linkup flow > to a more "standard" way, such as drivers provides the ops of the PERST# > pin and let the framework to decide how to start a link training, or we > just use macro to

Re: [v8,3/7] PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192

2021-03-22 Thread Jianjun Wang
On Fri, 2021-03-19 at 19:53 +0100, Pali Rohár wrote: > On Thursday 18 March 2021 13:48:07 Jianjun Wang wrote: > > On Thu, 2021-03-18 at 01:02 +0100, Pali Rohár wrote: > > > On Saturday 13 March 2021 15:43:14 Jianjun Wang wrote: > > > > On Thu, 2021-03-11 at 13:38 +0100, Pali Rohár wrote: > > > > >

Re: [v8,3/7] PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192

2021-03-19 Thread Pali Rohár
On Thursday 18 March 2021 13:48:07 Jianjun Wang wrote: > On Thu, 2021-03-18 at 01:02 +0100, Pali Rohár wrote: > > On Saturday 13 March 2021 15:43:14 Jianjun Wang wrote: > > > On Thu, 2021-03-11 at 13:38 +0100, Pali Rohár wrote: > > > > On Wednesday 24 February 2021 14:11:28 Jianjun Wang wrote: > >

Re: [v8,3/7] PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192

2021-03-17 Thread Jianjun Wang
On Thu, 2021-03-18 at 01:02 +0100, Pali Rohár wrote: > On Saturday 13 March 2021 15:43:14 Jianjun Wang wrote: > > On Thu, 2021-03-11 at 13:38 +0100, Pali Rohár wrote: > > > On Wednesday 24 February 2021 14:11:28 Jianjun Wang wrote: > > > > +static int mtk_pcie_startup_port(struct mtk_pcie_port

Re: [v8,3/7] PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192

2021-03-17 Thread Pali Rohár
On Saturday 13 March 2021 15:43:14 Jianjun Wang wrote: > On Thu, 2021-03-11 at 13:38 +0100, Pali Rohár wrote: > > On Wednesday 24 February 2021 14:11:28 Jianjun Wang wrote: > > > +static int mtk_pcie_startup_port(struct mtk_pcie_port *port) > > > +{ > > ... > > > + > > > + /* Delay 100ms to wait

Re: [v8,3/7] PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192

2021-03-12 Thread Jianjun Wang
On Thu, 2021-03-11 at 13:38 +0100, Pali Rohár wrote: > On Wednesday 24 February 2021 14:11:28 Jianjun Wang wrote: > > +static int mtk_pcie_startup_port(struct mtk_pcie_port *port) > > +{ > ... > > + > > + /* Delay 100ms to wait the reference clocks become stable */ > > + msleep(100); > > + > >

Re: [v8,3/7] PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192

2021-03-11 Thread Pali Rohár
On Wednesday 24 February 2021 14:11:28 Jianjun Wang wrote: > +static int mtk_pcie_startup_port(struct mtk_pcie_port *port) > +{ ... > + > + /* Delay 100ms to wait the reference clocks become stable */ > + msleep(100); > + > + /* De-assert PERST# signal */ > + val &= ~PCIE_PE_RSTB;

Re: [v8,3/7] PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192

2021-02-24 Thread Jianjun Wang
Hi Krzysztof, Thanks for your review, I will fix these at next version. Thanks. On Wed, 2021-02-24 at 14:36 +0100, Krzysztof Wilczyński wrote: > Hi Jianjun, > > Thank you for all the work here! > > [...] > > + * struct mtk_pcie_port - PCIe port information > > + * @dev: pointer to PCIe device

Re: [v8,3/7] PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192

2021-02-24 Thread Krzysztof Wilczyński
Hi Jianjun, Thank you for all the work here! [...] > + * struct mtk_pcie_port - PCIe port information > + * @dev: pointer to PCIe device > + * @base: IO mapped register base > + * @reg_base: Physical register base > + * @mac_reset: mac reset control > + * @phy_reset: phy reset control > + *

[v8,3/7] PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192

2021-02-23 Thread Jianjun Wang
MediaTek's PCIe host controller has three generation HWs, the new generation HW is an individual bridge, it supports Gen3 speed and compatible with Gen2, Gen1 speed. Add support for new Gen3 controller which can be found on MT8192. Signed-off-by: Jianjun Wang Acked-by: Ryder Lee ---