On Mon, Nov 26, 2007 at 11:50:10PM -0500, Konrad Rzeszutek wrote:
> > >
> > > sysfs files have ONE VALUE PER FILE, not a whole bunch of different
> > > things in a single file. Please fix this.
> >
> > The subparameters _are_ actually part of a single value, that value being
> > associated with
On Mon, Nov 26, 2007 at 11:23:31PM -0500, Konrad Rzeszutek wrote:
> On Monday 26 November 2007 22:31:38 Greg KH wrote:
> > > +#if defined(CONFIG_ISCSI_IBFT) || defined(CONFIG_ISCSI_IBFT_MODULE)
> ..snip..
> > > +static ssize_t find_ibft(void)
> > > +{
> ..snip..
> > > +}
> >
> > What is a function
On Mon, 26 Nov 2007 19:31:38 PST, Greg KH wrote:
> On Mon, Nov 26, 2007 at 06:56:42PM -0400, Konrad Rzeszutek wrote:
> > +/*
> > + * Routines for reading of the iBFT data in a human readable fashion.
> > + */
> > +ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
> > +
> >
> > sysfs files have ONE VALUE PER FILE, not a whole bunch of different
> > things in a single file. Please fix this.
>
> The subparameters _are_ actually part of a single value, that value being
> associated with the initiator instance.
>
> Konrad is trying to implement a "work-alike" for
.. snip..
> > +#else
> > +static void __init reserve_ibft_region(void) { };
>
> No ending ; above.
Fixed.
>
..snip..
> > +static void __init reserve_ibft_region(void) { };
>
> Ditto.
Fixed.
.. snip..
> > +#include
> > +
>
> No blank line here, please.
Why that creeps back in the code I am
On Monday 26 November 2007 22:31:38 Greg KH wrote:
> On Mon, Nov 26, 2007 at 06:56:42PM -0400, Konrad Rzeszutek wrote:
> > +/*
> > + * Routines for reading of the iBFT data in a human readable fashion.
> > + */
> > +ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
> > +
On Mon, Nov 26, 2007 at 06:56:42PM -0400, Konrad Rzeszutek wrote:
> +/*
> + * Routines for reading of the iBFT data in a human readable fashion.
> + */
> +ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
> + struct ibft_attribute *attr,
> +
On Mon, Nov 26, 2007 at 06:56:42PM -0400, Konrad Rzeszutek wrote:
>
> This patch adds /sysfs/firmware/ibft/[chosen|aliases|[EMAIL
> PROTECTED],X|[EMAIL PROTECTED],X]
> directories along with text properties which export the the iSCSI Boot
> Firmware Table (iBFT) structure. The layout of the
Konrad Rzeszutek wrote:
This patch adds /sysfs/firmware/ibft/[chosen|aliases|[EMAIL PROTECTED],X|[EMAIL
PROTECTED],X]
directories along with text properties which export the the iSCSI Boot
Firmware Table (iBFT) structure. The layout of the directories mirrors
how PowerPC OpenBoot exports this
This patch adds /sysfs/firmware/ibft/[chosen|aliases|[EMAIL PROTECTED],X|[EMAIL
PROTECTED],X]
directories along with text properties which export the the iSCSI Boot
Firmware Table (iBFT) structure. The layout of the directories mirrors
how PowerPC OpenBoot exports this data.
What is iSCSI Boot
This patch adds /sysfs/firmware/ibft/[chosen|aliases|[EMAIL PROTECTED],X|[EMAIL
PROTECTED],X]
directories along with text properties which export the the iSCSI Boot
Firmware Table (iBFT) structure. The layout of the directories mirrors
how PowerPC OpenBoot exports this data.
What is iSCSI Boot
Konrad Rzeszutek wrote:
This patch adds /sysfs/firmware/ibft/[chosen|aliases|[EMAIL PROTECTED],X|[EMAIL
PROTECTED],X]
directories along with text properties which export the the iSCSI Boot
Firmware Table (iBFT) structure. The layout of the directories mirrors
how PowerPC OpenBoot exports this
On Mon, Nov 26, 2007 at 06:56:42PM -0400, Konrad Rzeszutek wrote:
This patch adds /sysfs/firmware/ibft/[chosen|aliases|[EMAIL
PROTECTED],X|[EMAIL PROTECTED],X]
directories along with text properties which export the the iSCSI Boot
Firmware Table (iBFT) structure. The layout of the
On Mon, Nov 26, 2007 at 06:56:42PM -0400, Konrad Rzeszutek wrote:
+/*
+ * Routines for reading of the iBFT data in a human readable fashion.
+ */
+ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
+ struct ibft_attribute *attr,
+
On Monday 26 November 2007 22:31:38 Greg KH wrote:
On Mon, Nov 26, 2007 at 06:56:42PM -0400, Konrad Rzeszutek wrote:
+/*
+ * Routines for reading of the iBFT data in a human readable fashion.
+ */
+ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
+
.. snip..
+#else
+static void __init reserve_ibft_region(void) { };
No ending ; above.
Fixed.
..snip..
+static void __init reserve_ibft_region(void) { };
Ditto.
Fixed.
.. snip..
+#include linux/blkdev.h
+
No blank line here, please.
Why that creeps back in the code I am not
sysfs files have ONE VALUE PER FILE, not a whole bunch of different
things in a single file. Please fix this.
The subparameters _are_ actually part of a single value, that value being
associated with the initiator instance.
Konrad is trying to implement a work-alike for what open
On Mon, 26 Nov 2007 19:31:38 PST, Greg KH wrote:
On Mon, Nov 26, 2007 at 06:56:42PM -0400, Konrad Rzeszutek wrote:
+/*
+ * Routines for reading of the iBFT data in a human readable fashion.
+ */
+ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
+
On Mon, Nov 26, 2007 at 11:50:10PM -0500, Konrad Rzeszutek wrote:
sysfs files have ONE VALUE PER FILE, not a whole bunch of different
things in a single file. Please fix this.
The subparameters _are_ actually part of a single value, that value being
associated with the initiator
On Mon, Nov 26, 2007 at 11:23:31PM -0500, Konrad Rzeszutek wrote:
On Monday 26 November 2007 22:31:38 Greg KH wrote:
+#if defined(CONFIG_ISCSI_IBFT) || defined(CONFIG_ISCSI_IBFT_MODULE)
..snip..
+static ssize_t find_ibft(void)
+{
..snip..
+}
What is a function (not even an
On Thursday 27 September 2007 13:51, Peter Jones wrote:
> H. Peter Anvin wrote:
> > Peter Jones wrote:
> >>> It should, presumably, depend on ACPI, rather than on X86...?
> >> Actually no. That /should/ be the correct answer, but none of the
> >> hardware vendors actually provide the table via
H. Peter Anvin wrote:
Peter Jones wrote:
It should, presumably, depend on ACPI, rather than on X86...?
Actually no. That /should/ be the correct answer, but none of the
hardware vendors actually provide the table via ACPI yet. Also, if they
did, the support for /sys/firmware/acpi/tables/*
Peter Jones wrote:
>>
>> It should, presumably, depend on ACPI, rather than on X86...?
>
> Actually no. That /should/ be the correct answer, but none of the
> hardware vendors actually provide the table via ACPI yet. Also, if they
> did, the support for /sys/firmware/acpi/tables/* would be
H. Peter Anvin wrote:
Konrad Rzeszutek wrote:
+config ISCSI_IBFT
+ tristate "iSCSI Boot Firmware Table Attributes"
+ depends on X86
why only on X86?
PowerPC exports this data via the OpenFirmware so it already shows in
the /sysfs entries. I was thinking to combine those sysfs
Konrad Rzeszutek wrote:
>>> +config ISCSI_IBFT
>>> + tristate "iSCSI Boot Firmware Table Attributes"
>>> + depends on X86
>> why only on X86?
>
> PowerPC exports this data via the OpenFirmware so it already shows in
> the /sysfs entries. I was thinking to combine those sysfs entries under
Konrad Rzeszutek wrote:
+config ISCSI_IBFT
+ tristate iSCSI Boot Firmware Table Attributes
+ depends on X86
why only on X86?
PowerPC exports this data via the OpenFirmware so it already shows in
the /sysfs entries. I was thinking to combine those sysfs entries under this
code, but
H. Peter Anvin wrote:
Konrad Rzeszutek wrote:
+config ISCSI_IBFT
+ tristate iSCSI Boot Firmware Table Attributes
+ depends on X86
why only on X86?
PowerPC exports this data via the OpenFirmware so it already shows in
the /sysfs entries. I was thinking to combine those sysfs
Peter Jones wrote:
It should, presumably, depend on ACPI, rather than on X86...?
Actually no. That /should/ be the correct answer, but none of the
hardware vendors actually provide the table via ACPI yet. Also, if they
did, the support for /sys/firmware/acpi/tables/* would be sufficient
H. Peter Anvin wrote:
Peter Jones wrote:
It should, presumably, depend on ACPI, rather than on X86...?
Actually no. That /should/ be the correct answer, but none of the
hardware vendors actually provide the table via ACPI yet. Also, if they
did, the support for /sys/firmware/acpi/tables/*
On Thursday 27 September 2007 13:51, Peter Jones wrote:
H. Peter Anvin wrote:
Peter Jones wrote:
It should, presumably, depend on ACPI, rather than on X86...?
Actually no. That /should/ be the correct answer, but none of the
hardware vendors actually provide the table via ACPI yet.
On Wed, 26 Sep 2007 20:52:43 -0400 Konrad Rzeszutek wrote:
> > > +config ISCSI_IBFT
> > > + tristate "iSCSI Boot Firmware Table Attributes"
> > > + depends on X86
> >
> > why only on X86?
>
> PowerPC exports this data via the OpenFirmware so it already shows in
> the /sysfs entries. I was
Ram Dorai wrote:
Fixed.
> > +static int
> > +ibft_mmap_binary(struct kobject *kobj, struct bin_attribute
*attr,
> > +struct vm_area_struct *vma)
>
Do we not put a space between binary and '('. Is that against the coding
guidelines?
Right, we do not
On Wed, Sep 26, 2007 at 08:08:45PM -0400, Konrad Rzeszutek wrote:
> On Wednesday 26 September 2007 17:10:57 Greg KH wrote:
> > On Wed, Sep 26, 2007 at 02:46:52PM -0400, Konrad Rzeszutek wrote:
> > > This patch adds a /sysfs/firmware/ibft/table binary blob which exports
> > > the iSCSI Boot
> > +config ISCSI_IBFT
> > + tristate "iSCSI Boot Firmware Table Attributes"
> > + depends on X86
>
> why only on X86?
PowerPC exports this data via the OpenFirmware so it already shows in
the /sysfs entries. I was thinking to combine those sysfs entries under this
code, but that is
On Wednesday 26 September 2007 17:10:57 Greg KH wrote:
> On Wed, Sep 26, 2007 at 02:46:52PM -0400, Konrad Rzeszutek wrote:
> > This patch adds a /sysfs/firmware/ibft/table binary blob which exports
> > the iSCSI Boot Firmware Table (iBFT) structure.
>
> Please don't do that. Binary files are for
>
> i.e., what is this binary blob (?)
>
> I don't see a binary blob in this patch (as stated in the first
> sentence). I'd say that this patch adds methods for exporting
> (or exposing) the ibft thru sysfs.
I used the wrong choice of words. The correct one is, as you say, to
add methods for
On Wed, 26 Sep 2007 14:46:52 -0400 Konrad Rzeszutek wrote:
> This patch adds a /sysfs/firmware/ibft/table binary blob which exports
> the iSCSI Boot Firmware Table (iBFT) structure.
>
> What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
> tools to extract from the machine NICs
On Wed, 26 Sep 2007 14:46:52 -0400 Konrad Rzeszutek wrote:
> This patch adds a /sysfs/firmware/ibft/table binary blob which exports
> the iSCSI Boot Firmware Table (iBFT) structure.
>
> What is iSCSI Boot Firmware Table?
i.e., what is this binary blob (?)
I don't see a binary blob in this
On Wed, Sep 26, 2007 at 02:46:52PM -0400, Konrad Rzeszutek wrote:
> This patch adds a /sysfs/firmware/ibft/table binary blob which exports
> the iSCSI Boot Firmware Table (iBFT) structure.
Please don't do that. Binary files are for things that are
"pass-through" only, not anything that the
Konrad Rzeszutek wrote:
[...]
> +static ssize_t
> +ibft_read_binary(struct kobject *kobj, struct bin_attribute *attr, char *buf,
> + loff_t off, size_t count)
> +{
> +
> + struct ibft_device *ibft = container_of(kobj, struct ibft_device, kobj);
> + ssize_t len =
This patch adds a /sysfs/firmware/ibft/table binary blob which exports
the iSCSI Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine NICs the iSCSI connection information
so that they can automagically mount
This patch adds a /sysfs/firmware/ibft/table binary blob which exports
the iSCSI Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine NICs the iSCSI connection information
so that they can automagically mount
Konrad Rzeszutek wrote:
[...]
+static ssize_t
+ibft_read_binary(struct kobject *kobj, struct bin_attribute *attr, char *buf,
+ loff_t off, size_t count)
+{
+
+ struct ibft_device *ibft = container_of(kobj, struct ibft_device, kobj);
+ ssize_t len = ibft-hdr-length;
+
On Wed, Sep 26, 2007 at 02:46:52PM -0400, Konrad Rzeszutek wrote:
This patch adds a /sysfs/firmware/ibft/table binary blob which exports
the iSCSI Boot Firmware Table (iBFT) structure.
Please don't do that. Binary files are for things that are
pass-through only, not anything that the kernel
On Wed, 26 Sep 2007 14:46:52 -0400 Konrad Rzeszutek wrote:
This patch adds a /sysfs/firmware/ibft/table binary blob which exports
the iSCSI Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table?
i.e., what is this binary blob (?)
I don't see a binary blob in this patch
On Wed, 26 Sep 2007 14:46:52 -0400 Konrad Rzeszutek wrote:
This patch adds a /sysfs/firmware/ibft/table binary blob which exports
the iSCSI Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine NICs the
i.e., what is this binary blob (?)
I don't see a binary blob in this patch (as stated in the first
sentence). I'd say that this patch adds methods for exporting
(or exposing) the ibft thru sysfs.
I used the wrong choice of words. The correct one is, as you say, to
add methods for
On Wednesday 26 September 2007 17:10:57 Greg KH wrote:
On Wed, Sep 26, 2007 at 02:46:52PM -0400, Konrad Rzeszutek wrote:
This patch adds a /sysfs/firmware/ibft/table binary blob which exports
the iSCSI Boot Firmware Table (iBFT) structure.
Please don't do that. Binary files are for things
+config ISCSI_IBFT
+ tristate iSCSI Boot Firmware Table Attributes
+ depends on X86
why only on X86?
PowerPC exports this data via the OpenFirmware so it already shows in
the /sysfs entries. I was thinking to combine those sysfs entries under this
code, but that is something in the
On Wed, Sep 26, 2007 at 08:08:45PM -0400, Konrad Rzeszutek wrote:
On Wednesday 26 September 2007 17:10:57 Greg KH wrote:
On Wed, Sep 26, 2007 at 02:46:52PM -0400, Konrad Rzeszutek wrote:
This patch adds a /sysfs/firmware/ibft/table binary blob which exports
the iSCSI Boot Firmware Table
Ram Dorai wrote:
Fixed.
+static int
+ibft_mmap_binary(struct kobject *kobj, struct bin_attribute
*attr,
+struct vm_area_struct *vma)
Do we not put a space between binary and '('. Is that against the coding
guidelines?
Right, we do not put a
On Wed, 26 Sep 2007 20:52:43 -0400 Konrad Rzeszutek wrote:
+config ISCSI_IBFT
+ tristate iSCSI Boot Firmware Table Attributes
+ depends on X86
why only on X86?
PowerPC exports this data via the OpenFirmware so it already shows in
the /sysfs entries. I was thinking to combine
101 - 152 of 152 matches
Mail list logo
