答复: 答复: 答复: [PATCH V2] vfio dma_map/unmap: optimized for hugetlbfs pages

2020-09-01 Thread Maoming (maoming, Cloud Infrastructure Service Product Dept.)
> > On 2020/8/28 下午10:24, Peter Xu wrote: > > On Fri, Aug 28, 2020 at 09:23:08AM +, Maoming (maoming, Cloud > Infrastructure Service Product Dept.) wrote: > >> In hugetlb_put_pfn(), I delete unpin_user_pages_dirty_lock() and use some > simple code to put hugetlb pages. > >> Is this right? > >

Re: 答复: 答复: [PATCH V2] vfio dma_map/unmap: optimized for hugetlbfs pages

2020-08-31 Thread Jason Wang
On 2020/8/28 下午10:24, Peter Xu wrote: On Fri, Aug 28, 2020 at 09:23:08AM +, Maoming (maoming, Cloud Infrastructure Service Product Dept.) wrote: In hugetlb_put_pfn(), I delete unpin_user_pages_dirty_lock() and use some simple code to put hugetlb pages. Is this right? I think we should s

Re: 答复: 答复: [PATCH V2] vfio dma_map/unmap: optimized for hugetlbfs pages

2020-08-28 Thread Peter Xu
On Fri, Aug 28, 2020 at 09:23:08AM +, Maoming (maoming, Cloud Infrastructure Service Product Dept.) wrote: > In hugetlb_put_pfn(), I delete unpin_user_pages_dirty_lock() and use some > simple code to put hugetlb pages. > Is this right? I think we should still use the APIs because of the the

答复: 答复: [PATCH V2] vfio dma_map/unmap: optimized for hugetlbfs pages

2020-08-28 Thread Maoming (maoming, Cloud Infrastructure Service Product Dept.)
On Wed, Aug 26, 2020 at 01:56:43PM +, Maoming (maoming, Cloud Infrastructure Service Product Dept.) wrote: > > + /* > > +* Unlike THP, the splitting should not happen for hugetlb pages. > > +* Since PG_reserved is not relevant for compound pages, and the pfn of > > +* PAGE_SIZE