Re: 0be964be0 "module: Sanitize RCU usage and locking" breaks symbol_put_addr?

2015-08-19 Thread Rusty Russell
Peter Zijlstra writes: > On Wed, Aug 19, 2015 at 06:19:43AM +0930, Rusty Russell wrote: >> Indeed! That comment is wrong, and your fix is good. >> >> Care to S-O-B on it? > > Of course, here goes. Thanks! This is an ancient bug (2009) which your extra assertions caught. It's unlikely to have

Re: 0be964be0 "module: Sanitize RCU usage and locking" breaks symbol_put_addr?

2015-08-19 Thread Peter Zijlstra
On Wed, Aug 19, 2015 at 06:19:43AM +0930, Rusty Russell wrote: > Indeed! That comment is wrong, and your fix is good. > > Care to S-O-B on it? Of course, here goes. --- Subject: module: Fix locking in symbol_put_addr() Laura reported an assertion triggering: [] module_assert_mutex_or_preem

Re: 0be964be0 "module: Sanitize RCU usage and locking" breaks symbol_put_addr?

2015-08-18 Thread Rusty Russell
Peter Zijlstra writes: > On Mon, Aug 17, 2015 at 04:20:09PM -0700, Laura Abbott wrote: >> Hi, >> >> We received a few bug backtraces: >> >> [ 41.536933] [ cut here ] >> [ 41.537545] WARNING: CPU: 1 PID: 813 at kernel/module.c:291 >> module_assert_mutex_or_preempt+0x4

Re: 0be964be0 "module: Sanitize RCU usage and locking" breaks symbol_put_addr?

2015-08-17 Thread Peter Zijlstra
On Mon, Aug 17, 2015 at 04:20:09PM -0700, Laura Abbott wrote: > Hi, > > We received a few bug backtraces: > > [ 41.536933] [ cut here ] > [ 41.537545] WARNING: CPU: 1 PID: 813 at kernel/module.c:291 > module_assert_mutex_or_preempt+0x49/0x90() > [ 41.538174] Modules

0be964be0 "module: Sanitize RCU usage and locking" breaks symbol_put_addr?

2015-08-17 Thread Laura Abbott
Hi, We received a few bug backtraces: [ 41.536933] [ cut here ] [ 41.537545] WARNING: CPU: 1 PID: 813 at kernel/module.c:291 module_assert_mutex_or_preempt+0x49/0x90() [ 41.538174] Modules linked in: mxl5007t af9013 ... dvb_usb_af9015(+) ... dvb_usb_v2 dvb_core rc