Re: 1/7 create kstrdup library function

2005-02-02 Thread Pekka J Enberg
Paulo Marques writes: I agree with the "is like kcalloc" argument in the sense that it does an allocation + something else. But in this case the "something else" is in fact a string operation, so this just seem to be in the middle. Sure, but now you're forcing all users of to depend on the slab

Re: [PATCH 2.6] 1/7 create kstrdup library function

2005-02-02 Thread Paulo Marques
Pekka Enberg wrote: At some point in time, I wrote: kstrdup() is a special-case _memory allocator_ (not so much a string operation) so I think it should go into mm/slab.c where we currently have kcalloc(). On Tue, 01 Feb 2005 17:00:17 +, Paulo Marques <[EMAIL PROTECTED]> wrote: I was

Re: [PATCH 2.6] 1/7 create kstrdup library function

2005-02-02 Thread Paulo Marques
Pekka Enberg wrote: At some point in time, I wrote: kstrdup() is a special-case _memory allocator_ (not so much a string operation) so I think it should go into mm/slab.c where we currently have kcalloc(). On Tue, 01 Feb 2005 17:00:17 +, Paulo Marques [EMAIL PROTECTED] wrote: I was following

Re: 1/7 create kstrdup library function

2005-02-02 Thread Pekka J Enberg
Paulo Marques writes: I agree with the is like kcalloc argument in the sense that it does an allocation + something else. But in this case the something else is in fact a string operation, so this just seem to be in the middle. Sure, but now you're forcing all users of string.h to depend on the

Re: [PATCH 2.6] 1/7 create kstrdup library function

2005-02-01 Thread Pekka Enberg
At some point in time, I wrote: > > kstrdup() is a special-case _memory allocator_ (not so much a string > > operation) so I think it should go into mm/slab.c where we currently > > have kcalloc(). On Tue, 01 Feb 2005 17:00:17 +, Paulo Marques <[EMAIL PROTECTED]> wrote: > I was following

Re: [PATCH 2.6] 1/7 create kstrdup library function

2005-02-01 Thread Paulo Marques
Pekka Enberg wrote: [...] kstrdup() is a special-case _memory allocator_ (not so much a string operation) so I think it should go into mm/slab.c where we currently have kcalloc(). I was following Rusty Russell's approach. Also, I believe this is more intuitive because the standard libc strdup

Re: [PATCH 2.6] 1/7 create kstrdup library function

2005-02-01 Thread Pekka Enberg
Hi, On Tue, 1 Feb 2005 03:28:21 +, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > This patch creates the kstrdup library function so that it doesn't have to be > reimplemented (or even EXPORT'ed) by every user that needs it. > > Signed-off-by: Paulo Marques <[EMAIL PROTECTED]> > > diff

Re: [PATCH 2.6] 1/7 create kstrdup library function

2005-02-01 Thread Pekka Enberg
Hi, On Tue, 1 Feb 2005 03:28:21 +, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: This patch creates the kstrdup library function so that it doesn't have to be reimplemented (or even EXPORT'ed) by every user that needs it. Signed-off-by: Paulo Marques [EMAIL PROTECTED] diff -buprN -X

Re: [PATCH 2.6] 1/7 create kstrdup library function

2005-02-01 Thread Paulo Marques
Pekka Enberg wrote: [...] kstrdup() is a special-case _memory allocator_ (not so much a string operation) so I think it should go into mm/slab.c where we currently have kcalloc(). I was following Rusty Russell's approach. Also, I believe this is more intuitive because the standard libc strdup

Re: [PATCH 2.6] 1/7 create kstrdup library function

2005-02-01 Thread Pekka Enberg
At some point in time, I wrote: kstrdup() is a special-case _memory allocator_ (not so much a string operation) so I think it should go into mm/slab.c where we currently have kcalloc(). On Tue, 01 Feb 2005 17:00:17 +, Paulo Marques [EMAIL PROTECTED] wrote: I was following Rusty

[PATCH 2.6] 1/7 create kstrdup library function

2005-01-31 Thread
This patch creates the kstrdup library function so that it doesn't have to be reimplemented (or even EXPORT'ed) by every user that needs it. Signed-off-by: Paulo Marques <[EMAIL PROTECTED]> -- Paulo Marques - www.grupopie.com All that is necessary for the triumph of evil is that good men do

[PATCH 2.6] 1/7 create kstrdup library function

2005-01-31 Thread
This patch creates the kstrdup library function so that it doesn't have to be reimplemented (or even EXPORT'ed) by every user that needs it. Signed-off-by: Paulo Marques [EMAIL PROTECTED] -- Paulo Marques - www.grupopie.com All that is necessary for the triumph of evil is that good men do