Re: 2.4.0-test10-pre6: Use of abs()

2000-11-02 Thread Richard Henderson
On Thu, Nov 02, 2000 at 01:14:49PM +0100, Martin Dalecki wrote: > However what's the difference in respect of optimization between > unrolling the abs function by hand and relying on the built in? Should be nothing. The expanded source expression should get folded immediately to an ABS_EXPR node

Re: 2.4.0-test10-pre6: Use of abs()

2000-11-02 Thread Martin Dalecki
Richard Henderson wrote: > > On Wed, Nov 01, 2000 at 09:46:19AM -0500, [EMAIL PROTECTED] wrote: > > What versions of gcc produce the built-in functions? > > 2.95 and previous. In 2.96 somewhere we fixed a bug that > automatically prototypes these builtin functions for you; > ie with current cod

Re: 2.4.0-test10-pre6: Use of abs()

2000-11-01 Thread Theodore Y. Ts'o
Date: Wed, 1 Nov 2000 09:46:19 -0500 From: [EMAIL PROTECTED] On Mon, Oct 30, 2000 at 05:14:34PM +0100, Martin Dalecki wrote: > Of corse right! BTW. There are tons of places where log2 is calculated > explicitly in kernel which should be replaced with the corresponding > built

Re: 2.4.0-test10-pre6: Use of abs()

2000-11-01 Thread Richard Henderson
On Wed, Nov 01, 2000 at 09:46:19AM -0500, [EMAIL PROTECTED] wrote: > What versions of gcc produce the built-in functions? 2.95 and previous. In 2.96 somewhere we fixed a bug that automatically prototypes these builtin functions for you; ie with current code you get an undeclared function warning

Re: 2.4.0-test10-pre6: Use of abs()

2000-11-01 Thread tytso
On Mon, Oct 30, 2000 at 05:14:34PM +0100, Martin Dalecki wrote: > Of corse right! BTW. There are tons of places where log2 is calculated > explicitly in kernel which should be replaced with the corresponding > built > in functions as well (/dev/random code does it). And then If I remember > corre

Re: 2.4.0-test10-pre6: Use of abs()

2000-10-30 Thread Martin Dalecki
Jakub Jelinek wrote: > > On Mon, Oct 30, 2000 at 03:01:16PM +0100, Martin Dalecki wrote: > > Horst von Brand wrote: > > > > > > Red Hat 7.0, i686, gcc-20001027 (Yes, I know. Just to flush out bugs on > > > both sides). > > > > > > abs() is used at least in: > > > > > > arch/i386/kernel/time.c > >

Re: 2.4.0-test10-pre6: Use of abs()

2000-10-30 Thread Jakub Jelinek
On Mon, Oct 30, 2000 at 03:01:16PM +0100, Martin Dalecki wrote: > Horst von Brand wrote: > > > > Red Hat 7.0, i686, gcc-20001027 (Yes, I know. Just to flush out bugs on > > both sides). > > > > abs() is used at least in: > > > > arch/i386/kernel/time.c > > drivers/md/raid1.c > > drivers/sound/s

Re: 2.4.0-test10-pre6: Use of abs()

2000-10-30 Thread Martin Dalecki
Horst von Brand wrote: > > Red Hat 7.0, i686, gcc-20001027 (Yes, I know. Just to flush out bugs on > both sides). > > abs() is used at least in: > > arch/i386/kernel/time.c > drivers/md/raid1.c > drivers/sound/sb_ess.c > > gcc warns about use of a non-declared function each time. > > No defin

2.4.0-test10-pre6: Use of abs()

2000-10-28 Thread Horst von Brand
Red Hat 7.0, i686, gcc-20001027 (Yes, I know. Just to flush out bugs on both sides). abs() is used at least in: arch/i386/kernel/time.c drivers/md/raid1.c drivers/sound/sb_ess.c gcc warns about use of a non-declared function each time. No definition for the function is to be found (grep over a