Re: [linux-pm] [RFD] swsusp problem: Drivers allocate much memory during suspend (was: Re: 2.6.21-rc5: swsusp: Not enough free memory)

2007-04-14 Thread Rafael J. Wysocki
Hi, On Saturday, 14 April 2007 00:35, Rafael J. Wysocki wrote: > On Saturday, 14 April 2007 00:10, Pavel Machek wrote: [--snip--] > > > IMO to really fix the problem, we should let the drivers that need much > > > memory > > > for suspending allocate it _before_ the memory shrinker is called. F

Re: [RFD] swsusp problem: Drivers allocate much memory during suspend (was: Re: 2.6.21-rc5: swsusp: Not enough free memory)

2007-04-14 Thread Rafael J. Wysocki
On Saturday, 14 April 2007 01:03, Nigel Cunningham wrote: > Hi. > > On Sat, 2007-04-14 at 00:57 +0200, Rafael J. Wysocki wrote: > > > > > Well, I'm not sure. First, we don't really know what the value of it > > > > > should be > > > > > and this alone is a good enough reason for making it tunabl

Re: [RFD] swsusp problem: Drivers allocate much memory during suspend (was: Re: 2.6.21-rc5: swsusp: Not enough free memory)

2007-04-13 Thread Nigel Cunningham
Hi. On Sat, 2007-04-14 at 00:57 +0200, Rafael J. Wysocki wrote: > > > > Well, I'm not sure. First, we don't really know what the value of it > > > > should be > > > > and this alone is a good enough reason for making it tunable, IMHO. > > > > Second, I > > > > think different systems may need

Re: [RFD] swsusp problem: Drivers allocate much memory during suspend (was: Re: 2.6.21-rc5: swsusp: Not enough free memory)

2007-04-13 Thread Rafael J. Wysocki
On Saturday, 14 April 2007 00:45, Nigel Cunningham wrote: > Hi. > > On Sat, 2007-04-14 at 00:40 +0200, Pavel Machek wrote: > > Hi! > > > > > > > > > Well, it looks like someone allocated about 6000 pages after we > > > > > > > had freed > > > > > > > enough memory for suspending. > > > > > > >

Re: [RFD] swsusp problem: Drivers allocate much memory during suspend (was: Re: 2.6.21-rc5: swsusp: Not enough free memory)

2007-04-13 Thread Nigel Cunningham
Hi. On Sat, 2007-04-14 at 00:40 +0200, Pavel Machek wrote: > Hi! > > > > > > > Well, it looks like someone allocated about 6000 pages after we had > > > > > > freed > > > > > > enough memory for suspending. > > > > > > > > > > We have a tunable allowance in Suspend2 for this, because fglrx > >

Re: [linux-pm] [RFD] swsusp problem: Drivers allocate much memory during suspend (was: Re: 2.6.21-rc5: swsusp: Not enough free memory)

2007-04-13 Thread Nigel Cunningham
Hi. On Sat, 2007-04-14 at 00:38 +0200, Pavel Machek wrote: > Hi! > > > > > > > Well, it looks like someone allocated about 6000 pages after we had > > > > > > freed > > > > > > enough memory for suspending. > > > > > > > > > > We have a tunable allowance in Suspend2 for this, because fglrx > >

Re: [RFD] swsusp problem: Drivers allocate much memory during suspend (was: Re: 2.6.21-rc5: swsusp: Not enough free memory)

2007-04-13 Thread Pavel Machek
Hi! > > > > > Well, it looks like someone allocated about 6000 pages after we had > > > > > freed > > > > > enough memory for suspending. > > > > > > > > We have a tunable allowance in Suspend2 for this, because fglrx > > > > allocates a lot of pages in its suspend routine if DRI is enabled. I >

Re: [linux-pm] [RFD] swsusp problem: Drivers allocate much memory during suspend (was: Re: 2.6.21-rc5: swsusp: Not enough free memory)

2007-04-13 Thread Pavel Machek
Hi! > > > > > Well, it looks like someone allocated about 6000 pages after we had > > > > > freed > > > > > enough memory for suspending. > > > > > > > > We have a tunable allowance in Suspend2 for this, because fglrx > > > > allocates a lot of pages in its suspend routine if DRI is enabled. I >

Re: [RFD] swsusp problem: Drivers allocate much memory during suspend (was: Re: 2.6.21-rc5: swsusp: Not enough free memory)

2007-04-13 Thread Nigel Cunningham
Hi. On Sat, 2007-04-14 at 00:35 +0200, Rafael J. Wysocki wrote: > On Saturday, 14 April 2007 00:10, Pavel Machek wrote: > > Hi! > > > > > > > Well, it looks like someone allocated about 6000 pages after we had > > > > > freed > > > > > enough memory for suspending. > > > > > > > > We have a tun

Re: [RFD] swsusp problem: Drivers allocate much memory during suspend (was: Re: 2.6.21-rc5: swsusp: Not enough free memory)

2007-04-13 Thread Nigel Cunningham
Hi. On Sat, 2007-04-14 at 00:10 +0200, Pavel Machek wrote: > Hi! > > > > > Well, it looks like someone allocated about 6000 pages after we had > > > > freed > > > > enough memory for suspending. > > > > > > We have a tunable allowance in Suspend2 for this, because fglrx > > > allocates a lot of

Re: [RFD] swsusp problem: Drivers allocate much memory during suspend (was: Re: 2.6.21-rc5: swsusp: Not enough free memory)

2007-04-13 Thread Rafael J. Wysocki
On Saturday, 14 April 2007 00:10, Pavel Machek wrote: > Hi! > > > > > Well, it looks like someone allocated about 6000 pages after we had > > > > freed > > > > enough memory for suspending. > > > > > > We have a tunable allowance in Suspend2 for this, because fglrx > > > allocates a lot of pages

Re: [RFD] swsusp problem: Drivers allocate much memory during suspend (was: Re: 2.6.21-rc5: swsusp: Not enough free memory)

2007-04-13 Thread Pavel Machek
Hi! > > > Well, it looks like someone allocated about 6000 pages after we had freed > > > enough memory for suspending. > > > > We have a tunable allowance in Suspend2 for this, because fglrx > > allocates a lot of pages in its suspend routine if DRI is enabled. I > > think some other drivers do

Re: [RFD] swsusp problem: Drivers allocate much memory during suspend (was: Re: 2.6.21-rc5: swsusp: Not enough free memory)

2007-04-13 Thread Nigel Cunningham
Hi. On Fri, 2007-04-13 at 22:41 +0200, Rafael J. Wysocki wrote: > On Friday, 13 April 2007 14:21, Nigel Cunningham wrote: > > Hi. > > > > On Fri, 2007-04-13 at 14:00 +0200, Rafael J. Wysocki wrote: > > > > > > > > Shrinking memory... Pages needed: 128103 normal, 0 highmem > > > > Pages needed:

[RFD] swsusp problem: Drivers allocate much memory during suspend (was: Re: 2.6.21-rc5: swsusp: Not enough free memory)

2007-04-13 Thread Rafael J. Wysocki
On Friday, 13 April 2007 14:21, Nigel Cunningham wrote: > Hi. > > On Fri, 2007-04-13 at 14:00 +0200, Rafael J. Wysocki wrote: > > > > > > Shrinking memory... Pages needed: 128103 normal, 0 highmem > > > Pages needed: 125226 normal, 0 highmem > > > Pages needed: -5757 normal, 0 highmem > > > Page

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-13 Thread Nigel Cunningham
Hi. On Fri, 2007-04-13 at 14:00 +0200, Rafael J. Wysocki wrote: > > > > Shrinking memory... Pages needed: 128103 normal, 0 highmem > > Pages needed: 125226 normal, 0 highmem > > Pages needed: -5757 normal, 0 highmem > > Pages needed: -5757 normal, 0 highmem > > Pages needed: -5757 normal, 0 high

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-13 Thread Rafael J. Wysocki
On Friday, 13 April 2007 12:14, Jiri Slaby wrote: > On 4/12/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > On Wednesday, 11 April 2007 17:02, Jiri Slaby wrote: > > > Rafael J. Wysocki napsal(a): > > > > On Wednesday, 11 April 2007 12:45, Jiri Slaby wrote: > > > >> Rafael J. Wysocki napsal(a):

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-13 Thread Jiri Slaby
On 4/12/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: On Wednesday, 11 April 2007 17:02, Jiri Slaby wrote: > Rafael J. Wysocki napsal(a): > > On Wednesday, 11 April 2007 12:45, Jiri Slaby wrote: > >> Rafael J. Wysocki napsal(a): > >>> On Wednesday, 11 April 2007 09:36, Jiri Slaby wrote: >

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-12 Thread Rafael J. Wysocki
On Wednesday, 11 April 2007 17:02, Jiri Slaby wrote: > Rafael J. Wysocki napsal(a): > > On Wednesday, 11 April 2007 12:45, Jiri Slaby wrote: > >> Rafael J. Wysocki napsal(a): > >>> On Wednesday, 11 April 2007 09:36, Jiri Slaby wrote: > Rafael J. Wysocki napsal(a): > > On Monday, 9 April 20

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-11 Thread Jiri Slaby
Rafael J. Wysocki napsal(a): > On Wednesday, 11 April 2007 12:45, Jiri Slaby wrote: >> Rafael J. Wysocki napsal(a): >>> On Wednesday, 11 April 2007 09:36, Jiri Slaby wrote: Rafael J. Wysocki napsal(a): > On Monday, 9 April 2007 22:07, Jiri Slaby wrote: >> I have bad news for you :(. I

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-11 Thread Rafael J. Wysocki
On Wednesday, 11 April 2007 12:45, Jiri Slaby wrote: > Rafael J. Wysocki napsal(a): > > On Wednesday, 11 April 2007 09:36, Jiri Slaby wrote: > >> Rafael J. Wysocki napsal(a): > >>> On Monday, 9 April 2007 22:07, Jiri Slaby wrote: > I have bad news for you :(. I thought I had unpatched kernel,

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-11 Thread Jiri Slaby
Rafael J. Wysocki napsal(a): > On Wednesday, 11 April 2007 09:36, Jiri Slaby wrote: >> Rafael J. Wysocki napsal(a): >>> On Monday, 9 April 2007 22:07, Jiri Slaby wrote: I have bad news for you :(. I thought I had unpatched kernel, but it happens in -rc6 too. >>> I guess you mean you

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-11 Thread Rafael J. Wysocki
On Wednesday, 11 April 2007 09:36, Jiri Slaby wrote: > Rafael J. Wysocki napsal(a): > > On Monday, 9 April 2007 22:07, Jiri Slaby wrote: > >> Rafael J. Wysocki napsal(a): > >>> Thanks for testing. > >> [...] > >>> --- linux-2.6.21-rc5.orig/kernel/power/swsusp.c > >>> +++ linux-2.6.21-rc5/kernel/pow

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-11 Thread Jiri Slaby
Rafael J. Wysocki napsal(a): > On Monday, 9 April 2007 22:07, Jiri Slaby wrote: >> Rafael J. Wysocki napsal(a): >>> Thanks for testing. >> [...] >>> --- linux-2.6.21-rc5.orig/kernel/power/swsusp.c >>> +++ linux-2.6.21-rc5/kernel/power/swsusp.c >>> @@ -229,13 +229,13 @@ int swsusp_shrink_memory(void

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-09 Thread Rafael J. Wysocki
On Monday, 9 April 2007 22:07, Jiri Slaby wrote: > Rafael J. Wysocki napsal(a): > > Thanks for testing. > [...] > > --- linux-2.6.21-rc5.orig/kernel/power/swsusp.c > > +++ linux-2.6.21-rc5/kernel/power/swsusp.c > > @@ -229,13 +229,13 @@ int swsusp_shrink_memory(void) > > size += highmem

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-09 Thread Jiri Slaby
Rafael J. Wysocki napsal(a): > Thanks for testing. [...] > --- linux-2.6.21-rc5.orig/kernel/power/swsusp.c > +++ linux-2.6.21-rc5/kernel/power/swsusp.c > @@ -229,13 +229,13 @@ int swsusp_shrink_memory(void) > size += highmem_size; > for_each_zone (zone) >

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-03 Thread Jiri Slaby
Rafael J. Wysocki napsal(a): > Okay, so I think the appended patch is needed. Could you please revert the [...] > Index: linux-2.6.21-rc5/kernel/power/swsusp.c > === > --- linux-2.6.21-rc5.orig/kernel/power/swsusp.c > +++ linux-2.6.21

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-03 Thread Rafael J. Wysocki
On Tuesday, 3 April 2007 09:37, Jiri Slaby wrote: > Rafael J. Wysocki napsal(a): > > On Monday, 2 April 2007 10:24, Jiri Slaby wrote: > >> Rafael J. Wysocki napsal(a): > > On Thursday, 29 March 2007 09:44, Jiri Slaby wrote: > >> swsusp: critical section: > >> swsusp: Need to copy 131380

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-03 Thread Jiri Slaby
Rafael J. Wysocki napsal(a): > On Monday, 2 April 2007 10:24, Jiri Slaby wrote: >> Rafael J. Wysocki napsal(a): > On Thursday, 29 March 2007 09:44, Jiri Slaby wrote: >> swsusp: critical section: >> swsusp: Need to copy 131380 pages >> swsusp: Not enough free memory >> Error -12

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-02 Thread Rafael J. Wysocki
On Monday, 2 April 2007 10:24, Jiri Slaby wrote: > Rafael J. Wysocki napsal(a): > >>> On Thursday, 29 March 2007 09:44, Jiri Slaby wrote: > swsusp: critical section: > swsusp: Need to copy 131380 pages > swsusp: Not enough free memory > Error -12 suspending > Enabling non-b

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-02 Thread Jiri Slaby
Rafael J. Wysocki napsal(a): >>> On Thursday, 29 March 2007 09:44, Jiri Slaby wrote: swsusp: critical section: swsusp: Need to copy 131380 pages swsusp: Not enough free memory Error -12 suspending Enabling non-boot CPUs ... > As a workaround, you can try to change the init

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-01 Thread Rafael J. Wysocki
On Sunday, 1 April 2007 20:17, Jiri Slaby wrote: > Rafael J. Wysocki napsal(a): > > On Thursday, 29 March 2007 09:44, Jiri Slaby wrote: > >> Hi, > >> > >> I'm getting this while trying to swsups the machine in -rc5, -rc4 is fine: > >> > >> Disabling non-boot CPUs > >> CPU 1 is now offline > >> SMP

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-04-01 Thread Jiri Slaby
Rafael J. Wysocki napsal(a): > On Thursday, 29 March 2007 09:44, Jiri Slaby wrote: >> Hi, >> >> I'm getting this while trying to swsups the machine in -rc5, -rc4 is fine: >> >> Disabling non-boot CPUs >> CPU 1 is now offline >> SMP alternatives: switching to UP code >> CPU1 is down >> swsusp: criti

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-03-29 Thread Jiri Slaby
Rafael J. Wysocki napsal(a): > On Thursday, 29 March 2007 09:44, Jiri Slaby wrote: >> Hi, >> >> I'm getting this while trying to swsups the machine in -rc5, -rc4 is fine: >> >> Disabling non-boot CPUs >> CPU 1 is now offline >> SMP alternatives: switching to UP code >> CPU1 is down >> swsusp: criti

Re: 2.6.21-rc5: swsusp: Not enough free memory

2007-03-29 Thread Rafael J. Wysocki
On Thursday, 29 March 2007 09:44, Jiri Slaby wrote: > Hi, > > I'm getting this while trying to swsups the machine in -rc5, -rc4 is fine: > > Disabling non-boot CPUs > CPU 1 is now offline > SMP alternatives: switching to UP code > CPU1 is down > swsusp: critical section: > swsusp: Need to copy 13

2.6.21-rc5: swsusp: Not enough free memory

2007-03-28 Thread Jiri Slaby
Hi, I'm getting this while trying to swsups the machine in -rc5, -rc4 is fine: Disabling non-boot CPUs CPU 1 is now offline SMP alternatives: switching to UP code CPU1 is down swsusp: critical section: swsusp: Need to copy 131380 pages swsusp: Not enough free memory Error -12 suspending Enabling