Re: 2.6.21-rc7-mm1: BUG_ON in kthread_bind during _cpu_down

2007-04-27 Thread Andrew Morton
On Thu, 26 Apr 2007 18:28:38 +0530 Gautham R Shenoy <[EMAIL PROTECTED]> wrote: > I just checked with Vatsa if there was any subtle reason why they > had put in the kthread_bind() in cpu.c. Vatsa cannot seem to recollect > any and I can't see any. So let us just remove the kthread_bind. > > Signed

Re: 2.6.21-rc7-mm1: BUG_ON in kthread_bind during _cpu_down

2007-04-26 Thread Rafael J. Wysocki
On Thursday, 26 April 2007 01:54, Andrew Morton wrote: > On Thu, 26 Apr 2007 01:10:21 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> > wrote: > > > Hi, > > > > The BUG_ON in khthread_bind (line 165 in kthread.c) triggers for me during > > attempted suspend to disk, when disable_nonboot_cpus() cal

Re: 2.6.21-rc7-mm1: BUG_ON in kthread_bind during _cpu_down

2007-04-26 Thread Gautham R Shenoy
On Thu, Apr 26, 2007 at 02:15:47PM +0400, Oleg Nesterov wrote: > > I can't understand why do we need to re-bind this thread. We are doing > kthread_stop()->wake_up() below, at this point move_task_off_dead_cpu() > has already cared about this task, no? > > > We only need to ensure in kthread_bind

Re: 2.6.21-rc7-mm1: BUG_ON in kthread_bind during _cpu_down

2007-04-26 Thread Oleg Nesterov
On 04/26, Gautham R Shenoy wrote: > > On Wed, Apr 25, 2007 at 04:54:10PM -0700, Andrew Morton wrote: > > On Thu, 26 Apr 2007 01:10:21 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> > > wrote: > > > > > Hi, > > > > > > The BUG_ON in khthread_bind (line 165 in kthread.c) triggers for me during > >

Re: 2.6.21-rc7-mm1: BUG_ON in kthread_bind during _cpu_down

2007-04-26 Thread Eric W. Biederman
Gautham R Shenoy <[EMAIL PROTECTED]> writes: > On Wed, Apr 25, 2007 at 04:54:10PM -0700, Andrew Morton wrote: >> On Thu, 26 Apr 2007 01:10:21 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> >> wrote: >> >> > Hi, >> > >> > The BUG_ON in khthread_bind (line 165 in kthread.c) triggers for me during

Re: 2.6.21-rc7-mm1: BUG_ON in kthread_bind during _cpu_down

2007-04-26 Thread Gautham R Shenoy
On Wed, Apr 25, 2007 at 04:54:10PM -0700, Andrew Morton wrote: > On Thu, 26 Apr 2007 01:10:21 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> > wrote: > > > Hi, > > > > The BUG_ON in khthread_bind (line 165 in kthread.c) triggers for me during > > attempted suspend to disk, when disable_nonboot_cp

Re: 2.6.21-rc7-mm1: BUG_ON in kthread_bind during _cpu_down

2007-04-25 Thread Andrew Morton
On Thu, 26 Apr 2007 01:10:21 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > Hi, > > The BUG_ON in khthread_bind (line 165 in kthread.c) triggers for me during > attempted suspend to disk, when disable_nonboot_cpus() calls _cpu_down() > (on x86_64). I guess the backtrace would be pretty

2.6.21-rc7-mm1: BUG_ON in kthread_bind during _cpu_down

2007-04-25 Thread Rafael J. Wysocki
Hi, The BUG_ON in khthread_bind (line 165 in kthread.c) triggers for me during attempted suspend to disk, when disable_nonboot_cpus() calls _cpu_down() (on x86_64). This didn't happen with 2.6.21-rc6-mm1. Greetings, Rafael -- If you don't have the time to read, you don't have the time or the