Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

2007-06-12 Thread Dave Jones
On Tue, Jun 12, 2007 at 03:43:45PM -0700, Andrew Morton wrote: > On Tue, 12 Jun 2007 18:16:29 -0400 > Dave Jones <[EMAIL PROTECTED]> wrote: > > > > > # Read KERNELRELEASE from include/config/kernel.release (if it > > exists) > > > > > > This causes the i386 allmodconfig build to fail:

Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

2007-06-12 Thread Andrew Morton
On Tue, 12 Jun 2007 18:16:29 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > > > # Read KERNELRELEASE from include/config/kernel.release (if it exists) > > > > This causes the i386 allmodconfig build to fail: > > Seems to be doing its job rather effectively. err, hang on. I had a different p

Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

2007-06-12 Thread Adrian Bunk
On Tue, Jun 12, 2007 at 03:03:57PM -0700, Andrew Morton wrote: > On Mon, 11 Jun 2007 23:22:24 -0400 > Dave Jones <[EMAIL PROTECTED]> wrote: > > > Add -Werror-implicit-function-declaration > > This makes builds fail sooner if something is implicitly defined instead > > of having to wait half an hou

Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

2007-06-12 Thread Dave Jones
On Tue, Jun 12, 2007 at 03:03:57PM -0700, Andrew Morton wrote: > On Mon, 11 Jun 2007 23:22:24 -0400 > Dave Jones <[EMAIL PROTECTED]> wrote: > > > Add -Werror-implicit-function-declaration > > This makes builds fail sooner if something is implicitly defined instead > > of having to wait half

Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

2007-06-12 Thread Andrew Morton
On Mon, 11 Jun 2007 23:22:24 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > Add -Werror-implicit-function-declaration > This makes builds fail sooner if something is implicitly defined instead > of having to wait half an hour for it to fail at the linking stage. > > Signed-off-by: Dave Jones <[EMA

Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

2007-06-11 Thread Avi Kivity
Adrian Bunk wrote: > On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote: > >> ... >> Changes since 2.6.22-rc4-mm1: >> ... >> git-kvm.patch >> ... >> git trees >> ... >> > > I'm getting the following compile error with CONFIG_X86_CMPXCHG64=n > (with -Werror-implicit-function-de

Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

2007-06-11 Thread Dave Jones
On Tue, Jun 12, 2007 at 02:07:18AM +0200, Adrian Bunk wrote: > I'm getting the following compile error with CONFIG_X86_CMPXCHG64=n > (with -Werror-implicit-function-declaration - otherwise it would be a > link error): We really should just get that flag into mainline so that it breaks for p

2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

2007-06-11 Thread Adrian Bunk
On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote: >... > Changes since 2.6.22-rc4-mm1: >... > git-kvm.patch >... > git trees >... I'm getting the following compile error with CONFIG_X86_CMPXCHG64=n (with -Werror-implicit-function-declaration - otherwise it would be a link error):