Re: 2.6.23-rc4-mm1: broke pata_via cable detection

2007-09-10 Thread Jeff Garzik
Laurent Riffard wrote: Le 01.09.2007 06:58, Andrew Morton a écrit : ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/ [...] +libata-correct-handling-of-srst-reset-sequences.patch [...] Alan, libata-correct-handling-of-srst-reset-sequences.patch broke

Re: 2.6.23-rc4-mm1: broke pata_via cable detection

2007-09-10 Thread Jeff Garzik
Laurent Riffard wrote: Le 01.09.2007 06:58, Andrew Morton a écrit : ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/ [...] +libata-correct-handling-of-srst-reset-sequences.patch [...] Alan, libata-correct-handling-of-srst-reset-sequences.patch broke

Re: 2.6.23-rc4-mm1: broke pata_via cable detection

2007-09-02 Thread Alan Cox
> via_do_set_mode overwrites 80-wire cable detection bits. Let's > preserve them. Agreed, on a reset case we may otherwise get confused and misdetect the cable. Change agrees with the data sheet > > Signed-off-by: Laurent Riffard <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]>

Re: 2.6.23-rc4-mm1: broke pata_via cable detection

2007-09-02 Thread Laurent Riffard
Le 01.09.2007 06:58, Andrew Morton a écrit : > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/ [...] > +libata-correct-handling-of-srst-reset-sequences.patch [...] Alan, libata-correct-handling-of-srst-reset-sequences.patch broke 80-wire cable detection

Re: 2.6.23-rc4-mm1: broke pata_via cable detection

2007-09-02 Thread Laurent Riffard
Le 01.09.2007 06:58, Andrew Morton a écrit : ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/ [...] +libata-correct-handling-of-srst-reset-sequences.patch [...] Alan, libata-correct-handling-of-srst-reset-sequences.patch broke 80-wire cable detection on

Re: 2.6.23-rc4-mm1: broke pata_via cable detection

2007-09-02 Thread Alan Cox
via_do_set_mode overwrites 80-wire cable detection bits. Let's preserve them. Agreed, on a reset case we may otherwise get confused and misdetect the cable. Change agrees with the data sheet Signed-off-by: Laurent Riffard [EMAIL PROTECTED] Acked-by: Alan Cox [EMAIL PROTECTED] Thanks a