> How about running 2.6.24-rc4 with _only_ the patch to this driver to
> convert it to krefs? Does that combination cause problems?
>
> The patch is at:
>
> http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-01-driver/kobject-convert-hvcs-to-use-kref-not-kobject.patch
How about running 2.6.24-rc4 with _only_ the patch to this driver to
convert it to krefs? Does that combination cause problems?
The patch is at:
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-01-driver/kobject-convert-hvcs-to-use-kref-not-kobject.patch
This
On Fri, Dec 07, 2007 at 08:32:26AM +0530, Kamalesh Babulal wrote:
> Greg KH wrote:
> > On Thu, Dec 06, 2007 at 03:54:51PM -0800, Badari Pulavarty wrote:
> >> On Thu, 2007-12-06 at 12:31 -0800, Greg KH wrote:
> >>> On Fri, Dec 07, 2007 at 12:28:58AM +0530, Balbir Singh wrote:
> Greg KH wrote:
Greg KH wrote:
> On Thu, Dec 06, 2007 at 03:54:51PM -0800, Badari Pulavarty wrote:
>> On Thu, 2007-12-06 at 12:31 -0800, Greg KH wrote:
>>> On Fri, Dec 07, 2007 at 12:28:58AM +0530, Balbir Singh wrote:
Greg KH wrote:
>> Why release the spinlock here? It's done after the count is
Badari Pulavarty wrote:
> On Fri, 2007-12-07 at 00:28 +0530, Balbir Singh wrote:
>> Greg KH wrote:
>>
Why release the spinlock here? It's done after the count is incremented.
This patch does not seem correct.
>>> Doh, you are correct, I'll make sure that I fix this up before applying
>>>
On Thu, Dec 06, 2007 at 03:54:51PM -0800, Badari Pulavarty wrote:
> On Thu, 2007-12-06 at 12:31 -0800, Greg KH wrote:
> > On Fri, Dec 07, 2007 at 12:28:58AM +0530, Balbir Singh wrote:
> > > Greg KH wrote:
> > >
> > > >> Why release the spinlock here? It's done after the count is
> > > >>
On Thu, 2007-12-06 at 12:31 -0800, Greg KH wrote:
> On Fri, Dec 07, 2007 at 12:28:58AM +0530, Balbir Singh wrote:
> > Greg KH wrote:
> >
> > >> Why release the spinlock here? It's done after the count is incremented.
> > >> This patch does not seem correct.
> > >
> > > Doh, you are correct, I'll
On Fri, Dec 07, 2007 at 12:28:58AM +0530, Balbir Singh wrote:
> Greg KH wrote:
>
> >> Why release the spinlock here? It's done after the count is incremented.
> >> This patch does not seem correct.
> >
> > Doh, you are correct, I'll make sure that I fix this up before applying
> > it.
> >
> >
On Thu, Dec 06, 2007 at 11:49:59PM +0530, Balbir Singh wrote:
> Kamalesh Babulal wrote:
> > Hi Andrew,
> >
> > The 2.6.24-rc4-mm1 kernel build fails with build failure,
> >
> > CC drivers/char/hvcs.o
> > drivers/char/hvcs.c: In function ‘hvcs_open’:
> > drivers/char/hvcs.c:1180: error:
On Fri, 2007-12-07 at 00:28 +0530, Balbir Singh wrote:
> Greg KH wrote:
>
> >> Why release the spinlock here? It's done after the count is incremented.
> >> This patch does not seem correct.
> >
> > Doh, you are correct, I'll make sure that I fix this up before applying
> > it.
> >
> > thanks,
Greg KH wrote:
>> Why release the spinlock here? It's done after the count is incremented.
>> This patch does not seem correct.
>
> Doh, you are correct, I'll make sure that I fix this up before applying
> it.
>
> thanks,
>
> greg k-h
Hi, Greg,
I ran some tests with the fixed up version of
Greg KH wrote:
> On Thu, Dec 06, 2007 at 11:49:59PM +0530, Balbir Singh wrote:
>> Kamalesh Babulal wrote:
>>> Hi Andrew,
>>>
>>> The 2.6.24-rc4-mm1 kernel build fails with build failure,
>>>
>>> CC drivers/char/hvcs.o
>>> drivers/char/hvcs.c: In function ‘hvcs_open’:
>>>
Kamalesh Babulal wrote:
> Hi Andrew,
>
> The 2.6.24-rc4-mm1 kernel build fails with build failure,
>
> CC drivers/char/hvcs.o
> drivers/char/hvcs.c: In function ‘hvcs_open’:
> drivers/char/hvcs.c:1180: error: wrong type argument to unary exclamation mark
> make[2]: ***
Kamalesh Babulal wrote:
Hi Andrew,
The 2.6.24-rc4-mm1 kernel build fails with build failure,
CC drivers/char/hvcs.o
drivers/char/hvcs.c: In function ‘hvcs_open’:
drivers/char/hvcs.c:1180: error: wrong type argument to unary exclamation mark
make[2]: *** [drivers/char/hvcs.o] Error
Greg KH wrote:
On Thu, Dec 06, 2007 at 11:49:59PM +0530, Balbir Singh wrote:
Kamalesh Babulal wrote:
Hi Andrew,
The 2.6.24-rc4-mm1 kernel build fails with build failure,
CC drivers/char/hvcs.o
drivers/char/hvcs.c: In function ‘hvcs_open’:
drivers/char/hvcs.c:1180: error: wrong type
Greg KH wrote:
Why release the spinlock here? It's done after the count is incremented.
This patch does not seem correct.
Doh, you are correct, I'll make sure that I fix this up before applying
it.
thanks,
greg k-h
Hi, Greg,
I ran some tests with the fixed up version of this patch
On Fri, 2007-12-07 at 00:28 +0530, Balbir Singh wrote:
Greg KH wrote:
Why release the spinlock here? It's done after the count is incremented.
This patch does not seem correct.
Doh, you are correct, I'll make sure that I fix this up before applying
it.
thanks,
greg k-h
On Thu, Dec 06, 2007 at 11:49:59PM +0530, Balbir Singh wrote:
Kamalesh Babulal wrote:
Hi Andrew,
The 2.6.24-rc4-mm1 kernel build fails with build failure,
CC drivers/char/hvcs.o
drivers/char/hvcs.c: In function ‘hvcs_open’:
drivers/char/hvcs.c:1180: error: wrong type
On Fri, Dec 07, 2007 at 12:28:58AM +0530, Balbir Singh wrote:
Greg KH wrote:
Why release the spinlock here? It's done after the count is incremented.
This patch does not seem correct.
Doh, you are correct, I'll make sure that I fix this up before applying
it.
thanks,
greg
On Thu, 2007-12-06 at 12:31 -0800, Greg KH wrote:
On Fri, Dec 07, 2007 at 12:28:58AM +0530, Balbir Singh wrote:
Greg KH wrote:
Why release the spinlock here? It's done after the count is incremented.
This patch does not seem correct.
Doh, you are correct, I'll make sure that I
On Thu, Dec 06, 2007 at 03:54:51PM -0800, Badari Pulavarty wrote:
On Thu, 2007-12-06 at 12:31 -0800, Greg KH wrote:
On Fri, Dec 07, 2007 at 12:28:58AM +0530, Balbir Singh wrote:
Greg KH wrote:
Why release the spinlock here? It's done after the count is
incremented.
This
Badari Pulavarty wrote:
On Fri, 2007-12-07 at 00:28 +0530, Balbir Singh wrote:
Greg KH wrote:
Why release the spinlock here? It's done after the count is incremented.
This patch does not seem correct.
Doh, you are correct, I'll make sure that I fix this up before applying
it.
thanks,
Greg KH wrote:
On Thu, Dec 06, 2007 at 03:54:51PM -0800, Badari Pulavarty wrote:
On Thu, 2007-12-06 at 12:31 -0800, Greg KH wrote:
On Fri, Dec 07, 2007 at 12:28:58AM +0530, Balbir Singh wrote:
Greg KH wrote:
Why release the spinlock here? It's done after the count is incremented.
This patch
On Fri, Dec 07, 2007 at 08:32:26AM +0530, Kamalesh Babulal wrote:
Greg KH wrote:
On Thu, Dec 06, 2007 at 03:54:51PM -0800, Badari Pulavarty wrote:
On Thu, 2007-12-06 at 12:31 -0800, Greg KH wrote:
On Fri, Dec 07, 2007 at 12:28:58AM +0530, Balbir Singh wrote:
Greg KH wrote:
Why release
On Wed, Dec 05, 2007 at 07:42:02PM +0530, Kamalesh Babulal wrote:
> Hi Andrew,
>
> The 2.6.24-rc4-mm1 kernel build fails with build failure,
>
> CC drivers/char/hvcs.o
> drivers/char/hvcs.c: In function ‘hvcs_open’:
> drivers/char/hvcs.c:1180: error: wrong type argument to unary
Hi Andrew,
The 2.6.24-rc4-mm1 kernel build fails with build failure,
CC drivers/char/hvcs.o
drivers/char/hvcs.c: In function ‘hvcs_open’:
drivers/char/hvcs.c:1180: error: wrong type argument to unary exclamation mark
make[2]: *** [drivers/char/hvcs.o] Error 1
make[1]: *** [drivers/char]
On Wed, Dec 05, 2007 at 07:42:02PM +0530, Kamalesh Babulal wrote:
Hi Andrew,
The 2.6.24-rc4-mm1 kernel build fails with build failure,
CC drivers/char/hvcs.o
drivers/char/hvcs.c: In function ‘hvcs_open’:
drivers/char/hvcs.c:1180: error: wrong type argument to unary exclamation mark
Hi Andrew,
The 2.6.24-rc4-mm1 kernel build fails with build failure,
CC drivers/char/hvcs.o
drivers/char/hvcs.c: In function ‘hvcs_open’:
drivers/char/hvcs.c:1180: error: wrong type argument to unary exclamation mark
make[2]: *** [drivers/char/hvcs.o] Error 1
make[1]: *** [drivers/char]
28 matches
Mail list logo
