Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-18 Thread Jeff Dike
On Tue, Dec 18, 2007 at 06:04:58PM -0800, Andrew Morton wrote: > Nobody seems to look after hppfs. I'll resend the fat and hostfs patches to > maintainers for a review, please. It's mine - I'll take a look at it. Jeff -- Work email - jdike at linux dot intel

Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-18 Thread Andrew Morton
On Wed, 19 Dec 2007 01:22:21 + David Howells <[EMAIL PROTECTED]> wrote: > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > - inode = ERR_PTR(ret); > > > + return NULL; > > > } else { > > > unlock_new_inode(inode); > > > }

Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-18 Thread Dave Young
On Dec 19, 2007 9:22 AM, David Howells <[EMAIL PROTECTED]> wrote: > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > - inode = ERR_PTR(ret); > > > + return NULL; > > > } else { > > > unlock_new_inode(inode); > > > } >

Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-18 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote: > > - inode = ERR_PTR(ret); > > + return NULL; > > } else { > > unlock_new_inode(inode); > > } > > > > Yup. Nope. The correct fix is to make the various callers use

Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-18 Thread Valdis . Kletnieks
(Adding Dave Howells, his name is on iget-stop-isofs-from-using-read_inode.patch) On Tue, 18 Dec 2007 10:37:32 +0800, Dave Young said: > > I don't mind it failing the mount, but the oops seems excessive. I suspect > > that *somewhere* in that stack trace, we're wanting something like a > > >

Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-18 Thread Valdis . Kletnieks
(Adding Dave Howells, his name is on iget-stop-isofs-from-using-read_inode.patch) On Tue, 18 Dec 2007 10:37:32 +0800, Dave Young said: I don't mind it failing the mount, but the oops seems excessive. I suspect that *somewhere* in that stack trace, we're wanting something like a if

Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-18 Thread David Howells
Andrew Morton [EMAIL PROTECTED] wrote: - inode = ERR_PTR(ret); + return NULL; } else { unlock_new_inode(inode); } Yup. Nope. The correct fix is to make the various callers use IS_ERR() to check the

Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-18 Thread Dave Young
On Dec 19, 2007 9:22 AM, David Howells [EMAIL PROTECTED] wrote: Andrew Morton [EMAIL PROTECTED] wrote: - inode = ERR_PTR(ret); + return NULL; } else { unlock_new_inode(inode); } Yup. Nope.

Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-18 Thread Andrew Morton
On Wed, 19 Dec 2007 01:22:21 + David Howells [EMAIL PROTECTED] wrote: Andrew Morton [EMAIL PROTECTED] wrote: - inode = ERR_PTR(ret); + return NULL; } else { unlock_new_inode(inode); } Yup.

Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-18 Thread Jeff Dike
On Tue, Dec 18, 2007 at 06:04:58PM -0800, Andrew Morton wrote: Nobody seems to look after hppfs. I'll resend the fat and hostfs patches to maintainers for a review, please. It's mine - I'll take a look at it. Jeff -- Work email - jdike at linux dot intel dot

Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-17 Thread Andrew Morton
On Tue, 18 Dec 2007 10:37:32 +0800 Dave Young <[EMAIL PROTECTED]> wrote: > On Mon, Dec 17, 2007 at 09:07:56PM -0500, [EMAIL PROTECTED] wrote: > > On Mon, 17 Dec 2007 14:56:44 PST, Andrew Morton said: > > > > (Adding Al Viro to the list, he's listed as "file systems" and MAINTAINERS > > doesn't

Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-17 Thread Dave Young
On Mon, Dec 17, 2007 at 09:07:56PM -0500, [EMAIL PROTECTED] wrote: > On Mon, 17 Dec 2007 14:56:44 PST, Andrew Morton said: > > (Adding Al Viro to the list, he's listed as "file systems" and MAINTAINERS > doesn't list 'isofs' anyplace. Will Al or Andrew please vector to whoever > actually does

Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-17 Thread Valdis . Kletnieks
On Mon, 17 Dec 2007 14:56:44 PST, Andrew Morton said: (Adding Al Viro to the list, he's listed as "file systems" and MAINTAINERS doesn't list 'isofs' anyplace. Will Al or Andrew please vector to whoever actually does that code?) > > I try it again, and it reports it died at the same exact

Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-17 Thread Andrew Morton
On Mon, 17 Dec 2007 17:44:11 -0500 [EMAIL PROTECTED] wrote: > On Thu, 13 Dec 2007 02:40:50 PST, Andrew Morton said: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc5/2.6.24-rc5-mm1/ > > OK, so I'm trying to 'dd' a CD and the drive on the laptop is having issues >

2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-17 Thread Valdis . Kletnieks
On Thu, 13 Dec 2007 02:40:50 PST, Andrew Morton said: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc5/2.6.24-rc5-mm1/ OK, so I'm trying to 'dd' a CD and the drive on the laptop is having issues reading the disk. I try it once, and get an I/O error about 117M in - dd

2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-17 Thread Valdis . Kletnieks
On Thu, 13 Dec 2007 02:40:50 PST, Andrew Morton said: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc5/2.6.24-rc5-mm1/ OK, so I'm trying to 'dd' a CD and the drive on the laptop is having issues reading the disk. I try it once, and get an I/O error about 117M in - dd

Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-17 Thread Andrew Morton
On Mon, 17 Dec 2007 17:44:11 -0500 [EMAIL PROTECTED] wrote: On Thu, 13 Dec 2007 02:40:50 PST, Andrew Morton said: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc5/2.6.24-rc5-mm1/ OK, so I'm trying to 'dd' a CD and the drive on the laptop is having issues reading the

Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-17 Thread Valdis . Kletnieks
On Mon, 17 Dec 2007 14:56:44 PST, Andrew Morton said: (Adding Al Viro to the list, he's listed as file systems and MAINTAINERS doesn't list 'isofs' anyplace. Will Al or Andrew please vector to whoever actually does that code?) I try it again, and it reports it died at the same exact place,

Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-17 Thread Dave Young
On Mon, Dec 17, 2007 at 09:07:56PM -0500, [EMAIL PROTECTED] wrote: On Mon, 17 Dec 2007 14:56:44 PST, Andrew Morton said: (Adding Al Viro to the list, he's listed as file systems and MAINTAINERS doesn't list 'isofs' anyplace. Will Al or Andrew please vector to whoever actually does that

Re: 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior...

2007-12-17 Thread Andrew Morton
On Tue, 18 Dec 2007 10:37:32 +0800 Dave Young [EMAIL PROTECTED] wrote: On Mon, Dec 17, 2007 at 09:07:56PM -0500, [EMAIL PROTECTED] wrote: On Mon, 17 Dec 2007 14:56:44 PST, Andrew Morton said: (Adding Al Viro to the list, he's listed as file systems and MAINTAINERS doesn't list 'isofs'