On Mon, 28 Jan 2008, Jan Engelhardt wrote:
> On Jan 28 2008 01:05, Trent Piepho wrote:
>
> >Maybe the kernel headers should provide a couple macros for testing
> >configs, since people get it wrong over and over again?
> >
> >#define CONFIG_ON(x) (defined(CONFIG_##x) || defined(CONFIG_##x##_MODULE)
Hi Trent,
> Also only the function v4l2_i2c_attach() is a problem. The other functions,
> like v4l2_chip_match_i2c_client(), which the patch put inside an #ifdef
> don't use any i2c symbols and don't need to be protected.
> could even easily be used by a driver that doesn't
> need I2C.
True, b
On Mon, 28 Jan 2008 14:12:45 +0200
Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> Why does anyone want to introduce such a weird syntax for something
> that already works with the simple
>
> depends on I2C || I2C=n
>
This didn't work.
Something weird is happening here... It seems that "menuc
> Could you please prepare the changeset for the macro, as suggested by Ian?
In time:
s/as suggested by Ian/considering Jan's arguments/
Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On Mon, Jan 28, 2008 at 01:17:10PM +0100, Jan Engelhardt wrote:
>
> On Jan 28 2008 01:05, Trent Piepho wrote:
>
> >Maybe the kernel headers should provide a couple macros for testing
> >configs, since people get it wrong over and over again?
> >
> >#define CONFIG_ON(x) (defined(CONFIG_##x) || def
On Mon, 28 Jan 2008 14:12:45 +0200
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> On Mon, Jan 28, 2008 at 09:49:12AM -0200, Mauro Carvalho Chehab wrote:
> > > Maybe the kernel headers should provide a couple macros for testing
> > > configs, since people get it wrong over and over again?
> > >
> > > #d
On Jan 28 2008 01:05, Trent Piepho wrote:
>Maybe the kernel headers should provide a couple macros for testing
>configs, since people get it wrong over and over again?
>
>#define CONFIG_ON(x) (defined(CONFIG_##x) || defined(CONFIG_##x##_MODULE))
>#define CONFIG_AVAIABLE(x) (defined(CONFIG_##x) ||
On Mon, Jan 28, 2008 at 09:49:12AM -0200, Mauro Carvalho Chehab wrote:
> > Maybe the kernel headers should provide a couple macros for testing
> > configs, since people get it wrong over and over again?
> >
> > #define CONFIG_ON(x) (defined(CONFIG_##x) || defined(CONFIG_##x##_MODULE))
> > #define
> Maybe the kernel headers should provide a couple macros for testing
> configs, since people get it wrong over and over again?
>
> #define CONFIG_ON(x) (defined(CONFIG_##x) || defined(CONFIG_##x##_MODULE))
> #define CONFIG_AVAIABLE(x) (defined(CONFIG_##x) || (defined(MODULE) &&
> defined(CONFIG_
On Mon, 28 Jan 2008, Adrian Bunk wrote:
> On Sun, Jan 27, 2008 at 10:33:34PM -0200, Mauro Carvalho Chehab wrote:
> > On Sun, 27 Jan 2008 20:52:16 +0200
> > Adrian Bunk <[EMAIL PROTECTED]> wrote:
> >
> > > Commit 8ffbc6559493c64d6194c92d856196fdaeb8a5fb causes the following
> > > compile error with
On Sun, Jan 27, 2008 at 10:33:34PM -0200, Mauro Carvalho Chehab wrote:
> Hi Adrian and Marcin,
>
> On Sun, 27 Jan 2008 20:52:16 +0200
> Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> > Commit 8ffbc6559493c64d6194c92d856196fdaeb8a5fb causes the following
> > compile error with CONFIG_VIDEO_DEV=y/m, C
Hi Adrian and Marcin,
On Sun, 27 Jan 2008 20:52:16 +0200
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> Commit 8ffbc6559493c64d6194c92d856196fdaeb8a5fb causes the following
> compile error with CONFIG_VIDEO_DEV=y/m, CONFIG_I2C=n:
>
> <-- snip -->
>
> ...
> MODPOST 26 modules
> ERROR: "i2c_attach
Commit 8ffbc6559493c64d6194c92d856196fdaeb8a5fb causes the following
compile error with CONFIG_VIDEO_DEV=y/m, CONFIG_I2C=n:
<-- snip -->
...
MODPOST 26 modules
ERROR: "i2c_attach_client" [drivers/media/video/v4l2-common.ko] undefined!
make[2]: *** [__modpost] Error 1
<-- snip -->
cu
Adri
13 matches
Mail list logo