Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-09-22 Thread Kari Suvanto
Ok I missed that and it did not show up with my searches. I also tested your patch on top of next-20140922 and it seems to work. -Kari -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-09-22 Thread Samuel Thibault
Kari Suvanto, le Mon 22 Sep 2014 10:30:32 +0300, a écrit : > >Ew. I'll have a look. > > Any update on this one? I have already sent it, yes, on Tue, 26 Aug 2014 11:17:25 +0200, here it is again. Samuel Subject: [PATCHv2][input-led] Defer input led work to workqueue When the kbd changes its

Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-09-22 Thread Kari Suvanto
>Ew. I'll have a look. sorry, sending again, first one had html in it.. Any update on this one? I'm seeing this in every boot. I patched this by changing led_trigger_register and led_trigger_register_simple as macros which creates a static lock_class_key like this: -extern int

Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-09-22 Thread Kari Suvanto
Ew. I'll have a look. sorry, sending again, first one had html in it.. Any update on this one? I'm seeing this in every boot. I patched this by changing led_trigger_register and led_trigger_register_simple as macros which creates a static lock_class_key like this: -extern int

Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-09-22 Thread Samuel Thibault
Kari Suvanto, le Mon 22 Sep 2014 10:30:32 +0300, a écrit : Ew. I'll have a look. Any update on this one? I have already sent it, yes, on Tue, 26 Aug 2014 11:17:25 +0200, here it is again. Samuel Subject: [PATCHv2][input-led] Defer input led work to workqueue When the kbd changes its led

Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-09-22 Thread Kari Suvanto
Ok I missed that and it did not show up with my searches. I also tested your patch on top of next-20140922 and it seems to work. -Kari -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-08-25 Thread Samuel Thibault
Hugh Dickins, le Mon 25 Aug 2014 15:00:44 -0700, a écrit : > On Mon, 25 Aug 2014, Samuel Thibault wrote: > > Samuel Thibault, le Mon 25 Aug 2014 23:23:24 +0200, a écrit : > > > We could indeed have a loop if the user was making the VT::* leds use > > > the vt-* trigger, > > > > Actually, while

Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-08-25 Thread Hugh Dickins
On Mon, 25 Aug 2014, Samuel Thibault wrote: > Samuel Thibault, le Mon 25 Aug 2014 23:23:24 +0200, a écrit : > > We could indeed have a loop if the user was making the VT::* leds use > > the vt-* trigger, > > Actually, while there can be a loop, it wouldn't be possible to inject > events in it: a

Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-08-25 Thread Samuel Thibault
Samuel Thibault, le Mon 25 Aug 2014 23:23:24 +0200, a écrit : > We could indeed have a loop if the user was making the VT::* leds use > the vt-* trigger, Actually, while there can be a loop, it wouldn't be possible to inject events in it: a VT::* led only makes the corresponding vt-* trigger if

Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-08-25 Thread Samuel Thibault
Hello, Sabrina Dubroca, le Mon 25 Aug 2014 23:13:40 +0200, a écrit : > 2014-08-19, 13:06:07 -0400, valdis.kletni...@vt.edu wrote: > > On Sat, 16 Aug 2014 20:27:01 -0700, Hugh Dickins said: > > > Can we safely revert your 8b37e1bef5a6 ("leds: convert blink timer to > > > workqueue"), or have there

Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-08-25 Thread Sabrina Dubroca
2014-08-19, 13:06:07 -0400, valdis.kletni...@vt.edu wrote: > On Sat, 16 Aug 2014 20:27:01 -0700, Hugh Dickins said: > > Can we safely revert your 8b37e1bef5a6 ("leds: convert blink timer to > > workqueue"), or have there been other changes which now depend upon it? > > I suspect there's something

Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-08-25 Thread Sabrina Dubroca
2014-08-19, 13:06:07 -0400, valdis.kletni...@vt.edu wrote: On Sat, 16 Aug 2014 20:27:01 -0700, Hugh Dickins said: Can we safely revert your 8b37e1bef5a6 (leds: convert blink timer to workqueue), or have there been other changes which now depend upon it? I suspect there's something else

Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-08-25 Thread Samuel Thibault
Hello, Sabrina Dubroca, le Mon 25 Aug 2014 23:13:40 +0200, a écrit : 2014-08-19, 13:06:07 -0400, valdis.kletni...@vt.edu wrote: On Sat, 16 Aug 2014 20:27:01 -0700, Hugh Dickins said: Can we safely revert your 8b37e1bef5a6 (leds: convert blink timer to workqueue), or have there been other

Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-08-25 Thread Samuel Thibault
Samuel Thibault, le Mon 25 Aug 2014 23:23:24 +0200, a écrit : We could indeed have a loop if the user was making the VT::* leds use the vt-* trigger, Actually, while there can be a loop, it wouldn't be possible to inject events in it: a VT::* led only makes the corresponding vt-* trigger if it

Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-08-25 Thread Hugh Dickins
On Mon, 25 Aug 2014, Samuel Thibault wrote: Samuel Thibault, le Mon 25 Aug 2014 23:23:24 +0200, a écrit : We could indeed have a loop if the user was making the VT::* leds use the vt-* trigger, Actually, while there can be a loop, it wouldn't be possible to inject events in it: a VT::*

Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-08-25 Thread Samuel Thibault
Hugh Dickins, le Mon 25 Aug 2014 15:00:44 -0700, a écrit : On Mon, 25 Aug 2014, Samuel Thibault wrote: Samuel Thibault, le Mon 25 Aug 2014 23:23:24 +0200, a écrit : We could indeed have a loop if the user was making the VT::* leds use the vt-* trigger, Actually, while there can be a

Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-08-19 Thread Valdis . Kletnieks
On Sat, 16 Aug 2014 20:27:01 -0700, Hugh Dickins said: > Can we safely revert your 8b37e1bef5a6 ("leds: convert blink timer to > workqueue"), or have there been other changes which now depend upon it? I suspect there's something else busted. I hand-reverted that patch, and I *still* see the

Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-08-19 Thread Valdis . Kletnieks
On Sat, 16 Aug 2014 20:27:01 -0700, Hugh Dickins said: Can we safely revert your 8b37e1bef5a6 (leds: convert blink timer to workqueue), or have there been other changes which now depend upon it? I suspect there's something else busted. I hand-reverted that patch, and I *still* see the

3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-08-16 Thread Hugh Dickins
Can we safely revert your 8b37e1bef5a6 ("leds: convert blink timer to workqueue"), or have there been other changes which now depend upon it? Your commit comment says: This patch converts the blink timer from led-core to workqueue which is more suitable for this kind of non-priority operations.

3.17-rc1: leds blink workqueue causes sleeping BUGs

2014-08-16 Thread Hugh Dickins
Can we safely revert your 8b37e1bef5a6 (leds: convert blink timer to workqueue), or have there been other changes which now depend upon it? Your commit comment says: This patch converts the blink timer from led-core to workqueue which is more suitable for this kind of non-priority operations.