Not-so-old machines without PAE was Re: 32-bit PTI with THP = userspace corruption

2018-10-23 Thread Pavel Machek
On Mon 2018-10-22 19:48:17, Alan Cox wrote: > On Mon, 22 Oct 2018 09:56:42 +0200 > Joerg Roedel wrote: > > > On Sun, Oct 21, 2018 at 02:37:45PM +0200, Pavel Machek wrote: > > > On Tue 2018-09-18 14:00:30, Alan Cox wrote: > > > > There are pretty much no machines that don't support PAE and are s

Re: 32-bit PTI with THP = userspace corruption

2018-10-22 Thread Pavel Machek
On Mon 2018-10-22 09:56:42, Joerg Roedel wrote: > On Sun, Oct 21, 2018 at 02:37:45PM +0200, Pavel Machek wrote: > > On Tue 2018-09-18 14:00:30, Alan Cox wrote: > > > There are pretty much no machines that don't support PAE and are still > > > even vaguely able to boot a modern Linux kernel. The odd

Re: 32-bit PTI with THP = userspace corruption

2018-10-22 Thread Alan Cox
On Mon, 22 Oct 2018 09:56:42 +0200 Joerg Roedel wrote: > On Sun, Oct 21, 2018 at 02:37:45PM +0200, Pavel Machek wrote: > > On Tue 2018-09-18 14:00:30, Alan Cox wrote: > > > There are pretty much no machines that don't support PAE and are still > > > even vaguely able to boot a modern Linux kern

Re: 32-bit PTI with THP = userspace corruption

2018-10-22 Thread Joerg Roedel
On Sun, Oct 21, 2018 at 02:37:45PM +0200, Pavel Machek wrote: > On Tue 2018-09-18 14:00:30, Alan Cox wrote: > > There are pretty much no machines that don't support PAE and are still > > even vaguely able to boot a modern Linux kernel. The oddity is the > > Pentium-M but most distros shipped a hack

Re: 32-bit PTI with THP = userspace corruption

2018-10-21 Thread Pavel Machek
On Tue 2018-09-18 14:00:30, Alan Cox wrote: > On Tue, 11 Sep 2018 14:12:22 +0200 > Joerg Roedel wrote: > > > On Tue, Sep 11, 2018 at 02:58:10PM +0300, Meelis Roos wrote: > > > The machines where I have PAE off are the ones that have less memory. > > > PAE is off just for performance reasons, not

Re: 32-bit PTI with THP = userspace corruption

2018-09-18 Thread Alan Cox
On Tue, 11 Sep 2018 14:12:22 +0200 Joerg Roedel wrote: > On Tue, Sep 11, 2018 at 02:58:10PM +0300, Meelis Roos wrote: > > The machines where I have PAE off are the ones that have less memory. > > PAE is off just for performance reasons, not lack of PAE. PAE should be > > present on all of my af

Re: 32-bit PTI with THP = userspace corruption

2018-09-11 Thread Linus Torvalds
On Tue, Sep 11, 2018 at 1:49 AM Joerg Roedel wrote: > > I had a look into the THP and the HugeTLBfs code, and that is not > really easy to fix there. As I can see it now, there are a few options > to fix that, but most of them are ugly: Just do (4): disable PTI with PAE. Then we can try to make

Re: 32-bit PTI with THP = userspace corruption

2018-09-11 Thread Joerg Roedel
On Tue, Sep 11, 2018 at 02:58:10PM +0300, Meelis Roos wrote: > The machines where I have PAE off are the ones that have less memory. > PAE is off just for performance reasons, not lack of PAE. PAE should be > present on all of my affected machines anyway and current distributions > seem to mostl

Re: 32-bit PTI with THP = userspace corruption

2018-09-11 Thread Meelis Roos
> 4) Disable PTI support on 2-level paging by making it dependent > on CONFIG_X86_PAE. This is, imho, the least ugly option > because the machines that do not support PAE are most likely > too old to be affected my Meltdown anyway. We might also > consider

Re: 32-bit PTI with THP = userspace corruption

2018-09-11 Thread Joerg Roedel
Hi, [ Andrea, maybe you can have a quick look here too, please? Maybe I am overlooking a simple way to fix the issue. Problem description is below. ] On Sat, Sep 08, 2018 at 12:24:10PM +0200, Thomas Gleixner wrote: > > I'll try to reproduce and work on a fix. > > Any progress on this? Yes

Re: 32-bit PTI with THP = userspace corruption

2018-09-08 Thread Thomas Gleixner
On Fri, 31 Aug 2018, Joerg Roedel wrote: > On Fri, Aug 31, 2018 at 07:12:44AM +0300, Meelis Roos wrote: > > > Thanks for the report! I'll try to reproduce the problem tomorrow and > > > investigate it. Can you please check if any of the kernel configurations > > > that show the bug has CONFIG_X8

Re: 32-bit PTI with THP = userspace corruption

2018-08-31 Thread Meelis Roos
> > I am seeing userland corruption and application crashes on multiple > > 32-bit machines with 4.19-rc1+git. The machines vary: PII, PIII, P4. > > They are all Intel. AMD Duron/Athlon/AthlonMP have been fine in my tests > > so far (may be configuration dependent). > > Thanks for the report! I

Re: 32-bit PTI with THP = userspace corruption

2018-08-31 Thread Joerg Roedel
On Fri, Aug 31, 2018 at 07:12:44AM +0300, Meelis Roos wrote: > > Thanks for the report! I'll try to reproduce the problem tomorrow and > > investigate it. Can you please check if any of the kernel configurations > > that show the bug has CONFIG_X86_PAE set? If not, can you please test > > if enabli

Re: 32-bit PTI with THP = userspace corruption

2018-08-30 Thread Meelis Roos
> > I am seeing userland corruption and application crashes on multiple > > 32-bit machines with 4.19-rc1+git. The machines vary: PII, PIII, P4. > > They are all Intel. AMD Duron/Athlon/AthlonMP have been fine in my tests > > so far (may be configuration dependent). > > Thanks for the report! I

Re: 32-bit PTI with THP = userspace corruption

2018-08-30 Thread Joerg Roedel
Hi Meelis, On Thu, Aug 30, 2018 at 09:09:19PM +0300, Meelis Roos wrote: > I am seeing userland corruption and application crashes on multiple > 32-bit machines with 4.19-rc1+git. The machines vary: PII, PIII, P4. > They are all Intel. AMD Duron/Athlon/AthlonMP have been fine in my tests > so fa

32-bit PTI with THP = userspace corruption

2018-08-30 Thread Meelis Roos
I am seeing userland corruption and application crashes on multiple 32-bit machines with 4.19-rc1+git. The machines vary: PII, PIII, P4. They are all Intel. AMD Duron/Athlon/AthlonMP have been fine in my tests so far (may be configuration dependent). Typical problem is running aptitude in Debia