Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-27 Thread Kirill A. Shutemov
On Thu, Jul 26, 2018 at 04:21:11PM +, Dmitry Malkin wrote: > On 07/26/2018 04:50 PM, Kirill A. Shutemov wrote: > > > > > 2. reading from memory which may be reserved in case of EFI systems: > > > > > > >    ebda_start = *(unsigned short *)0x40e << 4; > > > > > > >    bios_start = *(unsigned

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-26 Thread Dmitry Malkin
On 07/26/2018 04:50 PM, Kirill A. Shutemov wrote: 2. reading from memory which may be reserved in case of EFI systems:    ebda_start = *(unsigned short *)0x40e << 4;    bios_start = *(unsigned short *)0x413 << 10; Also, on EFI system without CSM it will results in all zeros. Which will plac

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-26 Thread Kirill A. Shutemov
On Thu, Jul 26, 2018 at 08:10:42AM +, Dmitry Malkin wrote: > > > On 07/25/2018 11:21 PM, Kirill A. Shutemov wrote: > > On Wed, Jul 25, 2018 at 05:26:02PM +, Dmitry Malkin wrote: > > > there may be some other reasons which may cause undefined behavior (reboot > > > for example): > > > > >

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-26 Thread Dmitry Malkin
On 07/25/2018 11:21 PM, Kirill A. Shutemov wrote: On Wed, Jul 25, 2018 at 05:26:02PM +, Dmitry Malkin wrote: there may be some other reasons which may cause undefined behavior (reboot for example): in arch/x86/boot/compressed/pgtable_64.c in function paging_prepare(): 1. structure "pagin

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-25 Thread Kirill A. Shutemov
On Wed, Jul 25, 2018 at 05:26:02PM +, Dmitry Malkin wrote: > there may be some other reasons which may cause undefined behavior (reboot > for example): > > in arch/x86/boot/compressed/pgtable_64.c in function paging_prepare(): > > 1. structure "paging_config" allocated on stack without settin

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-25 Thread Dmitry Malkin
there may be some other reasons which may cause undefined behavior (reboot for example): in arch/x86/boot/compressed/pgtable_64.c in function paging_prepare(): 1. structure "paging_config" allocated on stack without setting default value for flag "l5_required": >>struct paging_config paging_c

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-09 Thread Masahiro Yamada
2018-07-09 19:10 GMT+09:00 Kirill A. Shutemov : > On Sat, Jul 07, 2018 at 10:21:47AM +0900, Masahiro Yamada wrote: >> 2018-07-07 1:29 GMT+09:00 Kirill A. Shutemov : >> > On Fri, Jul 06, 2018 at 11:13:02PM +0900, Masahiro Yamada wrote: >> >> >> LDFLAGS is for internal-use. >> >> >> Please do not ove

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-09 Thread Kirill A. Shutemov
On Sat, Jul 07, 2018 at 10:21:47AM +0900, Masahiro Yamada wrote: > 2018-07-07 1:29 GMT+09:00 Kirill A. Shutemov : > > On Fri, Jul 06, 2018 at 11:13:02PM +0900, Masahiro Yamada wrote: > >> >> LDFLAGS is for internal-use. > >> >> Please do not override it from the command line. > >> > > >> > Can we g

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-06 Thread Masahiro Yamada
2018-07-07 1:29 GMT+09:00 Kirill A. Shutemov : > On Fri, Jul 06, 2018 at 11:13:02PM +0900, Masahiro Yamada wrote: >> >> LDFLAGS is for internal-use. >> >> Please do not override it from the command line. >> > >> > Can we generate a build error if a user try to override LDFLAGS, CFLAGS or >> > other

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-06 Thread Masahiro Yamada
2018-07-06 23:39 GMT+09:00 Gabriel C : > 2018-07-06 16:13 GMT+02:00 Masahiro Yamada : >> Hi. >> >> 2018-07-06 19:41 GMT+09:00 Kirill A. Shutemov : >>> On Fri, Jul 06, 2018 at 03:37:58PM +0900, Masahiro Yamada wrote: >> > > Also see https://bugzilla.kernel.org/show_bug.cgi?id=200385 , >> >

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-06 Thread Benjamin Gilbert
On Fri, Jul 06, 2018 at 11:11:10AM -0700, Andi Kleen wrote: > There are valid use cases to override the flags. I use it sometimes too, > and know some other people do to. > > But you need to know what you're doing. > > Perhaps a warning during build would be reasonable. So if you ask > for a bui

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-06 Thread Andi Kleen
> At least we need to make user aware about risk of setting custom flags. There are valid use cases to override the flags. I use it sometimes too, and know some other people do to. But you need to know what you're doing. Perhaps a warning during build would be reasonable. So if you ask for a bu

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-06 Thread Gabriel C
2018-07-06 18:33 GMT+02:00 Kirill A. Shutemov : > On Fri, Jul 06, 2018 at 04:39:28PM +0200, Gabriel C wrote: >> > If not, we do not need to think about that case. >> > Just say "Do not do that". >> >> I am sorry but I have a hard time to get your logic here. >> >> You are saying : the *env* variabl

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-06 Thread Kirill A. Shutemov
On Fri, Jul 06, 2018 at 04:39:28PM +0200, Gabriel C wrote: > > If not, we do not need to think about that case. > > Just say "Do not do that". > > I am sorry but I have a hard time to get your logic here. > > You are saying : the *env* variable LDFLAGS as well passing > LDFLAGS to make , which yo

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-06 Thread Kirill A. Shutemov
On Fri, Jul 06, 2018 at 11:13:02PM +0900, Masahiro Yamada wrote: > >> LDFLAGS is for internal-use. > >> Please do not override it from the command line. > > > > Can we generate a build error if a user try to override LDFLAGS, CFLAGS or > > other critical internal-use-only variables? > > Yes, Make

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-06 Thread Gabriel C
2018-07-06 16:13 GMT+02:00 Masahiro Yamada : > Hi. > > 2018-07-06 19:41 GMT+09:00 Kirill A. Shutemov : >> On Fri, Jul 06, 2018 at 03:37:58PM +0900, Masahiro Yamada wrote: >>> >> > > Also see https://bugzilla.kernel.org/show_bug.cgi?id=200385 , >>> >> > > >>> >> > > 0a1756bd2897951c03c1cb671bdfd4072

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-06 Thread Masahiro Yamada
Hi. 2018-07-06 19:41 GMT+09:00 Kirill A. Shutemov : > On Fri, Jul 06, 2018 at 03:37:58PM +0900, Masahiro Yamada wrote: >> >> > > Also see https://bugzilla.kernel.org/show_bug.cgi?id=200385 , >> >> > > >> >> > > 0a1756bd2897951c03c1cb671bdfd40729ac2177 is acting up >> >> > > too with the same sympt

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-06 Thread Kirill A. Shutemov
On Fri, Jul 06, 2018 at 03:37:58PM +0900, Masahiro Yamada wrote: > >> > > Also see https://bugzilla.kernel.org/show_bug.cgi?id=200385 , > >> > > > >> > > 0a1756bd2897951c03c1cb671bdfd40729ac2177 is acting up > >> > > too with the same symptoms > >> > > >> > I tracked it down to -flto in LDFLAGS. I'

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-05 Thread Masahiro Yamada
Hi. 2018-07-05 0:08 GMT+09:00 Kirill A. Shutemov : > On Tue, Jul 03, 2018 at 05:21:50PM +0300, Kirill A. Shutemov wrote: >> On Tue, Jul 03, 2018 at 03:44:03PM +0300, Kirill A. Shutemov wrote: >> > On Tue, Jul 03, 2018 at 01:24:49PM +0200, Gabriel C wrote: >> > > 2018-07-01 23:32 GMT+02:00 Benjami

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-04 Thread Benjamin Gilbert
On Wed, Jul 04, 2018 at 06:08:57PM +0300, Kirill A. Shutemov wrote: > On Tue, Jul 03, 2018 at 05:21:50PM +0300, Kirill A. Shutemov wrote: > > On Tue, Jul 03, 2018 at 03:44:03PM +0300, Kirill A. Shutemov wrote: > > > On Tue, Jul 03, 2018 at 01:24:49PM +0200, Gabriel C wrote: > > > > 2018-07-01 23:32

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-04 Thread Kirill A. Shutemov
On Tue, Jul 03, 2018 at 05:21:50PM +0300, Kirill A. Shutemov wrote: > On Tue, Jul 03, 2018 at 03:44:03PM +0300, Kirill A. Shutemov wrote: > > On Tue, Jul 03, 2018 at 01:24:49PM +0200, Gabriel C wrote: > > > 2018-07-01 23:32 GMT+02:00 Benjamin Gilbert : > > > > On Sun, Jul 01, 2018 at 05:15:59PM -04

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-04 Thread Kirill A. Shutemov
On Tue, Jul 03, 2018 at 11:10:27PM -0400, Benjamin Gilbert wrote: > On Tue, Jul 03, 2018 at 05:21:50PM +0300, Kirill A. Shutemov wrote: > > I don't know how to solve it. As far as I know we don't support compiling > > kernel with LTO in mainline. > > > > Any suggestions? > > > > Benjamin, do you

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-03 Thread Benjamin Gilbert
On Tue, Jul 03, 2018 at 05:21:50PM +0300, Kirill A. Shutemov wrote: > I don't know how to solve it. As far as I know we don't support compiling > kernel with LTO in mainline. > > Any suggestions? > > Benjamin, do you change LDFLAGS or CFLAGS when compiling the kernel? We're using the standard bu

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-03 Thread Andi Kleen
On Tue, Jul 03, 2018 at 11:26:09PM +0300, Kirill A. Shutemov wrote: > On Tue, Jul 03, 2018 at 11:03:07AM -0700, Andi Kleen wrote: > > On Tue, Jul 03, 2018 at 05:21:50PM +0300, Kirill A. Shutemov wrote: > > > On Tue, Jul 03, 2018 at 03:44:03PM +0300, Kirill A. Shutemov wrote: > > > > On Tue, Jul 03,

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-03 Thread Kirill A. Shutemov
On Tue, Jul 03, 2018 at 11:03:07AM -0700, Andi Kleen wrote: > On Tue, Jul 03, 2018 at 05:21:50PM +0300, Kirill A. Shutemov wrote: > > On Tue, Jul 03, 2018 at 03:44:03PM +0300, Kirill A. Shutemov wrote: > > > On Tue, Jul 03, 2018 at 01:24:49PM +0200, Gabriel C wrote: > > > > 2018-07-01 23:32 GMT+02:

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-03 Thread Andi Kleen
On Tue, Jul 03, 2018 at 05:21:50PM +0300, Kirill A. Shutemov wrote: > On Tue, Jul 03, 2018 at 03:44:03PM +0300, Kirill A. Shutemov wrote: > > On Tue, Jul 03, 2018 at 01:24:49PM +0200, Gabriel C wrote: > > > 2018-07-01 23:32 GMT+02:00 Benjamin Gilbert : > > > > On Sun, Jul 01, 2018 at 05:15:59PM -04

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-03 Thread Thomas Gleixner
On Tue, 3 Jul 2018, Kirill A. Shutemov wrote: > On Tue, Jul 03, 2018 at 03:44:03PM +0300, Kirill A. Shutemov wrote: > > On Tue, Jul 03, 2018 at 01:24:49PM +0200, Gabriel C wrote: > > > 2018-07-01 23:32 GMT+02:00 Benjamin Gilbert : > > > > On Sun, Jul 01, 2018 at 05:15:59PM -0400, Benjamin Gilbert w

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-03 Thread Kirill A. Shutemov
On Tue, Jul 03, 2018 at 03:44:03PM +0300, Kirill A. Shutemov wrote: > On Tue, Jul 03, 2018 at 01:24:49PM +0200, Gabriel C wrote: > > 2018-07-01 23:32 GMT+02:00 Benjamin Gilbert : > > > On Sun, Jul 01, 2018 at 05:15:59PM -0400, Benjamin Gilbert wrote: > > >> 4.17 kernels built with the CoreOS Contai

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-03 Thread Thomas Gleixner
On Tue, 3 Jul 2018, Bernhard Rosenkraenzer wrote: > On Tuesday, July 03, 2018 16:02 CEST, Thomas Gleixner > wrote: > > On Tue, 3 Jul 2018, Kirill A. Shutemov wrote: > > > On Tue, Jul 03, 2018 at 01:24:49PM +0200, Gabriel C wrote: > > > > 2018-07-01 23:32 GMT+02:00 Benjamin Gilbert : > > > > > On

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-03 Thread Bernhard Rosenkraenzer
On Tuesday, July 03, 2018 16:02 CEST, Thomas Gleixner wrote: > On Tue, 3 Jul 2018, Kirill A. Shutemov wrote: > > On Tue, Jul 03, 2018 at 01:24:49PM +0200, Gabriel C wrote: > > > 2018-07-01 23:32 GMT+02:00 Benjamin Gilbert : > > > > On Sun, Jul 01, 2018 at 05:15:59PM -0400, Benjamin Gilbert wrote

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-03 Thread Thomas Gleixner
On Tue, 3 Jul 2018, Kirill A. Shutemov wrote: > On Tue, Jul 03, 2018 at 01:24:49PM +0200, Gabriel C wrote: > > 2018-07-01 23:32 GMT+02:00 Benjamin Gilbert : > > > On Sun, Jul 01, 2018 at 05:15:59PM -0400, Benjamin Gilbert wrote: > > >> 4.17 kernels built with the CoreOS Container Linux toolchain an

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-03 Thread Kirill A. Shutemov
On Tue, Jul 03, 2018 at 01:24:49PM +0200, Gabriel C wrote: > 2018-07-01 23:32 GMT+02:00 Benjamin Gilbert : > > On Sun, Jul 01, 2018 at 05:15:59PM -0400, Benjamin Gilbert wrote: > >> 4.17 kernels built with the CoreOS Container Linux toolchain and kconfig, > >> up to and including 4.17.3, fail to bo

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-03 Thread Gabriel C
2018-07-01 23:32 GMT+02:00 Benjamin Gilbert : > On Sun, Jul 01, 2018 at 05:15:59PM -0400, Benjamin Gilbert wrote: >> 4.17 kernels built with the CoreOS Container Linux toolchain and kconfig, >> up to and including 4.17.3, fail to boot on AMD64 running in (at least) >> QEMU/KVM. No messages are sho

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-03 Thread Kirill A. Shutemov
On Tue, Jul 03, 2018 at 10:59:48AM +0200, Thomas Gleixner wrote: > On Tue, 3 Jul 2018, Kirill A. Shutemov wrote: > > > On Mon, Jul 02, 2018 at 07:01:28PM +, Benjamin Gilbert wrote: > > > On Mon, Jul 02, 2018 at 12:34:50PM +0300, Kirill A. Shutemov wrote: > > > > Could you check if you can trig

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-03 Thread Thomas Gleixner
On Tue, 3 Jul 2018, Kirill A. Shutemov wrote: > On Mon, Jul 02, 2018 at 07:01:28PM +, Benjamin Gilbert wrote: > > On Mon, Jul 02, 2018 at 12:34:50PM +0300, Kirill A. Shutemov wrote: > > > Could you check if you can trigger the issue with my changes to config and > > > the way I run KVM? > > >

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-03 Thread Kirill A. Shutemov
On Mon, Jul 02, 2018 at 07:01:28PM +, Benjamin Gilbert wrote: > On Mon, Jul 02, 2018 at 12:34:50PM +0300, Kirill A. Shutemov wrote: > > Could you check if you can trigger the issue with my changes to config and > > the way I run KVM? > > Yes, the issue still triggers in that case. I've also v

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-02 Thread Benjamin Gilbert
On Mon, Jul 02, 2018 at 12:34:50PM +0300, Kirill A. Shutemov wrote: > Could you check if you can trigger the issue with my changes to config and > the way I run KVM? Yes, the issue still triggers in that case. I've also verified that the kernel boots normally with your qemu command if the commit

Re: 4.17.x won't boot due to "x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G"

2018-07-01 Thread Benjamin Gilbert
On Sun, Jul 01, 2018 at 05:15:59PM -0400, Benjamin Gilbert wrote: > 4.17 kernels built with the CoreOS Container Linux toolchain and kconfig, > up to and including 4.17.3, fail to boot on AMD64 running in (at least) > QEMU/KVM. No messages are shown post-GRUB; the VM instantly reboots. > Rever