Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-12 Thread Saravana Kannan
I'm just going to combine my response to the 2-3 emails in this one response. On Tue, Jan 12, 2021 at 9:57 AM Thierry Reding wrote: > > On Mon, Jan 11, 2021 at 05:57:17PM +0100, Rafael J. Wysocki wrote: > > On Mon, Jan 11, 2021 at 5:12 PM Thierry Reding wrote: > > > > > > On Mon, Jan 11, 2021

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-12 Thread Thierry Reding
On Mon, Jan 11, 2021 at 05:57:17PM +0100, Rafael J. Wysocki wrote: > On Mon, Jan 11, 2021 at 5:12 PM Thierry Reding wrote: > > > > On Mon, Jan 11, 2021 at 03:57:37PM +0100, Rafael J. Wysocki wrote: > > > On Mon, Jan 11, 2021 at 2:43 PM Thierry Reding wrote: > > > > > > > > On Sun, Jan 10, 2021

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-12 Thread Thierry Reding
On Mon, Jan 11, 2021 at 02:44:03PM -0800, Saravana Kannan wrote: > On Mon, Jan 11, 2021 at 8:57 AM Rafael J. Wysocki wrote: > > > > On Mon, Jan 11, 2021 at 5:12 PM Thierry Reding wrote: > > > > > > On Mon, Jan 11, 2021 at 03:57:37PM +0100, Rafael J. Wysocki wrote: > > > > On Mon, Jan 11, 2021 at

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-12 Thread Rafael J. Wysocki
On Mon, Jan 11, 2021 at 11:44 PM Saravana Kannan wrote: > > On Mon, Jan 11, 2021 at 8:57 AM Rafael J. Wysocki wrote: > > > > On Mon, Jan 11, 2021 at 5:12 PM Thierry Reding wrote: > > > > > > On Mon, Jan 11, 2021 at 03:57:37PM +0100, Rafael J. Wysocki wrote: > > > > On Mon, Jan 11, 2021 at 2:43

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Hugh Dickins
On Mon, 11 Jan 2021, Saravana Kannan wrote: > On Mon, Jan 11, 2021 at 4:44 PM Hugh Dickins wrote: > > On Mon, 11 Jan 2021, Saravana Kannan wrote: > > > > > > Did you see this patch change the organization of devices under > > > /sys/devices/? > > > The rmi* devices need to be under one of the

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Saravana Kannan
On Mon, Jan 11, 2021 at 4:44 PM Hugh Dickins wrote: > > On Mon, 11 Jan 2021, Saravana Kannan wrote: > > On Mon, Jan 11, 2021 at 3:42 PM Hugh Dickins wrote: > > > On Mon, 11 Jan 2021, Saravana Kannan wrote: > > > > > > > > I happen to have an X1 Carbon (different gen though) lying around and > >

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Saravana Kannan
On Mon, Jan 11, 2021 at 8:57 AM Rafael J. Wysocki wrote: > > On Mon, Jan 11, 2021 at 5:12 PM Thierry Reding wrote: > > > > On Mon, Jan 11, 2021 at 03:57:37PM +0100, Rafael J. Wysocki wrote: > > > On Mon, Jan 11, 2021 at 2:43 PM Thierry Reding wrote: > > > > > > > > On Sun, Jan 10, 2021 at

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Hugh Dickins
On Mon, 11 Jan 2021, Saravana Kannan wrote: > On Mon, Jan 11, 2021 at 3:42 PM Hugh Dickins wrote: > > On Mon, 11 Jan 2021, Saravana Kannan wrote: > > > > > > I happen to have an X1 Carbon (different gen though) lying around and > > > I poked at its /sys folders. None of the devices in the

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Hugh Dickins
On Mon, 11 Jan 2021, Saravana Kannan wrote: > > I happen to have an X1 Carbon (different gen though) lying around and > I poked at its /sys folders. None of the devices in the rmi4_smbus are > considered the grandchildren of the i2c device. I think the real > problem is

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Saravana Kannan
On Mon, Jan 11, 2021 at 3:42 PM Hugh Dickins wrote: > > On Mon, 11 Jan 2021, Saravana Kannan wrote: > > > > I happen to have an X1 Carbon (different gen though) lying around and > > I poked at its /sys folders. None of the devices in the rmi4_smbus are > > considered the grandchildren of the i2c

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Hugh Dickins
On Mon, 11 Jan 2021, Thierry Reding wrote: > On Sun, Jan 10, 2021 at 08:44:13PM -0800, Hugh Dickins wrote: > > > > Synaptics RMI4 SMBus touchpad on ThinkPad X1 Carbon (5th generation) > > fails to suspend when running 5.11-rc kernels: bisected to > > 5b6164d3465f ("driver core: Reorder devices

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Hugh Dickins
On Mon, 11 Jan 2021, Rafael J. Wysocki wrote: > On Mon, Jan 11, 2021 at 5:44 AM Hugh Dickins wrote: > > > > Hi Rafael, > > > > Synaptics RMI4 SMBus touchpad on ThinkPad X1 Carbon (5th generation) > > fails to suspend when running 5.11-rc kernels: bisected to > > 5b6164d3465f ("driver core:

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Rafael J. Wysocki
On Mon, Jan 11, 2021 at 5:12 PM Thierry Reding wrote: > > On Mon, Jan 11, 2021 at 03:57:37PM +0100, Rafael J. Wysocki wrote: > > On Mon, Jan 11, 2021 at 2:43 PM Thierry Reding wrote: > > > > > > On Sun, Jan 10, 2021 at 08:44:13PM -0800, Hugh Dickins wrote: > > > > Hi Rafael, > > > > > > > >

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Thierry Reding
On Mon, Jan 11, 2021 at 03:57:37PM +0100, Rafael J. Wysocki wrote: > On Mon, Jan 11, 2021 at 2:43 PM Thierry Reding wrote: > > > > On Sun, Jan 10, 2021 at 08:44:13PM -0800, Hugh Dickins wrote: > > > Hi Rafael, > > > > > > Synaptics RMI4 SMBus touchpad on ThinkPad X1 Carbon (5th generation) > > >

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Rafael J. Wysocki
On Mon, Jan 11, 2021 at 2:43 PM Thierry Reding wrote: > > On Sun, Jan 10, 2021 at 08:44:13PM -0800, Hugh Dickins wrote: > > Hi Rafael, > > > > Synaptics RMI4 SMBus touchpad on ThinkPad X1 Carbon (5th generation) > > fails to suspend when running 5.11-rc kernels: bisected to > > 5b6164d3465f

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Rafael J. Wysocki
On Mon, Jan 11, 2021 at 2:43 PM Thierry Reding wrote: > > On Sun, Jan 10, 2021 at 08:44:13PM -0800, Hugh Dickins wrote: > > Hi Rafael, > > > > Synaptics RMI4 SMBus touchpad on ThinkPad X1 Carbon (5th generation) > > fails to suspend when running 5.11-rc kernels: bisected to > > 5b6164d3465f

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Thierry Reding
On Sun, Jan 10, 2021 at 08:44:13PM -0800, Hugh Dickins wrote: > Hi Rafael, > > Synaptics RMI4 SMBus touchpad on ThinkPad X1 Carbon (5th generation) > fails to suspend when running 5.11-rc kernels: bisected to > 5b6164d3465f ("driver core: Reorder devices on successful probe"), > and reverting

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Rafael J. Wysocki
Hi Hugh, Thanks for the report! On Mon, Jan 11, 2021 at 5:44 AM Hugh Dickins wrote: > > Hi Rafael, > > Synaptics RMI4 SMBus touchpad on ThinkPad X1 Carbon (5th generation) > fails to suspend when running 5.11-rc kernels: bisected to > 5b6164d3465f ("driver core: Reorder devices on successful

5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-10 Thread Hugh Dickins
Hi Rafael, Synaptics RMI4 SMBus touchpad on ThinkPad X1 Carbon (5th generation) fails to suspend when running 5.11-rc kernels: bisected to 5b6164d3465f ("driver core: Reorder devices on successful probe"), and reverting that fixes it. dmesg.xz attached, but go ahead and ask me to switch on a