Re: A patch to test_power module

2013-03-18 Thread Anton Vorontsov
On Sun, Feb 03, 2013 at 01:17:16PM +0200, Andrey Gelman wrote: [...] > >The patch looks good, but it is missing Signed-off-by tag. Plus, you > >should also Cc: linux-kernel@vger.kernel.org on submissions (I've added it > >now). > > > >Plus, please don't use html in emails. :) [...] > Fixed ... I th

Re: A patch to test_power module

2013-02-03 Thread Andrey Gelman
On 02/03/2013 05:39 AM, Anton Vorontsov wrote: On Sun, Jan 27, 2013 at 10:45:43PM +0200, Andrey Gelman wrote: Hello ! This patch fixes 2 issues in test_power module: 1. the mapping of ac_online parameter to its string value "on / off" was swapped. 2. more important ...

Re: A patch to test_power module

2013-02-02 Thread Anton Vorontsov
On Sun, Jan 27, 2013 at 10:45:43PM +0200, Andrey Gelman wrote: > Hello ! > This patch fixes 2 issues in test_power module: > 1. the mapping of ac_online parameter to its string value "on / off" > was swapped. > 2. more important ... > You could not insmod test_power with mod