Re: ACPI video mode patch review

2007-09-20 Thread Jeff Chua
On 9/20/07, Jiri Kosina <[EMAIL PROTECTED]> wrote: > On Thu, 20 Sep 2007, Jeff Chua wrote: > > With current -git, I still get the same behavior as with > previous 2.6.23-rcX kernels - i.e. after resume (with > acpi_sleep=s3_bios,s3_mode), I get corrupted image resembling the BIOS > POST graphics.

Re: ACPI video mode patch review

2007-09-20 Thread Jiri Kosina
On Thu, 20 Sep 2007, Jeff Chua wrote: > > With your patch applied, I get no video at all after resume (I tried all > > three possible combinations of acpi_sleep parameter). > Can you please try again with 2.6.23-rc7. The patch is already > included in -rc7 and it works for me on Lenono X60s. With

Re: ACPI video mode patch review

2007-09-20 Thread Jeff Chua
On 9/20/07, Jiri Kosina <[EMAIL PROTECTED]> wrote: > With your patch applied, I get no video at all after resume (I tried all > three possible combinations of acpi_sleep parameter). Can you please try again with 2.6.23-rc7. The patch is already included in -rc7 and it works for me on Lenono X60s.

Re: ACPI video mode patch review

2007-09-20 Thread Jiri Kosina
On Thu, 13 Sep 2007, H. Peter Anvin wrote: > Pavel, want to look at the patch before sending it to Linus? Hi, sorry for this taking too long, I was physically located away from the hardware. Without your patch, after resume I got corrupted image (looked like remains of BIOS POST graphics, in

Re: ACPI video mode patch review

2007-09-16 Thread Rafael J. Wysocki
On Sunday, 16 September 2007 22:59, Pavel Machek wrote: > Hi! > > > > Many thanks for taking care of this! > > > > > > We already have a patch in -mm, s2ram-kill-old-debugging-junk.patch from > > > Pavel > > > (http://marc.info/?l=linux-mm-commits&m=118737955611331&w=1), that > > > removes the

Re: ACPI video mode patch review

2007-09-16 Thread Pavel Machek
Hi! > > Many thanks for taking care of this! > > > > We already have a patch in -mm, s2ram-kill-old-debugging-junk.patch from > > Pavel > > (http://marc.info/?l=linux-mm-commits&m=118737955611331&w=1), that removes > > the > > #ifdefed blocks and it clashes with your first patch a bit. > > > >

Re: ACPI video mode patch review

2007-09-16 Thread H. Peter Anvin
Rafael J. Wysocki wrote: > On Thursday, 13 September 2007 23:37, H. Peter Anvin wrote: >> Pavel, want to look at the patch before sending it to Linus? > > Many thanks for taking care of this! > > We already have a patch in -mm, s2ram-kill-old-debugging-junk.patch from Pavel > (http://marc.info/?l

Re: ACPI video mode patch review

2007-09-16 Thread Rafael J. Wysocki
On Thursday, 13 September 2007 23:37, H. Peter Anvin wrote: > Pavel, want to look at the patch before sending it to Linus? Many thanks for taking care of this! We already have a patch in -mm, s2ram-kill-old-debugging-junk.patch from Pavel (http://marc.info/?l=linux-mm-commits&m=118737955611331&w=

Re: ACPI video mode patch review

2007-09-14 Thread Pavel Machek
Hi! > Pavel, want to look at the patch before sending it to Linus? Looks okay from a quick look. I'm on conference just now, will test shortly. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://

Re: ACPI video mode patch review

2007-09-13 Thread Jeff Chua
On 9/14/07, H. Peter Anvin <[EMAIL PROTECTED]> wrote: > Pavel, want to look at the patch before sending it to Linus? > > [acpi] Correct the decoding of video mode numbers in wakeup.S HPA, After a day, still works, no video mess-up after s2ram resume. I guess we can close this regression for -

ACPI video mode patch review

2007-09-13 Thread H. Peter Anvin
Pavel, want to look at the patch before sending it to Linus? --- THIS IS NOT (YET) A PULL REQUEST --- -hpa From: H. Peter Anvin <[EMAIL PROTECTED]> To: Linus Torvalds <[EMAIL PROTECTED]> Cc: Linux Kernel Mailing List Bcc: H. Peter Anvin <[EMAIL PROTECTED]> Subject: [GIT PULL] Fix