Re: ARC-setup: Use seq_putc() in show_cpuinfo()

2016-10-17 Thread SF Markus Elfring
>>> Perhaps reword the changelog to say that seqc_putc is more efficient than >>> seqc_printf to output a single char. >>> I mean _printf is not wrong but not as efficient ? >> I came along source files for a few other software modules with similar >> change possibilities. >> Unfortunately, the cor

Re: ARC-setup: Use seq_putc() in show_cpuinfo()

2016-10-17 Thread Vineet Gupta
On 10/17/2016 10:19 AM, SF Markus Elfring wrote: >>> A single character (line break) should be put into a sequence. >>> Thus use the corresponding function "seq_putc". >> Perhaps reword the changelog to say that seqc_putc is more efficient than >> seqc_printf to output a single char. >> I mean _pri

Re: ARC-setup: Use seq_putc() in show_cpuinfo()

2016-10-17 Thread SF Markus Elfring
>> A single character (line break) should be put into a sequence. >> Thus use the corresponding function "seq_putc". > > Perhaps reword the changelog to say that seqc_putc is more efficient than > seqc_printf to output a single char. > I mean _printf is not wrong but not as efficient ? I came alo

Re: [PATCH] ARC-setup: Use seq_putc() in show_cpuinfo()

2016-10-17 Thread Vineet Gupta
On 10/15/2016 12:56 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 15 Oct 2016 21:31:16 +0200 > > A single character (line break) should be put into a sequence. > Thus use the corresponding function "seq_putc". Perhaps reword the changelog to say that seqc_putc is more efficient

[PATCH] ARC-setup: Use seq_putc() in show_cpuinfo()

2016-10-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 15 Oct 2016 21:31:16 +0200 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/arc/kernel/setup.c | 3 +--