Re: ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-17 Thread Mark Rutland
On Mon, Oct 17, 2016 at 02:50:57PM +0200, SF Markus Elfring wrote: > > I prefer the code as-is. Unless there's a compelling reason to change it. > > Is the chance for faster log output interesting enough? Is there a particular user that cares today, or are we trying to work backwards to a

Re: ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-17 Thread Mark Rutland
On Mon, Oct 17, 2016 at 02:50:57PM +0200, SF Markus Elfring wrote: > > I prefer the code as-is. Unless there's a compelling reason to change it. > > Is the chance for faster log output interesting enough? Is there a particular user that cares today, or are we trying to work backwards to a

Re: ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-17 Thread SF Markus Elfring
> I prefer the code as-is. Unless there's a compelling reason to change it. Is the chance for faster log output interesting enough? Regards, Markus

Re: ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-17 Thread SF Markus Elfring
> I prefer the code as-is. Unless there's a compelling reason to change it. Is the chance for faster log output interesting enough? Regards, Markus

Re: ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-17 Thread Mark Rutland
On Mon, Oct 17, 2016 at 01:30:59PM +0200, SF Markus Elfring wrote: > >> Some data were printed into a sequence by six separate function calls. > >> Print the same data by a single function call instead. > > > > ... why? > > > > Beyond simply having fewer function calls, is there an upside? > >

Re: ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-17 Thread Mark Rutland
On Mon, Oct 17, 2016 at 01:30:59PM +0200, SF Markus Elfring wrote: > >> Some data were printed into a sequence by six separate function calls. > >> Print the same data by a single function call instead. > > > > ... why? > > > > Beyond simply having fewer function calls, is there an upside? > >

Re: ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-17 Thread SF Markus Elfring
>> Some data were printed into a sequence by six separate function calls. >> Print the same data by a single function call instead. > > ... why? > > Beyond simply having fewer function calls, is there an upside? Will it matter to improve run time characteristics at this source code place? >

Re: ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-17 Thread SF Markus Elfring
>> Some data were printed into a sequence by six separate function calls. >> Print the same data by a single function call instead. > > ... why? > > Beyond simply having fewer function calls, is there an upside? Will it matter to improve run time characteristics at this source code place? >

Re: [PATCH] ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-17 Thread Mark Rutland
On Sun, Oct 16, 2016 at 09:03:52PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 16 Oct 2016 20:48:28 +0200 > > Some data were printed into a sequence by six separate function calls. > Print the same data by a single function call instead.

Re: [PATCH] ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-17 Thread Mark Rutland
On Sun, Oct 16, 2016 at 09:03:52PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 16 Oct 2016 20:48:28 +0200 > > Some data were printed into a sequence by six separate function calls. > Print the same data by a single function call instead. ... why? Beyond simply having

Re: [PATCH] ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-17 Thread Matthias Brugger
On 16/10/16 21:03, SF Markus Elfring wrote: From: Markus Elfring Date: Sun, 16 Oct 2016 20:48:28 +0200 Some data were printed into a sequence by six separate function calls. Print the same data by a single function call instead. Signed-off-by: Markus Elfring

Re: [PATCH] ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-17 Thread Matthias Brugger
On 16/10/16 21:03, SF Markus Elfring wrote: From: Markus Elfring Date: Sun, 16 Oct 2016 20:48:28 +0200 Some data were printed into a sequence by six separate function calls. Print the same data by a single function call instead. Signed-off-by: Markus Elfring --- Reviewed-by: Matthias

[PATCH] ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 16 Oct 2016 20:48:28 +0200 Some data were printed into a sequence by six separate function calls. Print the same data by a single function call instead. Signed-off-by: Markus Elfring ---

[PATCH] ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 16 Oct 2016 20:48:28 +0200 Some data were printed into a sequence by six separate function calls. Print the same data by a single function call instead. Signed-off-by: Markus Elfring --- arch/arm64/kernel/cpuinfo.c | 19 +++ 1 file changed, 11