Re: About [PATCH 1/2] regulator: core: Provide a dummy regulator with full constraints

2013-10-17 Thread Wei Ni
On 10/17/2013 05:37 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Thu, Oct 17, 2013 at 12:39:55PM +0800, Wei Ni wrote: > >> So do you mean it should call the regulator_has_full_constraints() in >> the .init_machine for all machines? If so, this will affect all boards, >> for examp

Re: About [PATCH 1/2] regulator: core: Provide a dummy regulator with full constraints

2013-10-17 Thread Mark Brown
On Thu, Oct 17, 2013 at 12:39:55PM +0800, Wei Ni wrote: > So do you mean it should call the regulator_has_full_constraints() in > the .init_machine for all machines? If so, this will affect all boards, > for example, in arch/arm/mach-tegra, if we set full constraints in the > shared board file teg

Re: About [PATCH 1/2] regulator: core: Provide a dummy regulator with full constraints

2013-10-16 Thread Wei Ni
On 10/16/2013 06:39 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Wed, Oct 16, 2013 at 12:36:46PM +0800, Wei Ni wrote: >> On 10/12/2013 08:14 PM, Mark Brown wrote: > >>> OK, I think the device tree board code just needs to set full >>> constraints during machine initialisation. W

Re: About [PATCH 1/2] regulator: core: Provide a dummy regulator with full constraints

2013-10-16 Thread Mark Brown
On Wed, Oct 16, 2013 at 12:36:46PM +0800, Wei Ni wrote: > On 10/12/2013 08:14 PM, Mark Brown wrote: > > OK, I think the device tree board code just needs to set full > > constraints during machine initialisation. We can't have multiple > Hi, Mark, do you mean we can call regulator_has_full_const

Re: About [PATCH 1/2] regulator: core: Provide a dummy regulator with full constraints

2013-10-15 Thread Wei Ni
On 10/12/2013 08:14 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Tue, Oct 08, 2013 at 05:46:49PM +0800, Wei Ni wrote: > >> In the regulator_dev_lookup(), it will try to read the "xx-supply" to >> get the regnode, but I didn't set the vcc-supply in dts file for lm90, >> so the of_

Re: About [PATCH 1/2] regulator: core: Provide a dummy regulator with full constraints

2013-10-12 Thread Mark Brown
On Tue, Oct 08, 2013 at 05:46:49PM +0800, Wei Ni wrote: > In the regulator_dev_lookup(), it will try to read the "xx-supply" to > get the regnode, but I didn't set the vcc-supply in dts file for lm90, > so the of_get_regulator() will return NULL, then the > regulator_dev_lookup() will set the ret

Re: About [PATCH 1/2] regulator: core: Provide a dummy regulator with full constraints

2013-10-08 Thread Wei Ni
On 10/08/2013 05:09 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Tue, Oct 08, 2013 at 02:09:02PM +0800, Wei Ni wrote: > >> In the latest regulator framework, it default to provide dummy >> regulators with full constraints by your patch "regulator: core: Provide >> a dummy regulat

Re: About [PATCH 1/2] regulator: core: Provide a dummy regulator with full constraints

2013-10-08 Thread Mark Brown
On Tue, Oct 08, 2013 at 02:09:02PM +0800, Wei Ni wrote: > In the latest regulator framework, it default to provide dummy > regulators with full constraints by your patch "regulator: core: Provide > a dummy regulator with full constraints". > I tried to use regulator_get() on lm90.c. If not set vc

About [PATCH 1/2] regulator: core: Provide a dummy regulator with full constraints

2013-10-07 Thread Wei Ni
Hi, Mark In the latest regulator framework, it default to provide dummy regulators with full constraints by your patch "regulator: core: Provide a dummy regulator with full constraints". I tried to use regulator_get() on lm90.c. If not set vcc-supply property in the dts file to assume the regulator