Re: Add top down metrics to perf stat v2

2015-12-18 Thread Andi Kleen
On Fri, Dec 18, 2015 at 01:31:18AM -0800, Stephane Eranian wrote: > >> Why force --per-core when HT is on. I know you you need to aggregate > >> per core, but > >> you could still display globally. And then if user requests > >> --per-core, then display per core. > > > > Global TopDown doesn't make

Re: Add top down metrics to perf stat v2

2015-12-18 Thread Stephane Eranian
Andi, On Thu, Dec 17, 2015 at 5:55 PM, Andi Kleen wrote: > Thanks for testing. > > > On Thu, Dec 17, 2015 at 03:31:30PM -0800, Stephane Eranian wrote: >> I would not add a --topdown option but instead a --metric option with >> arguments >> such that other metrics could be added later: >> >>$

Re: Add top down metrics to perf stat v2

2015-12-17 Thread Andi Kleen
Thanks for testing. On Thu, Dec 17, 2015 at 03:31:30PM -0800, Stephane Eranian wrote: > I would not add a --topdown option but instead a --metric option with > arguments > such that other metrics could be added later: > >$ perf stat --metrics topdown -I 1000 -a sleep 100 > > If you do this

Re: Add top down metrics to perf stat v2

2015-12-17 Thread Stephane Eranian
On Thu, Dec 17, 2015 at 6:01 AM, Andi Kleen wrote: > On Thu, Dec 17, 2015 at 02:27:58AM -0800, Stephane Eranian wrote: >> > S0-C1 2 4175583320.00 topdown-slots-retired >> > (100.00%) >> > S0-C1 2 1743329246 topdown

Re: Add top down metrics to perf stat v2

2015-12-17 Thread Andi Kleen
On Thu, Dec 17, 2015 at 02:27:58AM -0800, Stephane Eranian wrote: > > S0-C1 2 4175583320.00 topdown-slots-retired > > (100.00%) > > S0-C1 2 1743329246 topdown-recovery-bubbles # > > 22.22% bad speculation

Re: Add top down metrics to perf stat v2

2015-12-17 Thread Stephane Eranian
Andi, On Tue, Dec 15, 2015 at 4:54 PM, Andi Kleen wrote: > Note to reviewers: includes both tools and kernel patches. > The kernel patches are at the end. > > This patchkit adds support for TopDown measurements to perf stat > It applies on top of my earlier metrics patchkit, posted > separately,

Add top down metrics to perf stat v2

2015-12-15 Thread Andi Kleen
Note to reviewers: includes both tools and kernel patches. The kernel patches are at the end. This patchkit adds support for TopDown measurements to perf stat It applies on top of my earlier metrics patchkit, posted separately, and the --metric-only patchkit (also posted separately) TopDown is in