Re: Allow (O=...) from file

2007-12-08 Thread Jay Cliburn
On Sat, 8 Dec 2007 21:14:09 +0100 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > Jay - can I ask you to try out following patch. Hello Sam, Yes, your patch works for me. Thank you very much. > diff --git a/Makefile b/Makefile > index a5252f4..7fb1a2c 100644 > --- a/Makefile > +++ b/Makefile > @@

Re: Allow (O=...) from file

2007-12-08 Thread Sam Ravnborg
On Wed, Dec 05, 2007 at 09:31:26PM -0600, Jay Cliburn wrote: > On Wed, 5 Dec 2007 22:00:03 +0100 > Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > On Tue, Dec 04, 2007 at 09:04:33PM -0600, Jay Cliburn wrote: > > > Sam, > > > > > > This piece of the top-level Makefile in current git causes an > > >

Re: Allow (O=...) from file

2007-12-08 Thread Sam Ravnborg
On Wed, Dec 05, 2007 at 09:31:26PM -0600, Jay Cliburn wrote: On Wed, 5 Dec 2007 22:00:03 +0100 Sam Ravnborg [EMAIL PROTECTED] wrote: On Tue, Dec 04, 2007 at 09:04:33PM -0600, Jay Cliburn wrote: Sam, This piece of the top-level Makefile in current git causes an out-of-tree driver

Re: Allow (O=...) from file

2007-12-08 Thread Jay Cliburn
On Sat, 8 Dec 2007 21:14:09 +0100 Sam Ravnborg [EMAIL PROTECTED] wrote: Jay - can I ask you to try out following patch. Hello Sam, Yes, your patch works for me. Thank you very much. diff --git a/Makefile b/Makefile index a5252f4..7fb1a2c 100644 --- a/Makefile +++ b/Makefile @@ -118,9

Re: Allow (O=...) from file

2007-12-06 Thread Jay Cliburn
On Thu, 6 Dec 2007 15:57:38 +0100 (CET) Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > On Dec 4 2007 21:04, Jay Cliburn wrote: > > > >This piece of the top-level Makefile in current git causes an > >out-of-tree driver Makefile to fail. > > > >101 ifdef O > >102 ifeq ("$(origin O)", "command

Re: Allow (O=...) from file

2007-12-06 Thread Sam Ravnborg
On Wed, Dec 05, 2007 at 09:31:26PM -0600, Jay Cliburn wrote: > On Wed, 5 Dec 2007 22:00:03 +0100 > Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > On Tue, Dec 04, 2007 at 09:04:33PM -0600, Jay Cliburn wrote: > > > Sam, > > > > > > This piece of the top-level Makefile in current git causes an > > >

Re: Allow (O=...) from file

2007-12-06 Thread Jan Engelhardt
On Dec 4 2007 21:04, Jay Cliburn wrote: > >This piece of the top-level Makefile in current git causes an >out-of-tree driver Makefile to fail. > >101 ifdef O >102 ifeq ("$(origin O)", "command line") >103 KBUILD_OUTPUT := $(O) >104 endif >105 endif Should not it just use the usual

Re: Allow (O=...) from file

2007-12-06 Thread Jan Engelhardt
On Dec 4 2007 21:04, Jay Cliburn wrote: This piece of the top-level Makefile in current git causes an out-of-tree driver Makefile to fail. 101 ifdef O 102 ifeq ($(origin O), command line) 103 KBUILD_OUTPUT := $(O) 104 endif 105 endif Should not it just use the usual boilerplate? kdir

Re: Allow (O=...) from file

2007-12-06 Thread Sam Ravnborg
On Wed, Dec 05, 2007 at 09:31:26PM -0600, Jay Cliburn wrote: On Wed, 5 Dec 2007 22:00:03 +0100 Sam Ravnborg [EMAIL PROTECTED] wrote: On Tue, Dec 04, 2007 at 09:04:33PM -0600, Jay Cliburn wrote: Sam, This piece of the top-level Makefile in current git causes an out-of-tree driver

Re: Allow (O=...) from file

2007-12-06 Thread Jay Cliburn
On Thu, 6 Dec 2007 15:57:38 +0100 (CET) Jan Engelhardt [EMAIL PROTECTED] wrote: On Dec 4 2007 21:04, Jay Cliburn wrote: This piece of the top-level Makefile in current git causes an out-of-tree driver Makefile to fail. 101 ifdef O 102 ifeq ($(origin O), command line) 103

Re: Allow (O=...) from file

2007-12-05 Thread Jay Cliburn
On Wed, 5 Dec 2007 22:00:03 +0100 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > On Tue, Dec 04, 2007 at 09:04:33PM -0600, Jay Cliburn wrote: > > Sam, > > > > This piece of the top-level Makefile in current git causes an > > out-of-tree driver Makefile to fail. > > > > 101 ifdef O > > 102 ifeq

Re: Allow (O=...) from file

2007-12-05 Thread Erik Mouw
On Wed, Dec 05, 2007 at 10:37:03PM +0100, Erik Mouw wrote: > Here's a clue: when I build with ARCH=x86, I get some warnings, but the > targz-pkg builds succesfully: > > [EMAIL PROTECTED]:~/git/linux-2.6 > make ARCH=x86 allnoconfig > [...] > [EMAIL PROTECTED]:~/git/linux-2.6 > make ARCH=x86

Re: Allow (O=...) from file

2007-12-05 Thread Erik Mouw
On Wed, Dec 05, 2007 at 10:00:03PM +0100, Sam Ravnborg wrote: > On Tue, Dec 04, 2007 at 09:04:33PM -0600, Jay Cliburn wrote: > > Sam, > > > > This piece of the top-level Makefile in current git causes an > > out-of-tree driver Makefile to fail. > > > > 101 ifdef O > > 102 ifeq ("$(origin O)",

Re: Allow (O=...) from file

2007-12-05 Thread Sam Ravnborg
On Tue, Dec 04, 2007 at 09:04:33PM -0600, Jay Cliburn wrote: > Sam, > > This piece of the top-level Makefile in current git causes an > out-of-tree driver Makefile to fail. > > 101 ifdef O > 102 ifeq ("$(origin O)", "command line") > 103 KBUILD_OUTPUT := $(O) > 104 endif > 105 endif > >

Re: Allow (O=...) from file

2007-12-05 Thread Erik Mouw
On Tue, Dec 04, 2007 at 09:04:33PM -0600, Jay Cliburn wrote: > Sam, > > This piece of the top-level Makefile in current git causes an > out-of-tree driver Makefile to fail. > > 101 ifdef O > 102 ifeq ("$(origin O)", "command line") > 103 KBUILD_OUTPUT := $(O) > 104 endif > 105 endif > >

Re: Allow (O=...) from file

2007-12-05 Thread Erik Mouw
On Tue, Dec 04, 2007 at 09:04:33PM -0600, Jay Cliburn wrote: Sam, This piece of the top-level Makefile in current git causes an out-of-tree driver Makefile to fail. 101 ifdef O 102 ifeq ($(origin O), command line) 103 KBUILD_OUTPUT := $(O) 104 endif 105 endif The out-of-tree

Re: Allow (O=...) from file

2007-12-05 Thread Sam Ravnborg
On Tue, Dec 04, 2007 at 09:04:33PM -0600, Jay Cliburn wrote: Sam, This piece of the top-level Makefile in current git causes an out-of-tree driver Makefile to fail. 101 ifdef O 102 ifeq ($(origin O), command line) 103 KBUILD_OUTPUT := $(O) 104 endif 105 endif The out-of-tree

Re: Allow (O=...) from file

2007-12-05 Thread Erik Mouw
On Wed, Dec 05, 2007 at 10:00:03PM +0100, Sam Ravnborg wrote: On Tue, Dec 04, 2007 at 09:04:33PM -0600, Jay Cliburn wrote: Sam, This piece of the top-level Makefile in current git causes an out-of-tree driver Makefile to fail. 101 ifdef O 102 ifeq ($(origin O), command line)

Re: Allow (O=...) from file

2007-12-05 Thread Erik Mouw
On Wed, Dec 05, 2007 at 10:37:03PM +0100, Erik Mouw wrote: Here's a clue: when I build with ARCH=x86, I get some warnings, but the targz-pkg builds succesfully: [EMAIL PROTECTED]:~/git/linux-2.6 make ARCH=x86 allnoconfig [...] [EMAIL PROTECTED]:~/git/linux-2.6 make ARCH=x86 targz-pkg

Re: Allow (O=...) from file

2007-12-05 Thread Jay Cliburn
On Wed, 5 Dec 2007 22:00:03 +0100 Sam Ravnborg [EMAIL PROTECTED] wrote: On Tue, Dec 04, 2007 at 09:04:33PM -0600, Jay Cliburn wrote: Sam, This piece of the top-level Makefile in current git causes an out-of-tree driver Makefile to fail. 101 ifdef O 102 ifeq ($(origin O),

Allow (O=...) from file

2007-12-04 Thread Jay Cliburn
Sam, This piece of the top-level Makefile in current git causes an out-of-tree driver Makefile to fail. 101 ifdef O 102 ifeq ("$(origin O)", "command line") 103 KBUILD_OUTPUT := $(O) 104 endif 105 endif The out-of-tree driver Makefile contains an O=... directive that (correctly) does

Allow (O=...) from file

2007-12-04 Thread Jay Cliburn
Sam, This piece of the top-level Makefile in current git causes an out-of-tree driver Makefile to fail. 101 ifdef O 102 ifeq ($(origin O), command line) 103 KBUILD_OUTPUT := $(O) 104 endif 105 endif The out-of-tree driver Makefile contains an O=... directive that (correctly) does _not_