Re: Announce: cryptoapi-2.4.3 [aka international crypto (non-)patch]

2001-04-26 Thread Jari Ruusu
Herbert Valerio Riedel wrote: > do you have any objections about... > > unsigned long IV = loop_get_iv(lo, >page->index * (PAGE_CACHE_SIZE >> LO_IV_SECTOR_BITS) >+ (offset >> LO_IV_SECTOR_BITS) >- (lo->lo_offset >> LO_IV_SECTOR_BITS)); > > ...then? ;-) Looks fine. > > Have you

Re: Announce: cryptoapi-2.4.3 [aka international crypto (non-)patch]

2001-04-26 Thread Herbert Valerio Riedel
hello! On Thu, 26 Apr 2001, Jari Ruusu wrote: > Herbert Valerio Riedel wrote: > > On Tue, 24 Apr 2001, Jari Ruusu wrote: > > it should have been more or less: > > > > unsigned long IV = loop_get_iv(lo, > > page->index * (PAGE_CACHE_SIZE >> LO_IV_SECTOR_BITS) > > + (offset - lo->lo_offset) >>

Re: Announce: cryptoapi-2.4.3 [aka international crypto (non-)patch]

2001-04-26 Thread Jari Ruusu
Herbert Valerio Riedel wrote: > On Tue, 24 Apr 2001, Jari Ruusu wrote: > > Have you tested that code with partitions or files that are larger than > > 4 gigs? On systems where int is 32 bits, that computation overflows. > you're right, I actually had it right in the first place, but stupidly >

Re: Announce: cryptoapi-2.4.3 [aka international crypto (non-)patch]

2001-04-26 Thread Jari Ruusu
Herbert Valerio Riedel wrote: On Tue, 24 Apr 2001, Jari Ruusu wrote: Have you tested that code with partitions or files that are larger than 4 gigs? On systems where int is 32 bits, that computation overflows. you're right, I actually had it right in the first place, but stupidly rewrote

Re: Announce: cryptoapi-2.4.3 [aka international crypto (non-)patch]

2001-04-26 Thread Herbert Valerio Riedel
hello! On Thu, 26 Apr 2001, Jari Ruusu wrote: Herbert Valerio Riedel wrote: On Tue, 24 Apr 2001, Jari Ruusu wrote: it should have been more or less: unsigned long IV = loop_get_iv(lo, page-index * (PAGE_CACHE_SIZE LO_IV_SECTOR_BITS) + (offset - lo-lo_offset)

Re: Announce: cryptoapi-2.4.3 [aka international crypto (non-)patch]

2001-04-26 Thread Jari Ruusu
Herbert Valerio Riedel wrote: do you have any objections about... unsigned long IV = loop_get_iv(lo, page-index * (PAGE_CACHE_SIZE LO_IV_SECTOR_BITS) + (offset LO_IV_SECTOR_BITS) - (lo-lo_offset LO_IV_SECTOR_BITS)); ...then? ;-) Looks fine. Have you ever observed the

Re: Announce: cryptoapi-2.4.3 [aka international crypto (non-)patch]

2001-04-25 Thread Herbert Valerio Riedel
hi, On Tue, 24 Apr 2001, Jari Ruusu wrote: > linux-2.4.3-cryptoapi-hvr4/drivers/block/loop.c lines 270...279 after your > kernel patch: > > static int lo_read_actor(read_descriptor_t * desc, struct page *page, unsigned long >offset, unsigned long size) > { > char *kaddr; > unsigned

Re: Announce: cryptoapi-2.4.3 [aka international crypto (non-)patch]

2001-04-25 Thread Herbert Valerio Riedel
hi, On Tue, 24 Apr 2001, Jari Ruusu wrote: linux-2.4.3-cryptoapi-hvr4/drivers/block/loop.c lines 270...279 after your kernel patch: static int lo_read_actor(read_descriptor_t * desc, struct page *page, unsigned long offset, unsigned long size) { char *kaddr; unsigned long

Re: Announce: cryptoapi-2.4.3 [aka international crypto (non-)patch]

2001-04-24 Thread Jari Ruusu
Herbert Valerio Riedel wrote: > short version: >this is the international crypto patch, which is built outside of >the kernel source tree. you don't even have to reboot (unless your >kernel didn't have loop devices enabled, or some other unthought >situation exists... :) > > As a

Re: Announce: cryptoapi-2.4.3 [aka international crypto (non-)patch]

2001-04-24 Thread Jari Ruusu
Herbert Valerio Riedel wrote: short version: this is the international crypto patch, which is built outside of the kernel source tree. you don't even have to reboot (unless your kernel didn't have loop devices enabled, or some other unthought situation exists... :) As a

Announce: cryptoapi-2.4.3 [aka international crypto (non-)patch]

2001-04-23 Thread Herbert Valerio Riedel
hello! short version: this is the international crypto patch, which is built outside of the kernel source tree. you don't even have to reboot (unless your kernel didn't have loop devices enabled, or some other unthought situation exists... :) As a response to Jari's loop-AES crypto

Announce: cryptoapi-2.4.3 [aka international crypto (non-)patch]

2001-04-23 Thread Herbert Valerio Riedel
hello! short version: this is the international crypto patch, which is built outside of the kernel source tree. you don't even have to reboot (unless your kernel didn't have loop devices enabled, or some other unthought situation exists... :) As a response to Jari's loop-AES crypto