Re: Aw: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-06 Thread Marc Zyngier
On 2020-11-05 23:00, Thomas Gleixner wrote: On Thu, Nov 05 2020 at 09:20, Marc Zyngier wrote: On 2020-11-04 23:14, Thomas Gleixner wrote: /* Resource alignment requirements */ resource_size_t (*align_resource)(struct pci_dev *dev, If that's the direction of travel, we also

Re: Aw: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-05 Thread Thomas Gleixner
On Thu, Nov 05 2020 at 09:20, Marc Zyngier wrote: > On 2020-11-04 23:14, Thomas Gleixner wrote: >> /* Resource alignment requirements */ >> resource_size_t (*align_resource)(struct pci_dev *dev, > > If that's the direction of travel, we also need something like this > for configuration

Re: Aw: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-05 Thread Marc Zyngier
On 2020-11-04 23:14, Thomas Gleixner wrote: [...] TBH, that's butt ugly. So after staring long enough into the PCI code I came up with a way to transport that information to the probe code. That allows a particular device to say 'I can't do MSI' and at the same time keeps the warning

Re: Aw: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-04 Thread Thomas Gleixner
Frank, On Wed, Nov 04 2020 at 17:49, Frank Wunderlich wrote: >> Von: "Thomas Gleixner" >> Any architecture which selects PCI_MSI_ARCH_FALLBACKS and does not have >> irqdomain support runs into: >> >> if (!d) >> bus->bus_flags |= PCI_BUS_FLAGS_NO_MSI; >> >> which in turn makes

Aw: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-04 Thread Frank Wunderlich
> Gesendet: Dienstag, 03. November 2020 um 11:16 Uhr > Von: "Thomas Gleixner" > Any architecture which selects PCI_MSI_ARCH_FALLBACKS and does not have > irqdomain support runs into: > > if (!d) > bus->bus_flags |= PCI_BUS_FLAGS_NO_MSI; > > which in turn makes

Re: Aw: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-02 Thread Marc Zyngier
On 2020-11-02 11:56, Frank Wunderlich wrote: looks good on bananapi-r2, no warning, pcie-card and hdd recognized Thanks for giving it a shot. Still needs a bit of tweaking, as I expect it to break configurations that select CONFIG_PCI_MSI_ARCH_FALLBACKS (we have to assume that MSIs can be

Aw: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-02 Thread Frank Wunderlich
looks good on bananapi-r2, no warning, pcie-card and hdd recognized regards Frank > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 4289030b0fff..bb363eb103a2 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -871,6 +871,8 @@ static void