Re: BPF vs objtool again

2020-04-29 Thread Josh Poimboeuf
On Wed, Apr 29, 2020 at 09:24:00PM -0700, Alexei Starovoitov wrote: > > This would actually be contingent on RETPOLINE, not FRAME_POINTER. > > > > (FRAME_POINTER was the other issue with the "optimize" attribute, which > > we're reverting so it'll no longer be a problem.) > > > > So if you're

Re: BPF vs objtool again

2020-04-29 Thread Alexei Starovoitov
On Wed, Apr 29, 2020 at 10:53:15PM -0500, Josh Poimboeuf wrote: > On Wed, Apr 29, 2020 at 07:10:52PM -0700, Alexei Starovoitov wrote: > > > For example: > > > > > > #define GOTO({ goto *jumptable[insn->code]; }) > > > > > > and then replace all 'goto select_insn' with 'GOTO;' > > > > > >

Re: BPF vs objtool again

2020-04-29 Thread Josh Poimboeuf
On Wed, Apr 29, 2020 at 07:10:52PM -0700, Alexei Starovoitov wrote: > > For example: > > > > #define GOTO({ goto *jumptable[insn->code]; }) > > > > and then replace all 'goto select_insn' with 'GOTO;' > > > > The problem is that with RETPOLINE=y, the function text size grows from > > 5k to

Re: BPF vs objtool again

2020-04-29 Thread Alexei Starovoitov
On Wed, Apr 29, 2020 at 07:13:00PM -0500, Josh Poimboeuf wrote: > On Wed, Apr 29, 2020 at 04:41:59PM -0700, Alexei Starovoitov wrote: > > On Wed, Apr 29, 2020 at 04:51:59PM -0500, Josh Poimboeuf wrote: > > > On Thu, Jul 18, 2019 at 12:14:08PM -0700, tip-bot for Josh Poimboeuf > > > wrote: > > > >

Re: BPF vs objtool again

2020-04-29 Thread Josh Poimboeuf
On Wed, Apr 29, 2020 at 04:41:59PM -0700, Alexei Starovoitov wrote: > On Wed, Apr 29, 2020 at 04:51:59PM -0500, Josh Poimboeuf wrote: > > On Thu, Jul 18, 2019 at 12:14:08PM -0700, tip-bot for Josh Poimboeuf wrote: > > > Commit-ID: 3193c0836f203a91bef96d88c64cccf0be090d9c > > > Gitweb: > > >

Re: BPF vs objtool again

2020-04-29 Thread Alexei Starovoitov
On Wed, Apr 29, 2020 at 04:51:59PM -0500, Josh Poimboeuf wrote: > On Thu, Jul 18, 2019 at 12:14:08PM -0700, tip-bot for Josh Poimboeuf wrote: > > Commit-ID: 3193c0836f203a91bef96d88c64cccf0be090d9c > > Gitweb: > > https://git.kernel.org/tip/3193c0836f203a91bef96d88c64cccf0be090d9c > >

Re: BPF vs objtool again

2020-04-29 Thread Arvind Sankar
On Wed, Apr 29, 2020 at 04:51:59PM -0500, Josh Poimboeuf wrote: > On Thu, Jul 18, 2019 at 12:14:08PM -0700, tip-bot for Josh Poimboeuf wrote: > > Commit-ID: 3193c0836f203a91bef96d88c64cccf0be090d9c > > Gitweb: > > https://git.kernel.org/tip/3193c0836f203a91bef96d88c64cccf0be090d9c > >

BPF vs objtool again

2020-04-29 Thread Josh Poimboeuf
On Thu, Jul 18, 2019 at 12:14:08PM -0700, tip-bot for Josh Poimboeuf wrote: > Commit-ID: 3193c0836f203a91bef96d88c64cccf0be090d9c > Gitweb: > https://git.kernel.org/tip/3193c0836f203a91bef96d88c64cccf0be090d9c > Author: Josh Poimboeuf > AuthorDate: Wed, 17 Jul 2019 20:36:45 -0500 >