Re: BUG: MAX_LOCKDEP_KEYS too low!

2021-01-23 Thread Tetsuo Handa
() returns 0 due to debug_locks being changed from 1 to 0 by __debug_locks_off() from debug_locks_off() from debug_locks_off_graph_unlock(), lock-classes value in /proc/lockdep_stats will not decrease after "BUG: MAX_LOCKDEP_KEYS too low!" is printed.

Re: BUG: MAX_LOCKDEP_KEYS too low!

2021-01-23 Thread Alexey Kardashevskiy
On 23/01/2021 21:29, Tetsuo Handa wrote: On 2021/01/23 15:35, Alexey Kardashevskiy wrote: this behaves quite different but still produces the message (i have show_workqueue_state() right after the bug message): [   85.803991] BUG: MAX_LOCKDEP_KEYS too low! [   85.804338] turning off the

Re: BUG: MAX_LOCKDEP_KEYS too low!

2021-01-23 Thread Tetsuo Handa
On 2021/01/23 15:35, Alexey Kardashevskiy wrote: > this behaves quite different but still produces the message (i have > show_workqueue_state() right after the bug message): > > > [   85.803991] BUG: MAX_LOCKDEP_KEYS too low! > [   85.804338] turning off the locking cor

Re: BUG: MAX_LOCKDEP_KEYS too low!

2021-01-22 Thread Alexey Kardashevskiy
cking/lockdep.c @@ -1277,6 +1277,7 @@ register_lock_class(struct lockdep_map *lock, unsigned int subclass, int force) print_lockdep_off("BUG: MAX_LOCKDEP_KEYS too low!"); dump_stack(); + show_workqueue_state();

Re: BUG: MAX_LOCKDEP_KEYS too low!

2021-01-22 Thread Alexey Kardashevskiy
force) print_lockdep_off("BUG: MAX_LOCKDEP_KEYS too low!"); dump_stack(); + show_workqueue_state(); return NULL; } nr_lock_classes++; Here is the result: https://pastebin.com/rPn0Cytu Do you mi

Re: BUG: MAX_LOCKDEP_KEYS too low!

2021-01-22 Thread Dmitry Vyukov
On Fri, Jan 22, 2021 at 4:43 AM Alexey Kardashevskiy wrote: > > Hi! > > Syzkaller found this bug and it has a repro (below). I googled a similar > bug in 2019 which was fixed so this seems new. > > The repro takes about a half a minute to produce the message, "grep > lock-classes /proc/lockdep_st

BUG: MAX_LOCKDEP_KEYS too low!

2021-01-21 Thread Alexey Kardashevskiy
Hi! Syzkaller found this bug and it has a repro (below). I googled a similar bug in 2019 which was fixed so this seems new. The repro takes about a half a minute to produce the message, "grep lock-classes /proc/lockdep_stats" reports 8177 of 8192, before running the repro it is 702. It is a

Re: BUG: MAX_LOCKDEP_KEYS too low!

2020-12-09 Thread Dmitry Vyukov
#syz fix: net: partially revert dynamic lockdep key changes > BUG: MAX_LOCKDEP_KEYS too low! > turning off the locking correctness validator. > CPU: 0 PID: 15175 Comm: syz-executor.5 Not tainted 5.4.0-rc3+ #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS > Google 01