Quoting Al Viro :
On Fri, Nov 30, 2012 at 03:40:34AM +, Al Viro wrote:
The bug is real, but Pavel's patch is all wrong. The problem is in the
argument; we should pass descriptor number, not descriptor + 1. And fixing
that (in iterator_fd() itself) makes all callbacks work as they ought
Quoting Al Viro v...@zeniv.linux.org.uk:
On Fri, Nov 30, 2012 at 03:40:34AM +, Al Viro wrote:
The bug is real, but Pavel's patch is all wrong. The problem is in the
argument; we should pass descriptor number, not descriptor + 1. And fixing
that (in iterator_fd() itself) makes all
On Fri, Nov 30, 2012 at 03:40:34AM +, Al Viro wrote:
> The bug is real, but Pavel's patch is all wrong. The problem is in the
> argument; we should pass descriptor number, not descriptor + 1. And fixing
> that (in iterator_fd() itself) makes all callbacks work as they ought to.
>
> PS:
On Fri, Nov 16, 2012 at 02:58:46PM -0500, Eric Paris wrote:
> On Mon, Nov 12, 2012 at 11:57 AM, Pavel Roskin wrote:
> > Quoting Eric Paris :
> >
> >> OMG this +1 -1 stuff is nuts...
>
> Ping, Al.
>
> int iterate_fd(struct files_struct *files, unsigned n,
> [snip]
> while (!res && n <
On Fri, Nov 16, 2012 at 02:58:46PM -0500, Eric Paris wrote:
On Mon, Nov 12, 2012 at 11:57 AM, Pavel Roskin pro...@gnu.org wrote:
Quoting Eric Paris epa...@parisplace.org:
OMG this +1 -1 stuff is nuts...
Ping, Al.
int iterate_fd(struct files_struct *files, unsigned n,
[snip]
On Fri, Nov 30, 2012 at 03:40:34AM +, Al Viro wrote:
The bug is real, but Pavel's patch is all wrong. The problem is in the
argument; we should pass descriptor number, not descriptor + 1. And fixing
that (in iterator_fd() itself) makes all callbacks work as they ought to.
PS: Pavel,
On Mon, Nov 12, 2012 at 11:57 AM, Pavel Roskin wrote:
> Quoting Eric Paris :
>
>> OMG this +1 -1 stuff is nuts...
Ping, Al.
int iterate_fd(struct files_struct *files, unsigned n,
[snip]
while (!res && n < fdt->max_fds) {
file = rcu_dereference_check_fdtable(files,
On Mon, Nov 12, 2012 at 11:57 AM, Pavel Roskin pro...@gnu.org wrote:
Quoting Eric Paris epa...@parisplace.org:
OMG this +1 -1 stuff is nuts...
Ping, Al.
int iterate_fd(struct files_struct *files, unsigned n,
[snip]
while (!res n fdt-max_fds) {
file =
Quoting Eric Paris :
OMG this +1 -1 stuff is nuts...
iterate_fd passes fd+1 instead of the fd for the file? seriously?
e. I see how this patch fixes it, but still, wouldn't some magic
or negative value for no entries found be better than having to
understand the crazy logics?
I agree.
OMG this +1 -1 stuff is nuts...
iterate_fd passes fd+1 instead of the fd for the file? seriously?
e. I see how this patch fixes it, but still, wouldn't some magic
or negative value for no entries found be better than having to
understand the crazy logics?
/me pokes Al.
On Sun, Nov 11,
OMG this +1 -1 stuff is nuts...
iterate_fd passes fd+1 instead of the fd for the file? seriously?
e. I see how this patch fixes it, but still, wouldn't some magic
or negative value for no entries found be better than having to
understand the crazy logics?
/me pokes Al.
On Sun, Nov 11,
Quoting Eric Paris epa...@parisplace.org:
OMG this +1 -1 stuff is nuts...
iterate_fd passes fd+1 instead of the fd for the file? seriously?
e. I see how this patch fixes it, but still, wouldn't some magic
or negative value for no entries found be better than having to
understand the
Quoting Pavel Roskin :
Hello, Al!
I have noticed that Mozilla Firefox gets stuck for seconds or minutes
on some sites, in particular on Facebook with Linux 3.7-rc1 and newer
mainline kernels. Disabling flash plugin fixes the delays.
This is a Fedora 17 system with SELinux enabled, on x86_64
Quoting Pavel Roskin pro...@gnu.org:
Hello, Al!
I have noticed that Mozilla Firefox gets stuck for seconds or minutes
on some sites, in particular on Facebook with Linux 3.7-rc1 and newer
mainline kernels. Disabling flash plugin fixes the delays.
This is a Fedora 17 system with SELinux
Hello, Al!
I have noticed that Mozilla Firefox gets stuck for seconds or minutes
on some sites, in particular on Facebook with Linux 3.7-rc1 and newer
mainline kernels. Disabling flash plugin fixes the delays.
This is a Fedora 17 system with SELinux enabled, on x86_64
architecture, with
Hello, Al!
I have noticed that Mozilla Firefox gets stuck for seconds or minutes
on some sites, in particular on Facebook with Linux 3.7-rc1 and newer
mainline kernels. Disabling flash plugin fixes the delays.
This is a Fedora 17 system with SELinux enabled, on x86_64
architecture, with
16 matches
Mail list logo
