Re: [PATCH 2.6.12-rc1-mm3] m32r: m32r_sio driver update (was Re: [PATCH] Re: Bitrotting serial drivers)

2005-03-30 Thread Russell King
On Wed, Mar 30, 2005 at 09:59:48AM +0900, Hirokazu Takata wrote: > Here is an additional patch to update m32r_sio driver. > This patch is against 2.6.12-rc1-mm3. > > m32r_sio driver updates: > - Move m32r_sio specific description from asm-m32r/serial.h to > driver/serial/m32r_sio.c. > - Remove

[PATCH 2.6.12-rc1-mm3] m32r: m32r_sio driver update (was Re: [PATCH] Re: Bitrotting serial drivers)

2005-03-29 Thread Hirokazu Takata
driver/serial/m32r_sio.c. Thank you. From: Russell King <[EMAIL PROTECTED]> Subject: Re: [PATCH] Re: Bitrotting serial drivers Date: Thu, 24 Mar 2005 12:17:46 + > On Thu, Mar 24, 2005 at 07:14:24PM +0900, Hirokazu Takata wrote: > > diff -ruNp a/include/asm-m32r/serial.h b/i

Re: [PATCH] Re: Bitrotting serial drivers

2005-03-25 Thread Hirokazu Takata
From: Russell King <[EMAIL PROTECTED]> Date: Thu, 24 Mar 2005 12:17:46 + > On Thu, Mar 24, 2005 at 07:14:24PM +0900, Hirokazu Takata wrote: > > Could you please accept the following patch? > > Probably, but I'd like to have a reply to my comments below first. > > > diff -ruNp a/include/asm-m3

Re: [PATCH] Re: Bitrotting serial drivers

2005-03-24 Thread Russell King
On Thu, Mar 24, 2005 at 07:14:24PM +0900, Hirokazu Takata wrote: > Could you please accept the following patch? Probably, but I'd like to have a reply to my comments below first. > diff -ruNp a/include/asm-m32r/serial.h b/include/asm-m32r/serial.h > --- a/include/asm-m32r/serial.h 2004-12-2

[PATCH] Re: Bitrotting serial drivers

2005-03-24 Thread Hirokazu Takata
Hi, I made a patch to update m32r_sio driver. Compile checked and tested on a M32700UT eva board with SMP kernel. It looks working... Could you please accept the following patch? Thanks, -- Takata From: Russell King <[EMAIL PROTECTED]> Date: Sat, 19 Mar 2005 17:21:01 + > m32r_sio > -

Re: Bitrotting serial drivers

2005-03-22 Thread Michael Stickel
If we leave the driver for the au1x00 as it is it should not have the register_serial / unregister_serial functions and it should be renamed to something else, e.g. ttySAxxx like it is done for the internal serial port of the strongarm (sa1100). I have thought about the serial driver and came a

Re: Bitrotting serial drivers

2005-03-20 Thread Pete Popov
Russell King wrote: On Sun, Mar 20, 2005 at 02:51:40PM -0800, Pete Popov wrote: - __register_serial, register_serial, unregister_serial (this driver doesn't support PCMCIA cards, all of which are based on 8250-compatible devices.) I tried a couple of times to cleanly add support to the 8250 for th

Re: Bitrotting serial drivers

2005-03-20 Thread Russell King
On Sun, Mar 20, 2005 at 02:51:40PM -0800, Pete Popov wrote: > >>>- __register_serial, register_serial, unregister_serial > >>> (this driver doesn't support PCMCIA cards, all of which are based on > >>> 8250-compatible devices.) > > I tried a couple of times to cleanly add support to the 8250 for

Re: Bitrotting serial drivers

2005-03-20 Thread Pete Popov
Ralf Baechle wrote: On Sat, Mar 19, 2005 at 02:13:51PM -0800, Andrew Morton wrote: au1x00_uart --- Maintainer: unknown (akpm - any ideas?) Ralf. Actually Pete Popov ([EMAIL PROTECTED]) who I put on the cc. Thanks :) This is a complete clone of 8250.c, which includes all the 8250-specific

Re: Bitrotting serial drivers

2005-03-20 Thread Ralf Baechle
On Sat, Mar 19, 2005 at 02:13:51PM -0800, Andrew Morton wrote: > > au1x00_uart > > --- > > > > Maintainer: unknown (akpm - any ideas?) > > Ralf. Actually Pete Popov ([EMAIL PROTECTED]) who I put on the cc. > > This is a complete clone of 8250.c, which includes all the 8250-specific > >

Re: Bitrotting serial drivers

2005-03-19 Thread Andrew Morton
Russell King <[EMAIL PROTECTED]> wrote: > > Hi, > > m32r_sio > > > Maintainer: Hirokazu Takata > > Please clean up the m32r_sio driver, removing whatever bits of code > aren't absolutely necessary. > > Specifically, I'd like to see the following addressed: > > - the usage of SERIAL_IO

Bitrotting serial drivers

2005-03-19 Thread Russell King
Hi, m32r_sio Maintainer: Hirokazu Takata Please clean up the m32r_sio driver, removing whatever bits of code aren't absolutely necessary. Specifically, I'd like to see the following addressed: - the usage of SERIAL_IO_HUB6 (this driver doesn't support hub6 cards) - SERIAL_IO_* shoul