Bug in mm.h?

2005-04-07 Thread Leonid Podolny
I fail to understand whether the following is a bug. From what I see, if the page is reserved, page->count is not decreased. The order of the conditions should be reversed. >From mm.h: static inline void put_page(struct page *page) { if (!PageReserved(page) && put_page_testzero(page))

Bug in mm.h?

2005-04-07 Thread Leonid Podolny
I fail to understand whether the following is a bug. From what I see, if the page is reserved, page-count is not decreased. The order of the conditions should be reversed. From mm.h: static inline void put_page(struct page *page) { if (!PageReserved(page) put_page_testzero(page))