Re: CPU capabilities -- an update proposal

2001-02-05 Thread Maciej W. Rozycki
On Fri, 2 Feb 2001, Hugh Dickins wrote: > I like common_x86_capability[], and I like that it's _not_ a struct > cpuinfo_x86 - saves us from wasting time on inventing "common" values > for the other cpuinfo_x86 fields (and'ing, or'ing, min'ing, etc.). That was my first idea. I decided to implem

Re: CPU capabilities -- an update proposal

2001-02-02 Thread H. Peter Anvin
Hugh Dickins wrote: > > I wonder (you or hpa may very quickly point out why this is stupid > and impossible), could we move the identify_cpu() calls into > cpu_init()? I used to think it was called too early for that, but > now I see it's already using current, smp_processor_id(), printk(). >

Re: CPU capabilities -- an update proposal

2001-02-02 Thread Hugh Dickins
On Fri, 2 Feb 2001, H. Peter Anvin wrote: > > > diff -up --recursive --new-file linux-2.4.0-ac12.macro/include/asm-i386/bugs.h >linux-2.4.0-ac12/include/asm-i386/bugs.h > > --- linux-2.4.0-ac12.macro/include/asm-i386/bugs.h Sun Jan 28 09:41:20 2001 > > +++ linux-2.4.0-ac12/include/asm-i386/

Re: CPU capabilities -- an update proposal

2001-02-02 Thread Hugh Dickins
On Fri, 2 Feb 2001, Maciej W. Rozycki wrote: > > Following is the current state of my CPU capabilities rework. It > introduces a new global variable, common_x86_capability, which holds the > common set of flags for CPUs. The boot_cpu_data is used appropriately > again, i.e. it's treated as cur

Re: CPU capabilities -- an update proposal

2001-02-02 Thread H. Peter Anvin
Hi there, I like what you have done here, but there are a few things... > diff -up --recursive --new-file linux-2.4.0-ac12.macro/include/asm-i386/bugs.h >linux-2.4.0-ac12/include/asm-i386/bugs.h > --- linux-2.4.0-ac12.macro/include/asm-i386/bugs.h Sun Jan 28 09:41:20 2001 > +++ linux-2.4.0

CPU capabilities -- an update proposal

2001-02-02 Thread Maciej W. Rozycki
Hi, Following is the current state of my CPU capabilities rework. It introduces a new global variable, common_x86_capability, which holds the common set of flags for CPUs. The boot_cpu_data is used appropriately again, i.e. it's treated as current_cpu_data before smp_store_cpu_info() is called