Re: Can't compile 2.4.3 with agcc

2001-04-24 Thread David Woodhouse
[EMAIL PROTECTED] said: > These "broken and cryptic" checks have been done several times now. > You could certainly add a note to this effect to the documentation on > building the kernel. > Building a known broken kernel just for the sake of "better error > reporting" is dead wrong, IMO. The

Re: Can't compile 2.4.3 with agcc

2001-04-24 Thread Horst von Brand
David Woodhouse <[EMAIL PROTECTED]> said: > [EMAIL PROTECTED] said: > > Your patch (tries to) transform a compile and link time check into a > > runtime check. Not nice. > It transforms a broken and cryptic compile-time check into a correct and > informative runtime check. These "broken and cry

Re: Can't compile 2.4.3 with agcc

2001-04-24 Thread David Woodhouse
[EMAIL PROTECTED] said: > grep '__BUG__' System.map | cut -d\ -f3 Nice try, but nothing prevents even a correct compiler from including it in System.map even though it wouldn't have been called. -- dwmw2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: Can't compile 2.4.3 with agcc

2001-04-24 Thread Russell King
On Mon, Apr 23, 2001 at 11:54:10PM +0100, David Woodhouse wrote: > On Tue, 24 Apr 2001, Andrzej Krzysztofowicz wrote: > > - extern void __buggy_fxsr_alignment(void); > > - __buggy_fxsr_alignment(); > > + extern void >__BUG__task_struct__data_is_not_properly_all

Re: Can't compile 2.4.3 with agcc

2001-04-23 Thread David Woodhouse
On Tue, 24 Apr 2001, Andrzej Krzysztofowicz wrote: > So maybe make the original error message more informative ? > Just something like: > > - extern void __buggy_fxsr_alignment(void); > - __buggy_fxsr_alignment(); > + extern void >__BUG__task_struct__data_is_n

Re: Can't compile 2.4.3 with agcc

2001-04-23 Thread David Woodhouse
[EMAIL PROTECTED] said: > Your patch (tries to) transform a compile and link time check into a > runtime check. Not nice. It transforms a broken and cryptic compile-time check into a correct and informative runtime check. If you can provide a correct and informative compile-time check, that w

Re: Can't compile 2.4.3 with agcc

2001-04-23 Thread Andrzej Krzysztofowicz
> It's known at compile time, but not at preprocessing time, so it can't be > done with #error. If you can come up with a way of doing it at compile time > such that: > > 1. It's _guaranteed_ to work when the compiler does align the members > of the structure as we desire. > 2. It give

Re: Can't compile 2.4.3 with agcc

2001-04-23 Thread Horst von Brand
David Woodhouse <[EMAIL PROTECTED]> said: [...] > Then the kernel should say so, rather than giving a cryptic message like > that, and containing code which isn't actually guaranteed to compile, even > with a compiler which _does_ align the structure as we want it. Your patch (tries to) trans

Re: Can't compile 2.4.3 with agcc

2001-04-23 Thread David Woodhouse
[EMAIL PROTECTED] said: > This is known at compile time, right? Would it not be better to > replace the printk with #error ? Why do I need to boot the bad kernel > to find out that it does not work, when it is known when compiling? It's known at compile time, but not at preprocessing time, so

Re: Can't compile 2.4.3 with agcc

2001-04-23 Thread Matan Ziv-Av
On Mon, 23 Apr 2001, David Woodhouse wrote: > --- include/asm/bugs.h2001/01/18 13:56:53 1.2.2.16 > +++ include/asm/bugs.h2001/04/23 15:45:28 > @@ -80,8 +80,10 @@ >* Verify that the FXSAVE/FXRSTOR data will be 16-byte aligned. >*/ > if (offsetof(struct ta

Re: Can't compile 2.4.3 with agcc

2001-04-23 Thread David Woodhouse
[EMAIL PROTECTED] said: > At least make the final printk a panic.. [EMAIL PROTECTED] said: > replace this with panic() please. I considered this, but in the end decided to copy the method from a few lines above, which triggers in the case of no FPU and no FPE. I wasn't sure if there was a r

Re: Can't compile 2.4.3 with agcc

2001-04-23 Thread Alan Cox
> + printk(KERN_EMERG "This is usually caused by a buggy compiler (perhaps >pgcc?)\n"); > + printk(KERN_EMERG "Cannot continue.\n"); > + for (;;) ; At least make the final printk a panic.. - To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: Can't compile 2.4.3 with agcc

2001-04-23 Thread Ingo Oeser
On Mon, Apr 23, 2001 at 04:52:53PM +0100, David Woodhouse wrote: > RCS file: /inst/cvs/linux/include/asm-i386/bugs.h,v > retrieving revision 1.2.2.16 > diff -u -r1.2.2.16 bugs.h > --- include/asm/bugs.h2001/01/18 13:56:53 1.2.2.16 > +++ include/asm/bugs.h2001/04/23 15:45:28 > @

Re: Can't compile 2.4.3 with agcc

2001-04-23 Thread David Woodhouse
[EMAIL PROTECTED] said: > On Mon, Apr 23, 2001 at 04:13:47PM +0300, mythos wrote: > > init/main.o(.text.init+0x65): undefined reference to `__buggy_fxsr_alignment' > This is a FAQ! (sorry, but I don't know if it is in a FAQ or not). > IIRC, you can't use pgcc to compile linux kernels. Then th

Re: Can't compile 2.4.3 with agcc

2001-04-23 Thread Alan Cox
> Using gcc version pgcc-2.95.3 19991024 (AthlonGCC-0.0.3ex3.1) > I can't compile 2.4.3.I get the follow message: > > init/main.o: In function `check_fpu': > init/main.o(.text.init+0x65): undefined reference to > `__buggy_fxsr_alignment' > make: *** [vmlinux] Error 1 > > Can anyone help me? Tha

Re: Can't compile 2.4.3 with agcc

2001-04-23 Thread Russell King
On Mon, Apr 23, 2001 at 04:13:47PM +0300, mythos wrote: > Using gcc version pgcc-2.95.3 19991024 (AthlonGCC-0.0.3ex3.1) > I can't compile 2.4.3.I get the follow message: > > init/main.o: In function `check_fpu': > init/main.o(.text.init+0x65): undefined reference to > `__buggy_fxsr_alignment' > m

Can't compile 2.4.3 with agcc

2001-04-23 Thread mythos
Using gcc version pgcc-2.95.3 19991024 (AthlonGCC-0.0.3ex3.1) I can't compile 2.4.3.I get the follow message: init/main.o: In function `check_fpu': init/main.o(.text.init+0x65): undefined reference to `__buggy_fxsr_alignment' make: *** [vmlinux] Error 1 Can anyone help me? - To unsubscribe fro