Re: Commit "new primitive: discard_new_inode()" introduces a problem

2018-08-02 Thread Kirill Tkhai
On 01.08.2018 19:34, Al Viro wrote: > On Wed, Aug 01, 2018 at 07:19:35PM +0300, Kirill Tkhai wrote: >> On 01.08.2018 19:16, Al Viro wrote: >>> On Wed, Aug 01, 2018 at 05:11:51PM +0100, Al Viro wrote: On Wed, Aug 01, 2018 at 06:43:56PM +0300, Kirill Tkhai wrote: > #git status > HEAD det

Re: Commit "new primitive: discard_new_inode()" introduces a problem

2018-08-01 Thread Rafael David Tinoco
On Wed, Aug 01, 2018 at 05:34:08PM +0100, Al Viro wrote: > On Wed, Aug 01, 2018 at 07:19:35PM +0300, Kirill Tkhai wrote: > > On 01.08.2018 19:16, Al Viro wrote: > > > On Wed, Aug 01, 2018 at 05:11:51PM +0100, Al Viro wrote: > > >> On Wed, Aug 01, 2018 at 06:43:56PM +0300, Kirill Tkhai wrote: > > >>

Re: Commit "new primitive: discard_new_inode()" introduces a problem

2018-08-01 Thread Rafael David Tinoco
On Wed, Aug 01, 2018 at 05:27:39PM +0100, Al Viro wrote: > On Wed, Aug 01, 2018 at 05:16:48PM +0100, Al Viro wrote: > > On Wed, Aug 01, 2018 at 05:11:51PM +0100, Al Viro wrote: > > > On Wed, Aug 01, 2018 at 06:43:56PM +0300, Kirill Tkhai wrote: > > > > #git status > > > > HEAD detached at 22dc9a168

Re: Commit "new primitive: discard_new_inode()" introduces a problem

2018-08-01 Thread Al Viro
On Wed, Aug 01, 2018 at 07:19:35PM +0300, Kirill Tkhai wrote: > On 01.08.2018 19:16, Al Viro wrote: > > On Wed, Aug 01, 2018 at 05:11:51PM +0100, Al Viro wrote: > >> On Wed, Aug 01, 2018 at 06:43:56PM +0300, Kirill Tkhai wrote: > >>> #git status > >>> HEAD detached at 22dc9a168272 > >> > >> Wait a

Re: Commit "new primitive: discard_new_inode()" introduces a problem

2018-08-01 Thread Al Viro
On Wed, Aug 01, 2018 at 05:16:48PM +0100, Al Viro wrote: > On Wed, Aug 01, 2018 at 05:11:51PM +0100, Al Viro wrote: > > On Wed, Aug 01, 2018 at 06:43:56PM +0300, Kirill Tkhai wrote: > > > #git status > > > HEAD detached at 22dc9a168272 > > > > Wait a sec - just that commit? With discard_new_inode

Re: Commit "new primitive: discard_new_inode()" introduces a problem

2018-08-01 Thread Kirill Tkhai
On 01.08.2018 19:16, Al Viro wrote: > On Wed, Aug 01, 2018 at 05:11:51PM +0100, Al Viro wrote: >> On Wed, Aug 01, 2018 at 06:43:56PM +0300, Kirill Tkhai wrote: >>> #git status >>> HEAD detached at 22dc9a168272 >> >> Wait a sec - just that commit? With discard_new_inode() not even >> used anywhere?

Re: Commit "new primitive: discard_new_inode()" introduces a problem

2018-08-01 Thread Al Viro
On Wed, Aug 01, 2018 at 05:11:51PM +0100, Al Viro wrote: > On Wed, Aug 01, 2018 at 06:43:56PM +0300, Kirill Tkhai wrote: > > #git status > > HEAD detached at 22dc9a168272 > > Wait a sec - just that commit? With discard_new_inode() not even > used anywhere? Then any of those -ENOMEM is disguised

Re: Commit "new primitive: discard_new_inode()" introduces a problem

2018-08-01 Thread Al Viro
On Wed, Aug 01, 2018 at 06:43:56PM +0300, Kirill Tkhai wrote: > #git status > HEAD detached at 22dc9a168272 Wait a sec - just that commit? With discard_new_inode() not even used anywhere? Then any of those -ENOMEM is disguised ERR_PTR(-ESTALE) from find_inode()/find_inode_fast(), i.e. an inode f

Re: Commit "new primitive: discard_new_inode()" introduces a problem

2018-08-01 Thread Kirill Tkhai
On 01.08.2018 18:19, Al Viro wrote: > On Wed, Aug 01, 2018 at 05:43:35PM +0300, Kirill Tkhai wrote: >> Hi, Al, >> >> commit 22dc9a1682722fda8603991595528b87e90436f6 >> Author: Al Viro >> Date: Thu Jun 28 15:53:17 2018 -0400 >> >> new primitive: discard_new_inode() >> >> from current linux-ne

Re: Commit "new primitive: discard_new_inode()" introduces a problem

2018-08-01 Thread Al Viro
On Wed, Aug 01, 2018 at 05:43:35PM +0300, Kirill Tkhai wrote: > Hi, Al, > > commit 22dc9a1682722fda8603991595528b87e90436f6 > Author: Al Viro > Date: Thu Jun 28 15:53:17 2018 -0400 > > new primitive: discard_new_inode() > > from current linux-next introduces the following problem. > It re

Commit "new primitive: discard_new_inode()" introduces a problem

2018-08-01 Thread Kirill Tkhai
Hi, Al, commit 22dc9a1682722fda8603991595528b87e90436f6 Author: Al Viro Date: Thu Jun 28 15:53:17 2018 -0400 new primitive: discard_new_inode() from current linux-next introduces the following problem. It reproduces 100% in my test VM: # cat /etc/mtab /dev/sda1 / ext4 rw 0 0 proc /proc