Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-19 Thread Andreas Herrmann
For the sake of completeness following are given the remaining sets of kernbench results related to this thread. Setup for kernbench test is as described in previous mails but now all 120 logical CPUs were online in all tests. Test runs were still pinned to node 0. Common legend for below tables

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-19 Thread Andreas Herrmann
For the sake of completeness following are given the remaining sets of kernbench results related to this thread. Setup for kernbench test is as described in previous mails but now all 120 logical CPUs were online in all tests. Test runs were still pinned to node 0. Common legend for below tables

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-18 Thread Andreas Herrmann
On Wed, Jul 18, 2018 at 05:25:56PM +0200, Andreas Herrmann wrote: ... > Average mean for user/system/elapsed time and standard deviation for each Oops, of course I meant arithmetic mean. ...

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-18 Thread Andreas Herrmann
On Wed, Jul 18, 2018 at 05:25:56PM +0200, Andreas Herrmann wrote: ... > Average mean for user/system/elapsed time and standard deviation for each Oops, of course I meant arithmetic mean. ...

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-18 Thread Andreas Herrmann
I think I still owe some performance numbers to show what is wrong with systems using pcc-cpufreq with Linux after commit 554c8aa8ecad. Following are results for kernbench tests (from MMTests test suite). That's just a kernel compile with different number of compile jobs. As result the time is

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-18 Thread Andreas Herrmann
I think I still owe some performance numbers to show what is wrong with systems using pcc-cpufreq with Linux after commit 554c8aa8ecad. Following are results for kernbench tests (from MMTests test suite). That's just a kernel compile with different number of compile jobs. As result the time is

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
On Tue, Jul 17, 2018 at 4:03 PM, Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 12:21:36PM +0200, Andreas Herrmann wrote: >> On Tue, Jul 17, 2018 at 12:09:21PM +0200, Rafael J. Wysocki wrote: > > ---8<--- > >> > OK, the patch is below. >> > >> > First, I hope that if "Collaborative Power

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
On Tue, Jul 17, 2018 at 4:03 PM, Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 12:21:36PM +0200, Andreas Herrmann wrote: >> On Tue, Jul 17, 2018 at 12:09:21PM +0200, Rafael J. Wysocki wrote: > > ---8<--- > >> > OK, the patch is below. >> > >> > First, I hope that if "Collaborative Power

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 12:21:36PM +0200, Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 12:09:21PM +0200, Rafael J. Wysocki wrote: ---8<--- > > OK, the patch is below. > > > > First, I hope that if "Collaborative Power Control" is disabled, it will > > simply hide the PCCH object and so

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 12:21:36PM +0200, Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 12:09:21PM +0200, Rafael J. Wysocki wrote: ---8<--- > > OK, the patch is below. > > > > First, I hope that if "Collaborative Power Control" is disabled, it will > > simply hide the PCCH object and so

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
On Tue, Jul 17, 2018 at 12:21 PM, Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 12:09:21PM +0200, Rafael J. Wysocki wrote: >> On Tuesday, July 17, 2018 11:36:20 AM CEST Andreas Herrmann wrote: >> > On Tue, Jul 17, 2018 at 11:27:21AM +0200, Andreas Herrmann wrote: >> > > On Tue, Jul 17, 2018

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
On Tue, Jul 17, 2018 at 12:21 PM, Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 12:09:21PM +0200, Rafael J. Wysocki wrote: >> On Tuesday, July 17, 2018 11:36:20 AM CEST Andreas Herrmann wrote: >> > On Tue, Jul 17, 2018 at 11:27:21AM +0200, Andreas Herrmann wrote: >> > > On Tue, Jul 17, 2018

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 12:09:21PM +0200, Rafael J. Wysocki wrote: > On Tuesday, July 17, 2018 11:36:20 AM CEST Andreas Herrmann wrote: > > On Tue, Jul 17, 2018 at 11:27:21AM +0200, Andreas Herrmann wrote: > > > On Tue, Jul 17, 2018 at 11:23:25AM +0200, Rafael J. Wysocki wrote: > > > > On Tue, Jul

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 12:09:21PM +0200, Rafael J. Wysocki wrote: > On Tuesday, July 17, 2018 11:36:20 AM CEST Andreas Herrmann wrote: > > On Tue, Jul 17, 2018 at 11:27:21AM +0200, Andreas Herrmann wrote: > > > On Tue, Jul 17, 2018 at 11:23:25AM +0200, Rafael J. Wysocki wrote: > > > > On Tue, Jul

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 11:36:20AM +0200, Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 11:27:21AM +0200, Andreas Herrmann wrote: > > On Tue, Jul 17, 2018 at 11:23:25AM +0200, Rafael J. Wysocki wrote: > > > On Tue, Jul 17, 2018 at 11:11 AM, Andreas Herrmann > > > wrote: > > > > On Tue, Jul

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 11:36:20AM +0200, Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 11:27:21AM +0200, Andreas Herrmann wrote: > > On Tue, Jul 17, 2018 at 11:23:25AM +0200, Rafael J. Wysocki wrote: > > > On Tue, Jul 17, 2018 at 11:11 AM, Andreas Herrmann > > > wrote: > > > > On Tue, Jul

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
On Tuesday, July 17, 2018 11:36:20 AM CEST Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 11:27:21AM +0200, Andreas Herrmann wrote: > > On Tue, Jul 17, 2018 at 11:23:25AM +0200, Rafael J. Wysocki wrote: > > > On Tue, Jul 17, 2018 at 11:11 AM, Andreas Herrmann > > > wrote: > > > > On Tue, Jul

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
On Tuesday, July 17, 2018 11:36:20 AM CEST Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 11:27:21AM +0200, Andreas Herrmann wrote: > > On Tue, Jul 17, 2018 at 11:23:25AM +0200, Rafael J. Wysocki wrote: > > > On Tue, Jul 17, 2018 at 11:11 AM, Andreas Herrmann > > > wrote: > > > > On Tue, Jul

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 11:27:21AM +0200, Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 11:23:25AM +0200, Rafael J. Wysocki wrote: > > On Tue, Jul 17, 2018 at 11:11 AM, Andreas Herrmann > > wrote: > > > On Tue, Jul 17, 2018 at 11:06:29AM +0200, Rafael J. Wysocki wrote: > > >> On Tue, Jul 17,

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 11:27:21AM +0200, Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 11:23:25AM +0200, Rafael J. Wysocki wrote: > > On Tue, Jul 17, 2018 at 11:11 AM, Andreas Herrmann > > wrote: > > > On Tue, Jul 17, 2018 at 11:06:29AM +0200, Rafael J. Wysocki wrote: > > >> On Tue, Jul 17,

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 11:23:25AM +0200, Rafael J. Wysocki wrote: > On Tue, Jul 17, 2018 at 11:11 AM, Andreas Herrmann wrote: > > On Tue, Jul 17, 2018 at 11:06:29AM +0200, Rafael J. Wysocki wrote: > >> On Tue, Jul 17, 2018 at 10:50 AM, Andreas Herrmann > >> wrote: > >> > >> [cut] > >> > >> > >

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 11:23:25AM +0200, Rafael J. Wysocki wrote: > On Tue, Jul 17, 2018 at 11:11 AM, Andreas Herrmann wrote: > > On Tue, Jul 17, 2018 at 11:06:29AM +0200, Rafael J. Wysocki wrote: > >> On Tue, Jul 17, 2018 at 10:50 AM, Andreas Herrmann > >> wrote: > >> > >> [cut] > >> > >> > >

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
On Tue, Jul 17, 2018 at 11:11 AM, Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 11:06:29AM +0200, Rafael J. Wysocki wrote: >> On Tue, Jul 17, 2018 at 10:50 AM, Andreas Herrmann >> wrote: >> >> [cut] >> >> > >> > On balance before this commit users could use pcc-cpufreq but had >> > already

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
On Tue, Jul 17, 2018 at 11:11 AM, Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 11:06:29AM +0200, Rafael J. Wysocki wrote: >> On Tue, Jul 17, 2018 at 10:50 AM, Andreas Herrmann >> wrote: >> >> [cut] >> >> > >> > On balance before this commit users could use pcc-cpufreq but had >> > already

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 11:06:29AM +0200, Rafael J. Wysocki wrote: > On Tue, Jul 17, 2018 at 10:50 AM, Andreas Herrmann wrote: > > [cut] > > > > > On balance before this commit users could use pcc-cpufreq but had > > already suboptimal performance (compared to say intel_pstate driver > > which

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 11:06:29AM +0200, Rafael J. Wysocki wrote: > On Tue, Jul 17, 2018 at 10:50 AM, Andreas Herrmann wrote: > > [cut] > > > > > On balance before this commit users could use pcc-cpufreq but had > > already suboptimal performance (compared to say intel_pstate driver > > which

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 10:15:07AM +0200, Peter Zijlstra wrote: > On Tue, Jul 17, 2018 at 08:50:48AM +0200, Andreas Herrmann wrote: > > I've recently noticed that commit 554c8aa8ecad ("sched: idle: Select > > idle state before stopping the tick") causes severe performance drop > > for systems

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
On Tue, Jul 17, 2018 at 10:50 AM, Andreas Herrmann wrote: [cut] > > On balance before this commit users could use pcc-cpufreq but had > already suboptimal performance (compared to say intel_pstate driver > which can be used changing BIOS options). BTW, I wonder why you need to change the BIOS

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
On Tue, Jul 17, 2018 at 10:50 AM, Andreas Herrmann wrote: [cut] > > On balance before this commit users could use pcc-cpufreq but had > already suboptimal performance (compared to say intel_pstate driver > which can be used changing BIOS options). BTW, I wonder why you need to change the BIOS

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 10:15:07AM +0200, Peter Zijlstra wrote: > On Tue, Jul 17, 2018 at 08:50:48AM +0200, Andreas Herrmann wrote: > > I've recently noticed that commit 554c8aa8ecad ("sched: idle: Select > > idle state before stopping the tick") causes severe performance drop > > for systems

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
On Tue, Jul 17, 2018 at 10:50 AM, Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 10:03:41AM +0200, Rafael J. Wysocki wrote: >> On Tue, Jul 17, 2018 at 9:33 AM, Rafael J. Wysocki wrote: >> > Hi, >> > >> > Thanks for your report! >> > >> > On Tue, Jul 17, 2018 at 8:50 AM, Andreas Herrmann >>

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
On Tue, Jul 17, 2018 at 10:50 AM, Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 10:03:41AM +0200, Rafael J. Wysocki wrote: >> On Tue, Jul 17, 2018 at 9:33 AM, Rafael J. Wysocki wrote: >> > Hi, >> > >> > Thanks for your report! >> > >> > On Tue, Jul 17, 2018 at 8:50 AM, Andreas Herrmann >>

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
On Tue, Jul 17, 2018 at 10:36 AM, Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 09:33:53AM +0200, Rafael J. Wysocki wrote: >> Hi, >> >> Thanks for your report! >> >> On Tue, Jul 17, 2018 at 8:50 AM, Andreas Herrmann wrote: >> > Hello, >> > >> > I've recently noticed that commit 554c8aa8ecad

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
On Tue, Jul 17, 2018 at 10:36 AM, Andreas Herrmann wrote: > On Tue, Jul 17, 2018 at 09:33:53AM +0200, Rafael J. Wysocki wrote: >> Hi, >> >> Thanks for your report! >> >> On Tue, Jul 17, 2018 at 8:50 AM, Andreas Herrmann wrote: >> > Hello, >> > >> > I've recently noticed that commit 554c8aa8ecad

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 10:03:41AM +0200, Rafael J. Wysocki wrote: > On Tue, Jul 17, 2018 at 9:33 AM, Rafael J. Wysocki wrote: > > Hi, > > > > Thanks for your report! > > > > On Tue, Jul 17, 2018 at 8:50 AM, Andreas Herrmann > > wrote: > >> Hello, > >> > >> I've recently noticed that commit

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 10:03:41AM +0200, Rafael J. Wysocki wrote: > On Tue, Jul 17, 2018 at 9:33 AM, Rafael J. Wysocki wrote: > > Hi, > > > > Thanks for your report! > > > > On Tue, Jul 17, 2018 at 8:50 AM, Andreas Herrmann > > wrote: > >> Hello, > >> > >> I've recently noticed that commit

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 09:33:53AM +0200, Rafael J. Wysocki wrote: > Hi, > > Thanks for your report! > > On Tue, Jul 17, 2018 at 8:50 AM, Andreas Herrmann wrote: > > Hello, > > > > I've recently noticed that commit 554c8aa8ecad ("sched: idle: Select > > idle state before stopping the tick")

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
On Tue, Jul 17, 2018 at 09:33:53AM +0200, Rafael J. Wysocki wrote: > Hi, > > Thanks for your report! > > On Tue, Jul 17, 2018 at 8:50 AM, Andreas Herrmann wrote: > > Hello, > > > > I've recently noticed that commit 554c8aa8ecad ("sched: idle: Select > > idle state before stopping the tick")

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Peter Zijlstra
On Tue, Jul 17, 2018 at 08:50:48AM +0200, Andreas Herrmann wrote: > I've recently noticed that commit 554c8aa8ecad ("sched: idle: Select > idle state before stopping the tick") causes severe performance drop > for systems using pcc-cpufreq driver. Depending on the number of CPUs > the system might

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Peter Zijlstra
On Tue, Jul 17, 2018 at 08:50:48AM +0200, Andreas Herrmann wrote: > I've recently noticed that commit 554c8aa8ecad ("sched: idle: Select > idle state before stopping the tick") causes severe performance drop > for systems using pcc-cpufreq driver. Depending on the number of CPUs > the system might

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Daniel Lezcano
On 17/07/2018 09:33, Rafael J. Wysocki wrote: > Hi, > > Thanks for your report! > > On Tue, Jul 17, 2018 at 8:50 AM, Andreas Herrmann wrote: >> Hello, >> >> I've recently noticed that commit 554c8aa8ecad ("sched: idle: Select >> idle state before stopping the tick") causes severe performance

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Daniel Lezcano
On 17/07/2018 09:33, Rafael J. Wysocki wrote: > Hi, > > Thanks for your report! > > On Tue, Jul 17, 2018 at 8:50 AM, Andreas Herrmann wrote: >> Hello, >> >> I've recently noticed that commit 554c8aa8ecad ("sched: idle: Select >> idle state before stopping the tick") causes severe performance

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
On Tue, Jul 17, 2018 at 9:33 AM, Rafael J. Wysocki wrote: > Hi, > > Thanks for your report! > > On Tue, Jul 17, 2018 at 8:50 AM, Andreas Herrmann wrote: >> Hello, >> >> I've recently noticed that commit 554c8aa8ecad ("sched: idle: Select >> idle state before stopping the tick") causes severe

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
On Tue, Jul 17, 2018 at 9:33 AM, Rafael J. Wysocki wrote: > Hi, > > Thanks for your report! > > On Tue, Jul 17, 2018 at 8:50 AM, Andreas Herrmann wrote: >> Hello, >> >> I've recently noticed that commit 554c8aa8ecad ("sched: idle: Select >> idle state before stopping the tick") causes severe

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
Hi, Thanks for your report! On Tue, Jul 17, 2018 at 8:50 AM, Andreas Herrmann wrote: > Hello, > > I've recently noticed that commit 554c8aa8ecad ("sched: idle: Select > idle state before stopping the tick") causes severe performance drop > for systems using pcc-cpufreq driver. Depending on the

Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Rafael J. Wysocki
Hi, Thanks for your report! On Tue, Jul 17, 2018 at 8:50 AM, Andreas Herrmann wrote: > Hello, > > I've recently noticed that commit 554c8aa8ecad ("sched: idle: Select > idle state before stopping the tick") causes severe performance drop > for systems using pcc-cpufreq driver. Depending on the

Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
Hello, I've recently noticed that commit 554c8aa8ecad ("sched: idle: Select idle state before stopping the tick") causes severe performance drop for systems using pcc-cpufreq driver. Depending on the number of CPUs the system might be almost unusable. The OS jitter for 4.17.y and 4.18.-rcx

Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq

2018-07-17 Thread Andreas Herrmann
Hello, I've recently noticed that commit 554c8aa8ecad ("sched: idle: Select idle state before stopping the tick") causes severe performance drop for systems using pcc-cpufreq driver. Depending on the number of CPUs the system might be almost unusable. The OS jitter for 4.17.y and 4.18.-rcx